All of lore.kernel.org
 help / color / mirror / Atom feed
* [GIT PULL] nvme fixes for 4.20
@ 2018-11-02  6:37 ` Christoph Hellwig
  0 siblings, 0 replies; 30+ messages in thread
From: Christoph Hellwig @ 2018-11-02  6:37 UTC (permalink / raw)
  To: Jens Axboe; +Cc: Keith Busch, linux-block, Sagi Grimberg, linux-nvme

The following changes since commit a5185607787e030fcb0009194d3b12f8bcca59d6:

  block: brd: associate with queue until adding disk (2018-10-31 08:43:09 -0600)

are available in the Git repository at:

  git://git.infradead.org/nvme.git nvme-4.20

for you to fetch changes up to ae172db3b3f389c363ec7f3683b2cad41091580d:

  nvme-pci: fix conflicting p2p resource adds (2018-11-01 08:44:47 +0200)

----------------------------------------------------------------
James Smart (1):
      nvme-fc: fix request private initialization

Keith Busch (1):
      nvme-pci: fix conflicting p2p resource adds

 drivers/nvme/host/fc.c  | 2 +-
 drivers/nvme/host/pci.c | 5 ++++-
 2 files changed, 5 insertions(+), 2 deletions(-)

^ permalink raw reply	[flat|nested] 30+ messages in thread

* [GIT PULL] nvme fixes for 4.20
@ 2018-11-02  6:37 ` Christoph Hellwig
  0 siblings, 0 replies; 30+ messages in thread
From: Christoph Hellwig @ 2018-11-02  6:37 UTC (permalink / raw)


The following changes since commit a5185607787e030fcb0009194d3b12f8bcca59d6:

  block: brd: associate with queue until adding disk (2018-10-31 08:43:09 -0600)

are available in the Git repository at:

  git://git.infradead.org/nvme.git nvme-4.20

for you to fetch changes up to ae172db3b3f389c363ec7f3683b2cad41091580d:

  nvme-pci: fix conflicting p2p resource adds (2018-11-01 08:44:47 +0200)

----------------------------------------------------------------
James Smart (1):
      nvme-fc: fix request private initialization

Keith Busch (1):
      nvme-pci: fix conflicting p2p resource adds

 drivers/nvme/host/fc.c  | 2 +-
 drivers/nvme/host/pci.c | 5 ++++-
 2 files changed, 5 insertions(+), 2 deletions(-)

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [GIT PULL] nvme fixes for 4.20
  2018-11-02  6:37 ` Christoph Hellwig
@ 2018-11-02 14:15   ` Jens Axboe
  -1 siblings, 0 replies; 30+ messages in thread
From: Jens Axboe @ 2018-11-02 14:15 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: Keith Busch, linux-block, Sagi Grimberg, linux-nvme

On 11/2/18 12:37 AM, Christoph Hellwig wrote:
> The following changes since commit a5185607787e030fcb0009194d3b12f8bcca59d6:
> 
>   block: brd: associate with queue until adding disk (2018-10-31 08:43:09 -0600)
> 
> are available in the Git repository at:
> 
>   git://git.infradead.org/nvme.git nvme-4.20
> 
> for you to fetch changes up to ae172db3b3f389c363ec7f3683b2cad41091580d:
> 
>   nvme-pci: fix conflicting p2p resource adds (2018-11-01 08:44:47 +0200)
> 
> ----------------------------------------------------------------
> James Smart (1):
>       nvme-fc: fix request private initialization
> 
> Keith Busch (1):
>       nvme-pci: fix conflicting p2p resource adds
> 
>  drivers/nvme/host/fc.c  | 2 +-
>  drivers/nvme/host/pci.c | 5 ++++-
>  2 files changed, 5 insertions(+), 2 deletions(-)

Applied these manually, since I had rebased for-linus yesterday to drop
a buggy patch from Ming. JFYI.

-- 
Jens Axboe

^ permalink raw reply	[flat|nested] 30+ messages in thread

* [GIT PULL] nvme fixes for 4.20
@ 2018-11-02 14:15   ` Jens Axboe
  0 siblings, 0 replies; 30+ messages in thread
From: Jens Axboe @ 2018-11-02 14:15 UTC (permalink / raw)


On 11/2/18 12:37 AM, Christoph Hellwig wrote:
> The following changes since commit a5185607787e030fcb0009194d3b12f8bcca59d6:
> 
>   block: brd: associate with queue until adding disk (2018-10-31 08:43:09 -0600)
> 
> are available in the Git repository at:
> 
>   git://git.infradead.org/nvme.git nvme-4.20
> 
> for you to fetch changes up to ae172db3b3f389c363ec7f3683b2cad41091580d:
> 
>   nvme-pci: fix conflicting p2p resource adds (2018-11-01 08:44:47 +0200)
> 
> ----------------------------------------------------------------
> James Smart (1):
>       nvme-fc: fix request private initialization
> 
> Keith Busch (1):
>       nvme-pci: fix conflicting p2p resource adds
> 
>  drivers/nvme/host/fc.c  | 2 +-
>  drivers/nvme/host/pci.c | 5 ++++-
>  2 files changed, 5 insertions(+), 2 deletions(-)

Applied these manually, since I had rebased for-linus yesterday to drop
a buggy patch from Ming. JFYI.

-- 
Jens Axboe

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [GIT PULL] nvme fixes for 4.20
  2018-12-07 15:38 ` Christoph Hellwig
@ 2018-12-07 15:40   ` Jens Axboe
  -1 siblings, 0 replies; 30+ messages in thread
From: Jens Axboe @ 2018-12-07 15:40 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: Keith Busch, linux-block, Sagi Grimberg, linux-nvme

On 12/7/18 8:38 AM, Christoph Hellwig wrote:
> The following changes since commit ba7aeae5539c7a7cccc4cf07a2bc61281a93c50e:
> 
>   block, bfq: fix decrement of num_active_groups (2018-12-07 07:40:07 -0700)
> 
> are available in the Git repository at:
> 
>   git://git.infradead.org/nvme.git nvme-4.20
> 
> for you to fetch changes up to d7dcdf9d4e15189ecfda24cc87339a3425448d5c:
> 
>   nvmet-rdma: fix response use after free (2018-12-07 07:11:11 -0800)
> 
> ----------------------------------------------------------------
> Israel Rukshin (1):
>       nvmet-rdma: fix response use after free
> 
> James Smart (1):
>       nvme: validate controller state before rescheduling keep alive
> 
>  drivers/nvme/host/core.c   | 10 +++++++++-
>  drivers/nvme/target/rdma.c |  3 ++-
>  2 files changed, 11 insertions(+), 2 deletions(-)

Pulled, thanks.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 30+ messages in thread

* [GIT PULL] nvme fixes for 4.20
@ 2018-12-07 15:40   ` Jens Axboe
  0 siblings, 0 replies; 30+ messages in thread
From: Jens Axboe @ 2018-12-07 15:40 UTC (permalink / raw)


On 12/7/18 8:38 AM, Christoph Hellwig wrote:
> The following changes since commit ba7aeae5539c7a7cccc4cf07a2bc61281a93c50e:
> 
>   block, bfq: fix decrement of num_active_groups (2018-12-07 07:40:07 -0700)
> 
> are available in the Git repository at:
> 
>   git://git.infradead.org/nvme.git nvme-4.20
> 
> for you to fetch changes up to d7dcdf9d4e15189ecfda24cc87339a3425448d5c:
> 
>   nvmet-rdma: fix response use after free (2018-12-07 07:11:11 -0800)
> 
> ----------------------------------------------------------------
> Israel Rukshin (1):
>       nvmet-rdma: fix response use after free
> 
> James Smart (1):
>       nvme: validate controller state before rescheduling keep alive
> 
>  drivers/nvme/host/core.c   | 10 +++++++++-
>  drivers/nvme/target/rdma.c |  3 ++-
>  2 files changed, 11 insertions(+), 2 deletions(-)

Pulled, thanks.

-- 
Jens Axboe

^ permalink raw reply	[flat|nested] 30+ messages in thread

* [GIT PULL] nvme fixes for 4.20
@ 2018-12-07 15:38 ` Christoph Hellwig
  0 siblings, 0 replies; 30+ messages in thread
From: Christoph Hellwig @ 2018-12-07 15:38 UTC (permalink / raw)
  To: Jens Axboe; +Cc: Keith Busch, linux-block, Sagi Grimberg, linux-nvme

The following changes since commit ba7aeae5539c7a7cccc4cf07a2bc61281a93c50e:

  block, bfq: fix decrement of num_active_groups (2018-12-07 07:40:07 -0700)

are available in the Git repository at:

  git://git.infradead.org/nvme.git nvme-4.20

for you to fetch changes up to d7dcdf9d4e15189ecfda24cc87339a3425448d5c:

  nvmet-rdma: fix response use after free (2018-12-07 07:11:11 -0800)

----------------------------------------------------------------
Israel Rukshin (1):
      nvmet-rdma: fix response use after free

James Smart (1):
      nvme: validate controller state before rescheduling keep alive

 drivers/nvme/host/core.c   | 10 +++++++++-
 drivers/nvme/target/rdma.c |  3 ++-
 2 files changed, 11 insertions(+), 2 deletions(-)

^ permalink raw reply	[flat|nested] 30+ messages in thread

* [GIT PULL] nvme fixes for 4.20
@ 2018-12-07 15:38 ` Christoph Hellwig
  0 siblings, 0 replies; 30+ messages in thread
From: Christoph Hellwig @ 2018-12-07 15:38 UTC (permalink / raw)


The following changes since commit ba7aeae5539c7a7cccc4cf07a2bc61281a93c50e:

  block, bfq: fix decrement of num_active_groups (2018-12-07 07:40:07 -0700)

are available in the Git repository at:

  git://git.infradead.org/nvme.git nvme-4.20

for you to fetch changes up to d7dcdf9d4e15189ecfda24cc87339a3425448d5c:

  nvmet-rdma: fix response use after free (2018-12-07 07:11:11 -0800)

----------------------------------------------------------------
Israel Rukshin (1):
      nvmet-rdma: fix response use after free

James Smart (1):
      nvme: validate controller state before rescheduling keep alive

 drivers/nvme/host/core.c   | 10 +++++++++-
 drivers/nvme/target/rdma.c |  3 ++-
 2 files changed, 11 insertions(+), 2 deletions(-)

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [GIT PULL] nvme fixes for 4.20
  2018-11-30 16:26     ` Christoph Hellwig
@ 2018-11-30 17:12       ` Jens Axboe
  -1 siblings, 0 replies; 30+ messages in thread
From: Jens Axboe @ 2018-11-30 17:12 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: Keith Busch, linux-block, Sagi Grimberg, linux-nvme

On 11/30/18 9:26 AM, Christoph Hellwig wrote:
> On Fri, Nov 30, 2018 at 08:26:24AM -0700, Jens Axboe wrote:
>> On 11/30/18 8:24 AM, Christoph Hellwig wrote:
>>> Various fixlets all over, including throwing in a 'default y' for the
>>> multipath code, given that we want people to actually enable it for full
>>> functionality.
>>
>> Why enable it by default? 99.9% of users aren't going to care. That
>> seems like an odd choice.
> 
> Because its small, and if you don't have it you are going to run into
> problems pretty soon.

Let's do it for 4.21...

> Anyway, to get the fixes out ASAP here is the updated request without
> it:

Pulled, thanks.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 30+ messages in thread

* [GIT PULL] nvme fixes for 4.20
@ 2018-11-30 17:12       ` Jens Axboe
  0 siblings, 0 replies; 30+ messages in thread
From: Jens Axboe @ 2018-11-30 17:12 UTC (permalink / raw)


On 11/30/18 9:26 AM, Christoph Hellwig wrote:
> On Fri, Nov 30, 2018@08:26:24AM -0700, Jens Axboe wrote:
>> On 11/30/18 8:24 AM, Christoph Hellwig wrote:
>>> Various fixlets all over, including throwing in a 'default y' for the
>>> multipath code, given that we want people to actually enable it for full
>>> functionality.
>>
>> Why enable it by default? 99.9% of users aren't going to care. That
>> seems like an odd choice.
> 
> Because its small, and if you don't have it you are going to run into
> problems pretty soon.

Let's do it for 4.21...

> Anyway, to get the fixes out ASAP here is the updated request without
> it:

Pulled, thanks.

-- 
Jens Axboe

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [GIT PULL] nvme fixes for 4.20
  2018-11-30 15:26   ` Jens Axboe
@ 2018-11-30 16:26     ` Christoph Hellwig
  -1 siblings, 0 replies; 30+ messages in thread
From: Christoph Hellwig @ 2018-11-30 16:26 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Christoph Hellwig, Keith Busch, linux-block, Sagi Grimberg, linux-nvme

On Fri, Nov 30, 2018 at 08:26:24AM -0700, Jens Axboe wrote:
> On 11/30/18 8:24 AM, Christoph Hellwig wrote:
> > Various fixlets all over, including throwing in a 'default y' for the
> > multipath code, given that we want people to actually enable it for full
> > functionality.
> 
> Why enable it by default? 99.9% of users aren't going to care. That
> seems like an odd choice.

Because its small, and if you don't have it you are going to run into
problems pretty soon.

Anyway, to get the fixes out ASAP here is the updated request without
it:

The following changes since commit 14b04063cc994effc86f976625bf8f806d8d44cb:

  Merge branch 'nvme-4.20' of git://git.infradead.org/nvme into for-linus (2018-11-21 05:56:28 -0700)

are available in the Git repository at:

  git://git.infradead.org/nvme.git nvme-4.20

for you to fetch changes up to 6344d02dc8f886b6bbcd922ae1a17e4a41500f2d:

  nvme-rdma: fix double freeing of async event data (2018-11-30 17:23:23 +0100)

----------------------------------------------------------------
Christoph Hellwig (1):
      nvme: warn when finding multi-port subsystems without multipathing enabled

Ewan D. Milne (1):
      nvme-fc: initialize nvme_req(rq)->ctrl after calling __nvme_fc_init_request()

Igor Konopko (1):
      nvme-pci: fix surprise removal

Keith Busch (1):
      nvme: Free ctrl device name on init failure

Prabhath Sajeepa (1):
      nvme-rdma: fix double freeing of async event data

Sagi Grimberg (1):
      nvme: flush namespace scanning work just before removing namespaces

 drivers/nvme/host/core.c | 8 +++++---
 drivers/nvme/host/fc.c   | 2 +-
 drivers/nvme/host/nvme.h | 3 +++
 drivers/nvme/host/rdma.c | 2 ++
 4 files changed, 11 insertions(+), 4 deletions(-)

^ permalink raw reply	[flat|nested] 30+ messages in thread

* [GIT PULL] nvme fixes for 4.20
@ 2018-11-30 16:26     ` Christoph Hellwig
  0 siblings, 0 replies; 30+ messages in thread
From: Christoph Hellwig @ 2018-11-30 16:26 UTC (permalink / raw)


On Fri, Nov 30, 2018@08:26:24AM -0700, Jens Axboe wrote:
> On 11/30/18 8:24 AM, Christoph Hellwig wrote:
> > Various fixlets all over, including throwing in a 'default y' for the
> > multipath code, given that we want people to actually enable it for full
> > functionality.
> 
> Why enable it by default? 99.9% of users aren't going to care. That
> seems like an odd choice.

Because its small, and if you don't have it you are going to run into
problems pretty soon.

Anyway, to get the fixes out ASAP here is the updated request without
it:

The following changes since commit 14b04063cc994effc86f976625bf8f806d8d44cb:

  Merge branch 'nvme-4.20' of git://git.infradead.org/nvme into for-linus (2018-11-21 05:56:28 -0700)

are available in the Git repository at:

  git://git.infradead.org/nvme.git nvme-4.20

for you to fetch changes up to 6344d02dc8f886b6bbcd922ae1a17e4a41500f2d:

  nvme-rdma: fix double freeing of async event data (2018-11-30 17:23:23 +0100)

----------------------------------------------------------------
Christoph Hellwig (1):
      nvme: warn when finding multi-port subsystems without multipathing enabled

Ewan D. Milne (1):
      nvme-fc: initialize nvme_req(rq)->ctrl after calling __nvme_fc_init_request()

Igor Konopko (1):
      nvme-pci: fix surprise removal

Keith Busch (1):
      nvme: Free ctrl device name on init failure

Prabhath Sajeepa (1):
      nvme-rdma: fix double freeing of async event data

Sagi Grimberg (1):
      nvme: flush namespace scanning work just before removing namespaces

 drivers/nvme/host/core.c | 8 +++++---
 drivers/nvme/host/fc.c   | 2 +-
 drivers/nvme/host/nvme.h | 3 +++
 drivers/nvme/host/rdma.c | 2 ++
 4 files changed, 11 insertions(+), 4 deletions(-)

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [GIT PULL] nvme fixes for 4.20
  2018-11-30 15:26   ` Jens Axboe
@ 2018-11-30 15:37     ` Keith Busch
  -1 siblings, 0 replies; 30+ messages in thread
From: Keith Busch @ 2018-11-30 15:37 UTC (permalink / raw)
  To: Jens Axboe; +Cc: Christoph Hellwig, linux-block, Sagi Grimberg, linux-nvme

On Fri, Nov 30, 2018 at 08:26:24AM -0700, Jens Axboe wrote:
> On 11/30/18 8:24 AM, Christoph Hellwig wrote:
> > Various fixlets all over, including throwing in a 'default y' for the
> > multipath code, given that we want people to actually enable it for full
> > functionality.
> 
> Why enable it by default? 99.9% of users aren't going to care. That
> seems like an odd choice.

I'm okay with making it the default, but can we move this to 4.21 please?

^ permalink raw reply	[flat|nested] 30+ messages in thread

* [GIT PULL] nvme fixes for 4.20
@ 2018-11-30 15:37     ` Keith Busch
  0 siblings, 0 replies; 30+ messages in thread
From: Keith Busch @ 2018-11-30 15:37 UTC (permalink / raw)


On Fri, Nov 30, 2018@08:26:24AM -0700, Jens Axboe wrote:
> On 11/30/18 8:24 AM, Christoph Hellwig wrote:
> > Various fixlets all over, including throwing in a 'default y' for the
> > multipath code, given that we want people to actually enable it for full
> > functionality.
> 
> Why enable it by default? 99.9% of users aren't going to care. That
> seems like an odd choice.

I'm okay with making it the default, but can we move this to 4.21 please?

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [GIT PULL] nvme fixes for 4.20
  2018-11-30 15:24 ` Christoph Hellwig
@ 2018-11-30 15:26   ` Jens Axboe
  -1 siblings, 0 replies; 30+ messages in thread
From: Jens Axboe @ 2018-11-30 15:26 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: Keith Busch, linux-block, Sagi Grimberg, linux-nvme

On 11/30/18 8:24 AM, Christoph Hellwig wrote:
> Various fixlets all over, including throwing in a 'default y' for the
> multipath code, given that we want people to actually enable it for full
> functionality.

Why enable it by default? 99.9% of users aren't going to care. That
seems like an odd choice.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 30+ messages in thread

* [GIT PULL] nvme fixes for 4.20
@ 2018-11-30 15:26   ` Jens Axboe
  0 siblings, 0 replies; 30+ messages in thread
From: Jens Axboe @ 2018-11-30 15:26 UTC (permalink / raw)


On 11/30/18 8:24 AM, Christoph Hellwig wrote:
> Various fixlets all over, including throwing in a 'default y' for the
> multipath code, given that we want people to actually enable it for full
> functionality.

Why enable it by default? 99.9% of users aren't going to care. That
seems like an odd choice.

-- 
Jens Axboe

^ permalink raw reply	[flat|nested] 30+ messages in thread

* [GIT PULL] nvme fixes for 4.20
@ 2018-11-30 15:24 ` Christoph Hellwig
  0 siblings, 0 replies; 30+ messages in thread
From: Christoph Hellwig @ 2018-11-30 15:24 UTC (permalink / raw)
  To: Jens Axboe; +Cc: Keith Busch, linux-block, Sagi Grimberg, linux-nvme

Various fixlets all over, including throwing in a 'default y' for the
multipath code, given that we want people to actually enable it for full
functionality.

The following changes since commit 14b04063cc994effc86f976625bf8f806d8d44cb:

  Merge branch 'nvme-4.20' of git://git.infradead.org/nvme into for-linus (2018-11-21 05:56:28 -0700)

are available in the Git repository at:

  git://git.infradead.org/nvme.git nvme-4.20

for you to fetch changes up to d4779afb08ef3f012053cdf3bebed5960587ab88:

  nvme-rdma: fix double freeing of async event data (2018-11-29 16:43:20 +0100)

----------------------------------------------------------------
Christoph Hellwig (2):
      nvme: enable multipathing by default
      nvme: warn when finding multi-port subsystems without multipathing enabled

Ewan D. Milne (1):
      nvme-fc: initialize nvme_req(rq)->ctrl after calling __nvme_fc_init_request()

Igor Konopko (1):
      nvme-pci: fix surprise removal

Keith Busch (1):
      nvme: Free ctrl device name on init failure

Prabhath Sajeepa (1):
      nvme-rdma: fix double freeing of async event data

Sagi Grimberg (1):
      nvme: flush namespace scanning work just before removing namespaces

 drivers/nvme/host/Kconfig | 8 ++++++++
 drivers/nvme/host/core.c  | 8 +++++---
 drivers/nvme/host/fc.c    | 2 +-
 drivers/nvme/host/nvme.h  | 3 +++
 drivers/nvme/host/rdma.c  | 2 ++
 5 files changed, 19 insertions(+), 4 deletions(-)

^ permalink raw reply	[flat|nested] 30+ messages in thread

* [GIT PULL] nvme fixes for 4.20
@ 2018-11-30 15:24 ` Christoph Hellwig
  0 siblings, 0 replies; 30+ messages in thread
From: Christoph Hellwig @ 2018-11-30 15:24 UTC (permalink / raw)


Various fixlets all over, including throwing in a 'default y' for the
multipath code, given that we want people to actually enable it for full
functionality.

The following changes since commit 14b04063cc994effc86f976625bf8f806d8d44cb:

  Merge branch 'nvme-4.20' of git://git.infradead.org/nvme into for-linus (2018-11-21 05:56:28 -0700)

are available in the Git repository at:

  git://git.infradead.org/nvme.git nvme-4.20

for you to fetch changes up to d4779afb08ef3f012053cdf3bebed5960587ab88:

  nvme-rdma: fix double freeing of async event data (2018-11-29 16:43:20 +0100)

----------------------------------------------------------------
Christoph Hellwig (2):
      nvme: enable multipathing by default
      nvme: warn when finding multi-port subsystems without multipathing enabled

Ewan D. Milne (1):
      nvme-fc: initialize nvme_req(rq)->ctrl after calling __nvme_fc_init_request()

Igor Konopko (1):
      nvme-pci: fix surprise removal

Keith Busch (1):
      nvme: Free ctrl device name on init failure

Prabhath Sajeepa (1):
      nvme-rdma: fix double freeing of async event data

Sagi Grimberg (1):
      nvme: flush namespace scanning work just before removing namespaces

 drivers/nvme/host/Kconfig | 8 ++++++++
 drivers/nvme/host/core.c  | 8 +++++---
 drivers/nvme/host/fc.c    | 2 +-
 drivers/nvme/host/nvme.h  | 3 +++
 drivers/nvme/host/rdma.c  | 2 ++
 5 files changed, 19 insertions(+), 4 deletions(-)

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [GIT PULL] nvme fixes for 4.20
  2018-11-09 17:10         ` Sagi Grimberg
@ 2018-11-09 17:12           ` Jens Axboe
  -1 siblings, 0 replies; 30+ messages in thread
From: Jens Axboe @ 2018-11-09 17:12 UTC (permalink / raw)
  To: Sagi Grimberg, Christoph Hellwig; +Cc: Keith Busch, linux-block, linux-nvme

On 11/9/18 10:10 AM, Sagi Grimberg wrote:
> 
>>> That is because your for-linus was still 4.20-rc based when
>>> I created it.
>>
>> It's never been 4.20-rc based. After the initial merge, it got based
>> on a random commit in the merge window:
>>
>> commit 3acbd2de6bc3af215c6ed7732dfc097d1e238503
>> Merge: d49f8a52b15b de7d83da84bd
>> Author: Linus Torvalds <torvalds@linux-foundation.org>
>> Date:   Thu Oct 25 09:00:15 2018 -0700
>>
>>      Merge tag 'sound-4.20-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound
>>
>> and has been ever since.
> 
> That was because I rebased it when your for-linus didn't include Ming's
> buggy version of the brd commit. Sorry for the mixup..

No problem, it's pretty trivial to just do manually for cases like this.

-- 
Jens Axboe

^ permalink raw reply	[flat|nested] 30+ messages in thread

* [GIT PULL] nvme fixes for 4.20
@ 2018-11-09 17:12           ` Jens Axboe
  0 siblings, 0 replies; 30+ messages in thread
From: Jens Axboe @ 2018-11-09 17:12 UTC (permalink / raw)


On 11/9/18 10:10 AM, Sagi Grimberg wrote:
> 
>>> That is because your for-linus was still 4.20-rc based when
>>> I created it.
>>
>> It's never been 4.20-rc based. After the initial merge, it got based
>> on a random commit in the merge window:
>>
>> commit 3acbd2de6bc3af215c6ed7732dfc097d1e238503
>> Merge: d49f8a52b15b de7d83da84bd
>> Author: Linus Torvalds <torvalds at linux-foundation.org>
>> Date:   Thu Oct 25 09:00:15 2018 -0700
>>
>>      Merge tag 'sound-4.20-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound
>>
>> and has been ever since.
> 
> That was because I rebased it when your for-linus didn't include Ming's
> buggy version of the brd commit. Sorry for the mixup..

No problem, it's pretty trivial to just do manually for cases like this.

-- 
Jens Axboe

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [GIT PULL] nvme fixes for 4.20
  2018-11-09 13:29       ` Jens Axboe
@ 2018-11-09 17:10         ` Sagi Grimberg
  -1 siblings, 0 replies; 30+ messages in thread
From: Sagi Grimberg @ 2018-11-09 17:10 UTC (permalink / raw)
  To: Jens Axboe, Christoph Hellwig; +Cc: Keith Busch, linux-block, linux-nvme


>> That is because your for-linus was still 4.20-rc based when
>> I created it.
> 
> It's never been 4.20-rc based. After the initial merge, it got based
> on a random commit in the merge window:
> 
> commit 3acbd2de6bc3af215c6ed7732dfc097d1e238503
> Merge: d49f8a52b15b de7d83da84bd
> Author: Linus Torvalds <torvalds@linux-foundation.org>
> Date:   Thu Oct 25 09:00:15 2018 -0700
> 
>      Merge tag 'sound-4.20-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound
> 
> and has been ever since.

That was because I rebased it when your for-linus didn't include Ming's
buggy version of the brd commit. Sorry for the mixup..

^ permalink raw reply	[flat|nested] 30+ messages in thread

* [GIT PULL] nvme fixes for 4.20
@ 2018-11-09 17:10         ` Sagi Grimberg
  0 siblings, 0 replies; 30+ messages in thread
From: Sagi Grimberg @ 2018-11-09 17:10 UTC (permalink / raw)



>> That is because your for-linus was still 4.20-rc based when
>> I created it.
> 
> It's never been 4.20-rc based. After the initial merge, it got based
> on a random commit in the merge window:
> 
> commit 3acbd2de6bc3af215c6ed7732dfc097d1e238503
> Merge: d49f8a52b15b de7d83da84bd
> Author: Linus Torvalds <torvalds at linux-foundation.org>
> Date:   Thu Oct 25 09:00:15 2018 -0700
> 
>      Merge tag 'sound-4.20-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound
> 
> and has been ever since.

That was because I rebased it when your for-linus didn't include Ming's
buggy version of the brd commit. Sorry for the mixup..

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [GIT PULL] nvme fixes for 4.20
  2018-11-09 13:20     ` Christoph Hellwig
@ 2018-11-09 13:29       ` Jens Axboe
  -1 siblings, 0 replies; 30+ messages in thread
From: Jens Axboe @ 2018-11-09 13:29 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: Keith Busch, linux-block, Sagi Grimberg, linux-nvme

On 11/9/18 6:20 AM, Christoph Hellwig wrote:
> On Fri, Nov 09, 2018 at 06:16:09AM -0700, Jens Axboe wrote:
>> On 11/8/18 11:56 PM, Christoph Hellwig wrote:
>>>  - revert an RDMA commit that didn't help but caused problems
>>>  - fix another minor P2P fallout
>>>  - make sure the multipath device inherits the devices limits of
>>>    the controllers below
>>>
>>> The following changes since commit 651022382c7f8da46cb4872a545ee1da6d097d2a:
>>>
>>>   Linux 4.20-rc1 (2018-11-04 15:37:52 -0800)
>>>
>>> are available in the Git repository at:
>>>
>>>   git://git.infradead.org/nvme.git nvme-4.20
>>
>> This is based on 4.20-rc1 for some reason, not my for-linus. So I get
>> a few thousand extra commits... I pulled the patches and applied
>> manually.
> 
> That is because your for-linus was still 4.20-rc based when
> I created it.

It's never been 4.20-rc based. After the initial merge, it got based
on a random commit in the merge window:

commit 3acbd2de6bc3af215c6ed7732dfc097d1e238503
Merge: d49f8a52b15b de7d83da84bd
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date:   Thu Oct 25 09:00:15 2018 -0700

    Merge tag 'sound-4.20-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound

and has been ever since.

-- 
Jens Axboe

^ permalink raw reply	[flat|nested] 30+ messages in thread

* [GIT PULL] nvme fixes for 4.20
@ 2018-11-09 13:29       ` Jens Axboe
  0 siblings, 0 replies; 30+ messages in thread
From: Jens Axboe @ 2018-11-09 13:29 UTC (permalink / raw)


On 11/9/18 6:20 AM, Christoph Hellwig wrote:
> On Fri, Nov 09, 2018@06:16:09AM -0700, Jens Axboe wrote:
>> On 11/8/18 11:56 PM, Christoph Hellwig wrote:
>>>  - revert an RDMA commit that didn't help but caused problems
>>>  - fix another minor P2P fallout
>>>  - make sure the multipath device inherits the devices limits of
>>>    the controllers below
>>>
>>> The following changes since commit 651022382c7f8da46cb4872a545ee1da6d097d2a:
>>>
>>>   Linux 4.20-rc1 (2018-11-04 15:37:52 -0800)
>>>
>>> are available in the Git repository at:
>>>
>>>   git://git.infradead.org/nvme.git nvme-4.20
>>
>> This is based on 4.20-rc1 for some reason, not my for-linus. So I get
>> a few thousand extra commits... I pulled the patches and applied
>> manually.
> 
> That is because your for-linus was still 4.20-rc based when
> I created it.

It's never been 4.20-rc based. After the initial merge, it got based
on a random commit in the merge window:

commit 3acbd2de6bc3af215c6ed7732dfc097d1e238503
Merge: d49f8a52b15b de7d83da84bd
Author: Linus Torvalds <torvalds at linux-foundation.org>
Date:   Thu Oct 25 09:00:15 2018 -0700

    Merge tag 'sound-4.20-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound

and has been ever since.

-- 
Jens Axboe

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [GIT PULL] nvme fixes for 4.20
  2018-11-09 13:16   ` Jens Axboe
@ 2018-11-09 13:20     ` Christoph Hellwig
  -1 siblings, 0 replies; 30+ messages in thread
From: Christoph Hellwig @ 2018-11-09 13:20 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Christoph Hellwig, Keith Busch, linux-block, Sagi Grimberg, linux-nvme

On Fri, Nov 09, 2018 at 06:16:09AM -0700, Jens Axboe wrote:
> On 11/8/18 11:56 PM, Christoph Hellwig wrote:
> >  - revert an RDMA commit that didn't help but caused problems
> >  - fix another minor P2P fallout
> >  - make sure the multipath device inherits the devices limits of
> >    the controllers below
> > 
> > The following changes since commit 651022382c7f8da46cb4872a545ee1da6d097d2a:
> > 
> >   Linux 4.20-rc1 (2018-11-04 15:37:52 -0800)
> > 
> > are available in the Git repository at:
> > 
> >   git://git.infradead.org/nvme.git nvme-4.20
> 
> This is based on 4.20-rc1 for some reason, not my for-linus. So I get
> a few thousand extra commits... I pulled the patches and applied
> manually.

That is because your for-linus was still 4.20-rc based when
I created it.

^ permalink raw reply	[flat|nested] 30+ messages in thread

* [GIT PULL] nvme fixes for 4.20
@ 2018-11-09 13:20     ` Christoph Hellwig
  0 siblings, 0 replies; 30+ messages in thread
From: Christoph Hellwig @ 2018-11-09 13:20 UTC (permalink / raw)


On Fri, Nov 09, 2018@06:16:09AM -0700, Jens Axboe wrote:
> On 11/8/18 11:56 PM, Christoph Hellwig wrote:
> >  - revert an RDMA commit that didn't help but caused problems
> >  - fix another minor P2P fallout
> >  - make sure the multipath device inherits the devices limits of
> >    the controllers below
> > 
> > The following changes since commit 651022382c7f8da46cb4872a545ee1da6d097d2a:
> > 
> >   Linux 4.20-rc1 (2018-11-04 15:37:52 -0800)
> > 
> > are available in the Git repository at:
> > 
> >   git://git.infradead.org/nvme.git nvme-4.20
> 
> This is based on 4.20-rc1 for some reason, not my for-linus. So I get
> a few thousand extra commits... I pulled the patches and applied
> manually.

That is because your for-linus was still 4.20-rc based when
I created it.

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [GIT PULL] nvme fixes for 4.20
  2018-11-09  6:56 ` Christoph Hellwig
@ 2018-11-09 13:16   ` Jens Axboe
  -1 siblings, 0 replies; 30+ messages in thread
From: Jens Axboe @ 2018-11-09 13:16 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: Keith Busch, linux-block, Sagi Grimberg, linux-nvme

On 11/8/18 11:56 PM, Christoph Hellwig wrote:
>  - revert an RDMA commit that didn't help but caused problems
>  - fix another minor P2P fallout
>  - make sure the multipath device inherits the devices limits of
>    the controllers below
> 
> The following changes since commit 651022382c7f8da46cb4872a545ee1da6d097d2a:
> 
>   Linux 4.20-rc1 (2018-11-04 15:37:52 -0800)
> 
> are available in the Git repository at:
> 
>   git://git.infradead.org/nvme.git nvme-4.20

This is based on 4.20-rc1 for some reason, not my for-linus. So I get
a few thousand extra commits... I pulled the patches and applied
manually.

-- 
Jens Axboe

^ permalink raw reply	[flat|nested] 30+ messages in thread

* [GIT PULL] nvme fixes for 4.20
@ 2018-11-09 13:16   ` Jens Axboe
  0 siblings, 0 replies; 30+ messages in thread
From: Jens Axboe @ 2018-11-09 13:16 UTC (permalink / raw)


On 11/8/18 11:56 PM, Christoph Hellwig wrote:
>  - revert an RDMA commit that didn't help but caused problems
>  - fix another minor P2P fallout
>  - make sure the multipath device inherits the devices limits of
>    the controllers below
> 
> The following changes since commit 651022382c7f8da46cb4872a545ee1da6d097d2a:
> 
>   Linux 4.20-rc1 (2018-11-04 15:37:52 -0800)
> 
> are available in the Git repository at:
> 
>   git://git.infradead.org/nvme.git nvme-4.20

This is based on 4.20-rc1 for some reason, not my for-linus. So I get
a few thousand extra commits... I pulled the patches and applied
manually.

-- 
Jens Axboe

^ permalink raw reply	[flat|nested] 30+ messages in thread

* [GIT PULL] nvme fixes for 4.20
@ 2018-11-09  6:56 ` Christoph Hellwig
  0 siblings, 0 replies; 30+ messages in thread
From: Christoph Hellwig @ 2018-11-09  6:56 UTC (permalink / raw)
  To: Jens Axboe; +Cc: Keith Busch, linux-block, Sagi Grimberg, linux-nvme

 - revert an RDMA commit that didn't help but caused problems
 - fix another minor P2P fallout
 - make sure the multipath device inherits the devices limits of
   the controllers below

The following changes since commit 651022382c7f8da46cb4872a545ee1da6d097d2a:

  Linux 4.20-rc1 (2018-11-04 15:37:52 -0800)

are available in the Git repository at:

  git://git.infradead.org/nvme.git nvme-4.20

for you to fetch changes up to 72e43e497b07d607142f07a8c56794261fbe089b:

  Revert "nvmet-rdma: use a private workqueue for delete" (2018-11-07 09:27:22 +0100)

----------------------------------------------------------------
Christoph Hellwig (1):
      Revert "nvmet-rdma: use a private workqueue for delete"

Sagi Grimberg (2):
      nvmet: don't try to add ns to p2p map unless it actually uses it
      nvme: make sure ns head inherits underlying device limits

 drivers/nvme/host/core.c      |  4 +++-
 drivers/nvme/host/multipath.c |  1 +
 drivers/nvme/target/core.c    |  2 +-
 drivers/nvme/target/rdma.c    | 19 ++++---------------
 4 files changed, 9 insertions(+), 17 deletions(-)

^ permalink raw reply	[flat|nested] 30+ messages in thread

* [GIT PULL] nvme fixes for 4.20
@ 2018-11-09  6:56 ` Christoph Hellwig
  0 siblings, 0 replies; 30+ messages in thread
From: Christoph Hellwig @ 2018-11-09  6:56 UTC (permalink / raw)


 - revert an RDMA commit that didn't help but caused problems
 - fix another minor P2P fallout
 - make sure the multipath device inherits the devices limits of
   the controllers below

The following changes since commit 651022382c7f8da46cb4872a545ee1da6d097d2a:

  Linux 4.20-rc1 (2018-11-04 15:37:52 -0800)

are available in the Git repository at:

  git://git.infradead.org/nvme.git nvme-4.20

for you to fetch changes up to 72e43e497b07d607142f07a8c56794261fbe089b:

  Revert "nvmet-rdma: use a private workqueue for delete" (2018-11-07 09:27:22 +0100)

----------------------------------------------------------------
Christoph Hellwig (1):
      Revert "nvmet-rdma: use a private workqueue for delete"

Sagi Grimberg (2):
      nvmet: don't try to add ns to p2p map unless it actually uses it
      nvme: make sure ns head inherits underlying device limits

 drivers/nvme/host/core.c      |  4 +++-
 drivers/nvme/host/multipath.c |  1 +
 drivers/nvme/target/core.c    |  2 +-
 drivers/nvme/target/rdma.c    | 19 ++++---------------
 4 files changed, 9 insertions(+), 17 deletions(-)

^ permalink raw reply	[flat|nested] 30+ messages in thread

end of thread, other threads:[~2018-12-07 15:40 UTC | newest]

Thread overview: 30+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-02  6:37 [GIT PULL] nvme fixes for 4.20 Christoph Hellwig
2018-11-02  6:37 ` Christoph Hellwig
2018-11-02 14:15 ` Jens Axboe
2018-11-02 14:15   ` Jens Axboe
2018-11-09  6:56 Christoph Hellwig
2018-11-09  6:56 ` Christoph Hellwig
2018-11-09 13:16 ` Jens Axboe
2018-11-09 13:16   ` Jens Axboe
2018-11-09 13:20   ` Christoph Hellwig
2018-11-09 13:20     ` Christoph Hellwig
2018-11-09 13:29     ` Jens Axboe
2018-11-09 13:29       ` Jens Axboe
2018-11-09 17:10       ` Sagi Grimberg
2018-11-09 17:10         ` Sagi Grimberg
2018-11-09 17:12         ` Jens Axboe
2018-11-09 17:12           ` Jens Axboe
2018-11-30 15:24 Christoph Hellwig
2018-11-30 15:24 ` Christoph Hellwig
2018-11-30 15:26 ` Jens Axboe
2018-11-30 15:26   ` Jens Axboe
2018-11-30 15:37   ` Keith Busch
2018-11-30 15:37     ` Keith Busch
2018-11-30 16:26   ` Christoph Hellwig
2018-11-30 16:26     ` Christoph Hellwig
2018-11-30 17:12     ` Jens Axboe
2018-11-30 17:12       ` Jens Axboe
2018-12-07 15:38 Christoph Hellwig
2018-12-07 15:38 ` Christoph Hellwig
2018-12-07 15:40 ` Jens Axboe
2018-12-07 15:40   ` Jens Axboe

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.