From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756035AbeDXFno (ORCPT ); Tue, 24 Apr 2018 01:43:44 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:47072 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751469AbeDXFnl (ORCPT ); Tue, 24 Apr 2018 01:43:41 -0400 X-Google-Smtp-Source: AB8JxZoTSy+M6ZsMfVkePyAxfLi7HwkPdEcuRSV/DK3M0eJwCwOMJ2rS7w+e4npzAT/NSPcNwoNADA== Subject: Re: [Xen-devel] [PATCH 0/1] drm/xen-zcopy: Add Xen zero-copy helper DRM driver To: Boris Ostrovsky , Wei Liu Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , jgross@suse.com, Artem Mygaiev , Dongwon Kim , konrad.wilk@oracle.com, airlied@linux.ie, "Oleksandr_Andrushchenko@epam.com" , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, "Potrola, MateuszX" , xen-devel@lists.xenproject.org, daniel.vetter@intel.com References: <5d8fec7f-956c-378f-be90-f45029385740@gmail.com> <20180416192905.GA18096@downor-Z87X-UD5H> <20180417075928.GT31310@phenom.ffwll.local> <20180417205744.GA15930@downor-Z87X-UD5H> <41487acb-a67a-8933-d0c3-702c19b0938e@gmail.com> <20180418073508.ptvntwedczpvl7bx@MacBook-Pro-de-Roger.local> <20180418101058.hyqk3gr3b2ibxswu@MacBook-Pro-de-Roger.local> <20180420071914.GG31310@phenom.ffwll.local> <76cdc65a-7bb1-9377-7bc5-6164e32f7b5d@gmail.com> <20180423115242.ywdwqblj2aseu3fr@citrix.com> <61105351-8896-072b-abf0-757c7f6c0edf@gmail.com> From: Oleksandr Andrushchenko Message-ID: <30ddb005-96c8-f47c-2e23-4e0d354e5842@gmail.com> Date: Tue, 24 Apr 2018 08:43:37 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/24/2018 01:41 AM, Boris Ostrovsky wrote: > On 04/23/2018 08:10 AM, Oleksandr Andrushchenko wrote: >> On 04/23/2018 02:52 PM, Wei Liu wrote: >>> On Fri, Apr 20, 2018 at 02:25:20PM +0300, Oleksandr Andrushchenko wrote: >>>>>>      the gntdev. >>>>>> >>>>>> I think this is generic enough that it could be implemented by a >>>>>> device not tied to Xen. AFAICT the hyper_dma guys also wanted >>>>>> something similar to this. >>>>> You can't just wrap random userspace memory into a dma-buf. We've >>>>> just had >>>>> this discussion with kvm/qemu folks, who proposed just that, and >>>>> after a >>>>> bit of discussion they'll now try to have a driver which just wraps a >>>>> memfd into a dma-buf. >>>> So, we have to decide either we introduce a new driver >>>> (say, under drivers/xen/xen-dma-buf) or extend the existing >>>> gntdev/balloon to support dma-buf use-cases. >>>> >>>> Can anybody from Xen community express their preference here? >>>> >>> Oleksandr talked to me on IRC about this, he said a few IOCTLs need to >>> be added to either existing drivers or a new driver. >>> >>> I went through this thread twice and skimmed through the relevant >>> documents, but I couldn't see any obvious pros and cons for either >>> approach. So I don't really have an opinion on this. >>> >>> But, assuming if implemented in existing drivers, those IOCTLs need to >>> be added to different drivers, which means userspace program needs to >>> write more code and get more handles, it would be slightly better to >>> implement a new driver from that perspective. >> If gntdev/balloon extension is still considered: >> >> All the IOCTLs will be in gntdev driver (in current xen-zcopy >> terminology): >>  - DRM_ICOTL_XEN_ZCOPY_DUMB_FROM_REFS >>  - DRM_IOCTL_XEN_ZCOPY_DUMB_TO_REFS >>  - DRM_IOCTL_XEN_ZCOPY_DUMB_WAIT_FREE >> >> Balloon driver extension, which is needed for contiguous/DMA >> buffers, will be to provide new *kernel API*, no UAPI is needed. >> > > So I am obviously a bit late to this thread, but why do you need to add > new ioctls to gntdev and balloon? Doesn't this driver manage to do what > you want without any extensions? 1. I only (may) need to add IOCTLs to gntdev 2. balloon driver needs to be extended, so it can allocate contiguous (DMA) memory, not IOCTLs/UAPI here, all lives in the kernel. 3. The reason I need to extend gnttab with new IOCTLs is to provide new functionality to create a dma-buf from grant references and to produce grant references for a dma-buf. This is what I have as UAPI description for xen-zcopy driver: 1. DRM_IOCTL_XEN_ZCOPY_DUMB_FROM_REFS This will create a DRM dumb buffer from grant references provided by the frontend. The intended usage is:   - Frontend     - creates a dumb/display buffer and allocates memory     - grants foreign access to the buffer pages     - passes granted references to the backend   - Backend     - issues DRM_XEN_ZCOPY_DUMB_FROM_REFS ioctl to map       granted references and create a dumb buffer     - requests handle to fd conversion via DRM_IOCTL_PRIME_HANDLE_TO_FD     - requests real HW driver/consumer to import the PRIME buffer with       DRM_IOCTL_PRIME_FD_TO_HANDLE     - uses handle returned by the real HW driver   - at the end:     o closes real HW driver's handle with DRM_IOCTL_GEM_CLOSE     o closes zero-copy driver's handle with DRM_IOCTL_GEM_CLOSE     o closes file descriptor of the exported buffer 2. DRM_IOCTL_XEN_ZCOPY_DUMB_TO_REFS This will grant references to a dumb/display buffer's memory provided by the backend. The intended usage is:   - Frontend     - requests backend to allocate dumb/display buffer and grant references       to its pages   - Backend     - requests real HW driver to create a dumb with DRM_IOCTL_MODE_CREATE_DUMB     - requests handle to fd conversion via DRM_IOCTL_PRIME_HANDLE_TO_FD     - requests zero-copy driver to import the PRIME buffer with       DRM_IOCTL_PRIME_FD_TO_HANDLE     - issues DRM_XEN_ZCOPY_DUMB_TO_REFS ioctl to       grant references to the buffer's memory.     - passes grant references to the frontend  - at the end:     - closes zero-copy driver's handle with DRM_IOCTL_GEM_CLOSE     - closes real HW driver's handle with DRM_IOCTL_GEM_CLOSE     - closes file descriptor of the imported buffer 3. DRM_XEN_ZCOPY_DUMB_WAIT_FREE This will block until the dumb buffer with the wait handle provided be freed: this is needed for synchronization between frontend and backend in case frontend provides grant references of the buffer via DRM_XEN_ZCOPY_DUMB_FROM_REFS IOCTL and which must be released before backend replies with XENDISPL_OP_DBUF_DESTROY response. wait_handle must be the same value returned while calling DRM_XEN_ZCOPY_DUMB_FROM_REFS IOCTL. So, as you can see the above functionality is not covered by the existing UAPI of the gntdev driver. Now, if we change dumb -> dma-buf and remove DRM code (which is only a wrapper here on top of dma-buf) we get new driver for dma-buf for Xen. This is why I have 2 options here: either create a dedicated driver for this (e.g. re-work xen-zcopy to be DRM independent and put it under drivers/xen/xen-dma-buf, for example) or extend the existing gntdev driver with the above UAPI + make changes to the balloon driver to provide kernel API for DMA buffer allocations. So, this is where I need to understand Xen community's preference, so the implementation is not questioned later on. > -boris Thank you, Oleksandr From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oleksandr Andrushchenko Subject: Re: [Xen-devel] [PATCH 0/1] drm/xen-zcopy: Add Xen zero-copy helper DRM driver Date: Tue, 24 Apr 2018 08:43:37 +0300 Message-ID: <30ddb005-96c8-f47c-2e23-4e0d354e5842@gmail.com> References: <5d8fec7f-956c-378f-be90-f45029385740@gmail.com> <20180416192905.GA18096@downor-Z87X-UD5H> <20180417075928.GT31310@phenom.ffwll.local> <20180417205744.GA15930@downor-Z87X-UD5H> <41487acb-a67a-8933-d0c3-702c19b0938e@gmail.com> <20180418073508.ptvntwedczpvl7bx@MacBook-Pro-de-Roger.local> <20180418101058.hyqk3gr3b2ibxswu@MacBook-Pro-de-Roger.local> <20180420071914.GG31310@phenom.ffwll.local> <76cdc65a-7bb1-9377-7bc5-6164e32f7b5d@gmail.com> <20180423115242.ywdwqblj2aseu3fr@citrix.com> <61105351-8896-072b-abf0-757c7f6c0edf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail-lf0-x241.google.com (mail-lf0-x241.google.com [IPv6:2a00:1450:4010:c07::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6D3CB6E347 for ; Tue, 24 Apr 2018 05:43:41 +0000 (UTC) Received: by mail-lf0-x241.google.com with SMTP id m18-v6so1060214lfb.0 for ; Mon, 23 Apr 2018 22:43:41 -0700 (PDT) In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Boris Ostrovsky , Wei Liu Cc: jgross@suse.com, Artem Mygaiev , Dongwon Kim , konrad.wilk@oracle.com, airlied@linux.ie, "Oleksandr_Andrushchenko@epam.com" , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, "Potrola, MateuszX" , daniel.vetter@intel.com, xen-devel@lists.xenproject.org, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= List-Id: dri-devel@lists.freedesktop.org T24gMDQvMjQvMjAxOCAwMTo0MSBBTSwgQm9yaXMgT3N0cm92c2t5IHdyb3RlOgo+IE9uIDA0LzIz LzIwMTggMDg6MTAgQU0sIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOgo+PiBPbiAwNC8y My8yMDE4IDAyOjUyIFBNLCBXZWkgTGl1IHdyb3RlOgo+Pj4gT24gRnJpLCBBcHIgMjAsIDIwMTgg YXQgMDI6MjU6MjBQTSArMDMwMCwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6Cj4+Pj4+ PiAgwqDCoMKgwqAgdGhlIGdudGRldi4KPj4+Pj4+Cj4+Pj4+PiBJIHRoaW5rIHRoaXMgaXMgZ2Vu ZXJpYyBlbm91Z2ggdGhhdCBpdCBjb3VsZCBiZSBpbXBsZW1lbnRlZCBieSBhCj4+Pj4+PiBkZXZp Y2Ugbm90IHRpZWQgdG8gWGVuLiBBRkFJQ1QgdGhlIGh5cGVyX2RtYSBndXlzIGFsc28gd2FudGVk Cj4+Pj4+PiBzb21ldGhpbmcgc2ltaWxhciB0byB0aGlzLgo+Pj4+PiBZb3UgY2FuJ3QganVzdCB3 cmFwIHJhbmRvbSB1c2Vyc3BhY2UgbWVtb3J5IGludG8gYSBkbWEtYnVmLiBXZSd2ZQo+Pj4+PiBq dXN0IGhhZAo+Pj4+PiB0aGlzIGRpc2N1c3Npb24gd2l0aCBrdm0vcWVtdSBmb2xrcywgd2hvIHBy b3Bvc2VkIGp1c3QgdGhhdCwgYW5kCj4+Pj4+IGFmdGVyIGEKPj4+Pj4gYml0IG9mIGRpc2N1c3Np b24gdGhleSdsbCBub3cgdHJ5IHRvIGhhdmUgYSBkcml2ZXIgd2hpY2gganVzdCB3cmFwcyBhCj4+ Pj4+IG1lbWZkIGludG8gYSBkbWEtYnVmLgo+Pj4+IFNvLCB3ZSBoYXZlIHRvIGRlY2lkZSBlaXRo ZXIgd2UgaW50cm9kdWNlIGEgbmV3IGRyaXZlcgo+Pj4+IChzYXksIHVuZGVyIGRyaXZlcnMveGVu L3hlbi1kbWEtYnVmKSBvciBleHRlbmQgdGhlIGV4aXN0aW5nCj4+Pj4gZ250ZGV2L2JhbGxvb24g dG8gc3VwcG9ydCBkbWEtYnVmIHVzZS1jYXNlcy4KPj4+Pgo+Pj4+IENhbiBhbnlib2R5IGZyb20g WGVuIGNvbW11bml0eSBleHByZXNzIHRoZWlyIHByZWZlcmVuY2UgaGVyZT8KPj4+Pgo+Pj4gT2xl a3NhbmRyIHRhbGtlZCB0byBtZSBvbiBJUkMgYWJvdXQgdGhpcywgaGUgc2FpZCBhIGZldyBJT0NU THMgbmVlZCB0bwo+Pj4gYmUgYWRkZWQgdG8gZWl0aGVyIGV4aXN0aW5nIGRyaXZlcnMgb3IgYSBu ZXcgZHJpdmVyLgo+Pj4KPj4+IEkgd2VudCB0aHJvdWdoIHRoaXMgdGhyZWFkIHR3aWNlIGFuZCBz a2ltbWVkIHRocm91Z2ggdGhlIHJlbGV2YW50Cj4+PiBkb2N1bWVudHMsIGJ1dCBJIGNvdWxkbid0 IHNlZSBhbnkgb2J2aW91cyBwcm9zIGFuZCBjb25zIGZvciBlaXRoZXIKPj4+IGFwcHJvYWNoLiBT byBJIGRvbid0IHJlYWxseSBoYXZlIGFuIG9waW5pb24gb24gdGhpcy4KPj4+Cj4+PiBCdXQsIGFz c3VtaW5nIGlmIGltcGxlbWVudGVkIGluIGV4aXN0aW5nIGRyaXZlcnMsIHRob3NlIElPQ1RMcyBu ZWVkIHRvCj4+PiBiZSBhZGRlZCB0byBkaWZmZXJlbnQgZHJpdmVycywgd2hpY2ggbWVhbnMgdXNl cnNwYWNlIHByb2dyYW0gbmVlZHMgdG8KPj4+IHdyaXRlIG1vcmUgY29kZSBhbmQgZ2V0IG1vcmUg aGFuZGxlcywgaXQgd291bGQgYmUgc2xpZ2h0bHkgYmV0dGVyIHRvCj4+PiBpbXBsZW1lbnQgYSBu ZXcgZHJpdmVyIGZyb20gdGhhdCBwZXJzcGVjdGl2ZS4KPj4gSWYgZ250ZGV2L2JhbGxvb24gZXh0 ZW5zaW9uIGlzIHN0aWxsIGNvbnNpZGVyZWQ6Cj4+Cj4+IEFsbCB0aGUgSU9DVExzIHdpbGwgYmUg aW4gZ250ZGV2IGRyaXZlciAoaW4gY3VycmVudCB4ZW4temNvcHkKPj4gdGVybWlub2xvZ3kpOgo+ PiAgwqAtIERSTV9JQ09UTF9YRU5fWkNPUFlfRFVNQl9GUk9NX1JFRlMKPj4gIMKgLSBEUk1fSU9D VExfWEVOX1pDT1BZX0RVTUJfVE9fUkVGUwo+PiAgwqAtIERSTV9JT0NUTF9YRU5fWkNPUFlfRFVN Ql9XQUlUX0ZSRUUKPj4KPj4gQmFsbG9vbiBkcml2ZXIgZXh0ZW5zaW9uLCB3aGljaCBpcyBuZWVk ZWQgZm9yIGNvbnRpZ3VvdXMvRE1BCj4+IGJ1ZmZlcnMsIHdpbGwgYmUgdG8gcHJvdmlkZSBuZXcg Kmtlcm5lbCBBUEkqLCBubyBVQVBJIGlzIG5lZWRlZC4KPj4KPgo+IFNvIEkgYW0gb2J2aW91c2x5 IGEgYml0IGxhdGUgdG8gdGhpcyB0aHJlYWQsIGJ1dCB3aHkgZG8geW91IG5lZWQgdG8gYWRkCj4g bmV3IGlvY3RscyB0byBnbnRkZXYgYW5kIGJhbGxvb24/IERvZXNuJ3QgdGhpcyBkcml2ZXIgbWFu YWdlIHRvIGRvIHdoYXQKPiB5b3Ugd2FudCB3aXRob3V0IGFueSBleHRlbnNpb25zPwoxLiBJIG9u bHkgKG1heSkgbmVlZCB0byBhZGQgSU9DVExzIHRvIGdudGRldgoyLiBiYWxsb29uIGRyaXZlciBu ZWVkcyB0byBiZSBleHRlbmRlZCwgc28gaXQgY2FuIGFsbG9jYXRlCmNvbnRpZ3VvdXMgKERNQSkg bWVtb3J5LCBub3QgSU9DVExzL1VBUEkgaGVyZSwgYWxsIGxpdmVzCmluIHRoZSBrZXJuZWwuCjMu IFRoZSByZWFzb24gSSBuZWVkIHRvIGV4dGVuZCBnbnR0YWIgd2l0aCBuZXcgSU9DVExzIGlzIHRv CnByb3ZpZGUgbmV3IGZ1bmN0aW9uYWxpdHkgdG8gY3JlYXRlIGEgZG1hLWJ1ZiBmcm9tIGdyYW50 IHJlZmVyZW5jZXMKYW5kIHRvIHByb2R1Y2UgZ3JhbnQgcmVmZXJlbmNlcyBmb3IgYSBkbWEtYnVm LiBUaGlzIGlzIHdoYXQgSSBoYXZlIGFzIFVBUEkKZGVzY3JpcHRpb24gZm9yIHhlbi16Y29weSBk cml2ZXI6CgoxLiBEUk1fSU9DVExfWEVOX1pDT1BZX0RVTUJfRlJPTV9SRUZTClRoaXMgd2lsbCBj cmVhdGUgYSBEUk0gZHVtYiBidWZmZXIgZnJvbSBncmFudCByZWZlcmVuY2VzIHByb3ZpZGVkCmJ5 IHRoZSBmcm9udGVuZC4gVGhlIGludGVuZGVkIHVzYWdlIGlzOgogwqAgLSBGcm9udGVuZAogwqDC oMKgIC0gY3JlYXRlcyBhIGR1bWIvZGlzcGxheSBidWZmZXIgYW5kIGFsbG9jYXRlcyBtZW1vcnkK IMKgwqDCoCAtIGdyYW50cyBmb3JlaWduIGFjY2VzcyB0byB0aGUgYnVmZmVyIHBhZ2VzCiDCoMKg wqAgLSBwYXNzZXMgZ3JhbnRlZCByZWZlcmVuY2VzIHRvIHRoZSBiYWNrZW5kCiDCoCAtIEJhY2tl bmQKIMKgwqDCoCAtIGlzc3VlcyBEUk1fWEVOX1pDT1BZX0RVTUJfRlJPTV9SRUZTIGlvY3RsIHRv IG1hcAogwqDCoMKgwqDCoCBncmFudGVkIHJlZmVyZW5jZXMgYW5kIGNyZWF0ZSBhIGR1bWIgYnVm ZmVyCiDCoMKgwqAgLSByZXF1ZXN0cyBoYW5kbGUgdG8gZmQgY29udmVyc2lvbiB2aWEgRFJNX0lP Q1RMX1BSSU1FX0hBTkRMRV9UT19GRAogwqDCoMKgIC0gcmVxdWVzdHMgcmVhbCBIVyBkcml2ZXIv Y29uc3VtZXIgdG8gaW1wb3J0IHRoZSBQUklNRSBidWZmZXIgd2l0aAogwqDCoMKgwqDCoCBEUk1f SU9DVExfUFJJTUVfRkRfVE9fSEFORExFCiDCoMKgwqAgLSB1c2VzIGhhbmRsZSByZXR1cm5lZCBi eSB0aGUgcmVhbCBIVyBkcml2ZXIKIMKgIC0gYXQgdGhlIGVuZDoKIMKgwqDCoCBvIGNsb3NlcyBy ZWFsIEhXIGRyaXZlcidzIGhhbmRsZSB3aXRoIERSTV9JT0NUTF9HRU1fQ0xPU0UKIMKgwqDCoCBv IGNsb3NlcyB6ZXJvLWNvcHkgZHJpdmVyJ3MgaGFuZGxlIHdpdGggRFJNX0lPQ1RMX0dFTV9DTE9T RQogwqDCoMKgIG8gY2xvc2VzIGZpbGUgZGVzY3JpcHRvciBvZiB0aGUgZXhwb3J0ZWQgYnVmZmVy CgoyLiBEUk1fSU9DVExfWEVOX1pDT1BZX0RVTUJfVE9fUkVGUwpUaGlzIHdpbGwgZ3JhbnQgcmVm ZXJlbmNlcyB0byBhIGR1bWIvZGlzcGxheSBidWZmZXIncyBtZW1vcnkgcHJvdmlkZWQgYnkgdGhl CmJhY2tlbmQuIFRoZSBpbnRlbmRlZCB1c2FnZSBpczoKIMKgIC0gRnJvbnRlbmQKIMKgwqDCoCAt IHJlcXVlc3RzIGJhY2tlbmQgdG8gYWxsb2NhdGUgZHVtYi9kaXNwbGF5IGJ1ZmZlciBhbmQgZ3Jh bnQgcmVmZXJlbmNlcwogwqDCoMKgwqDCoCB0byBpdHMgcGFnZXMKIMKgIC0gQmFja2VuZAogwqDC oMKgIC0gcmVxdWVzdHMgcmVhbCBIVyBkcml2ZXIgdG8gY3JlYXRlIGEgZHVtYiB3aXRoIApEUk1f SU9DVExfTU9ERV9DUkVBVEVfRFVNQgogwqDCoMKgIC0gcmVxdWVzdHMgaGFuZGxlIHRvIGZkIGNv bnZlcnNpb24gdmlhIERSTV9JT0NUTF9QUklNRV9IQU5ETEVfVE9fRkQKIMKgwqDCoCAtIHJlcXVl c3RzIHplcm8tY29weSBkcml2ZXIgdG8gaW1wb3J0IHRoZSBQUklNRSBidWZmZXIgd2l0aAogwqDC oMKgwqDCoCBEUk1fSU9DVExfUFJJTUVfRkRfVE9fSEFORExFCiDCoMKgwqAgLSBpc3N1ZXMgRFJN X1hFTl9aQ09QWV9EVU1CX1RPX1JFRlMgaW9jdGwgdG8KIMKgwqDCoMKgwqAgZ3JhbnQgcmVmZXJl bmNlcyB0byB0aGUgYnVmZmVyJ3MgbWVtb3J5LgogwqDCoMKgIC0gcGFzc2VzIGdyYW50IHJlZmVy ZW5jZXMgdG8gdGhlIGZyb250ZW5kCiDCoC0gYXQgdGhlIGVuZDoKIMKgwqDCoCAtIGNsb3NlcyB6 ZXJvLWNvcHkgZHJpdmVyJ3MgaGFuZGxlIHdpdGggRFJNX0lPQ1RMX0dFTV9DTE9TRQogwqDCoMKg IC0gY2xvc2VzIHJlYWwgSFcgZHJpdmVyJ3MgaGFuZGxlIHdpdGggRFJNX0lPQ1RMX0dFTV9DTE9T RQogwqDCoMKgIC0gY2xvc2VzIGZpbGUgZGVzY3JpcHRvciBvZiB0aGUgaW1wb3J0ZWQgYnVmZmVy CgozLiBEUk1fWEVOX1pDT1BZX0RVTUJfV0FJVF9GUkVFClRoaXMgd2lsbCBibG9jayB1bnRpbCB0 aGUgZHVtYiBidWZmZXIgd2l0aCB0aGUgd2FpdCBoYW5kbGUgcHJvdmlkZWQgYmUgCmZyZWVkOgp0 aGlzIGlzIG5lZWRlZCBmb3Igc3luY2hyb25pemF0aW9uIGJldHdlZW4gZnJvbnRlbmQgYW5kIGJh Y2tlbmQgaW4gY2FzZQpmcm9udGVuZCBwcm92aWRlcyBncmFudCByZWZlcmVuY2VzIG9mIHRoZSBi dWZmZXIgdmlhCkRSTV9YRU5fWkNPUFlfRFVNQl9GUk9NX1JFRlMgSU9DVEwgYW5kIHdoaWNoIG11 c3QgYmUgcmVsZWFzZWQgYmVmb3JlCmJhY2tlbmQgcmVwbGllcyB3aXRoIFhFTkRJU1BMX09QX0RC VUZfREVTVFJPWSByZXNwb25zZS4Kd2FpdF9oYW5kbGUgbXVzdCBiZSB0aGUgc2FtZSB2YWx1ZSBy ZXR1cm5lZCB3aGlsZSBjYWxsaW5nCkRSTV9YRU5fWkNPUFlfRFVNQl9GUk9NX1JFRlMgSU9DVEwu CgpTbywgYXMgeW91IGNhbiBzZWUgdGhlIGFib3ZlIGZ1bmN0aW9uYWxpdHkgaXMgbm90IGNvdmVy ZWQgYnkgdGhlIApleGlzdGluZyBVQVBJCm9mIHRoZSBnbnRkZXYgZHJpdmVyLgpOb3csIGlmIHdl IGNoYW5nZSBkdW1iIC0+IGRtYS1idWYgYW5kIHJlbW92ZSBEUk0gY29kZSAod2hpY2ggaXMgb25s eSBhIAp3cmFwcGVyCmhlcmUgb24gdG9wIG9mIGRtYS1idWYpIHdlIGdldCBuZXcgZHJpdmVyIGZv ciBkbWEtYnVmIGZvciBYZW4uCgpUaGlzIGlzIHdoeSBJIGhhdmUgMiBvcHRpb25zIGhlcmU6IGVp dGhlciBjcmVhdGUgYSBkZWRpY2F0ZWQgZHJpdmVyIGZvciB0aGlzCihlLmcuIHJlLXdvcmsgeGVu LXpjb3B5IHRvIGJlIERSTSBpbmRlcGVuZGVudCBhbmQgcHV0IGl0IHVuZGVyCmRyaXZlcnMveGVu L3hlbi1kbWEtYnVmLCBmb3IgZXhhbXBsZSkgb3IgZXh0ZW5kIHRoZSBleGlzdGluZyBnbnRkZXYg ZHJpdmVyCndpdGggdGhlIGFib3ZlIFVBUEkgKyBtYWtlIGNoYW5nZXMgdG8gdGhlIGJhbGxvb24g ZHJpdmVyIHRvIHByb3ZpZGUga2VybmVsCkFQSSBmb3IgRE1BIGJ1ZmZlciBhbGxvY2F0aW9ucy4K ClNvLCB0aGlzIGlzIHdoZXJlIEkgbmVlZCB0byB1bmRlcnN0YW5kIFhlbiBjb21tdW5pdHkncyBw cmVmZXJlbmNlLCBzbyB0aGUKaW1wbGVtZW50YXRpb24gaXMgbm90IHF1ZXN0aW9uZWQgbGF0ZXIg b24uCgo+IC1ib3JpcwpUaGFuayB5b3UsCk9sZWtzYW5kcgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZl bEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9kcmktZGV2ZWwK