From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F272AC433B4 for ; Thu, 15 Apr 2021 12:48:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CC96D613B1 for ; Thu, 15 Apr 2021 12:48:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232967AbhDOMsq (ORCPT ); Thu, 15 Apr 2021 08:48:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:34669 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232935AbhDOMso (ORCPT ); Thu, 15 Apr 2021 08:48:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618490900; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1LAQ6HtKDOO1L+xRyQZX4ppYDgriUkDm49dicoPjqa4=; b=aUwMSIGNQ0iMWN2UIfw3IrTC8PUeVdwewcaOXVX+sPfzoEWyhyNivtdYnh3ZFhC1BGv2tK 67w4qRsKw5A4oY8bnK94FeA4KET5OFGK94htHxPJM+iUkL1r0V+cVD5PL7Rm+stJ0NmAfT 1vZupSk6IhlZH7Wrad5nMMPzbEXk/Bo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-216-m3P9md99M4W8abc-qfD1LQ-1; Thu, 15 Apr 2021 08:48:19 -0400 X-MC-Unique: m3P9md99M4W8abc-qfD1LQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 30F4284BA41; Thu, 15 Apr 2021 12:48:18 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.193.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7BEEF10190A7; Thu, 15 Apr 2021 12:48:17 +0000 (UTC) Subject: Re: [PATCH v2 22/24] mpi3mr: add support of DSN secure fw check To: Kashyap Desai , linux-scsi@vger.kernel.org Cc: sathya.prakash@broadcom.com References: <20210407020451.924822-1-kashyap.desai@broadcom.com> <20210407020451.924822-23-kashyap.desai@broadcom.com> From: Tomas Henzl Message-ID: <30e25550-811c-cbbd-61da-c2243bbbf963@redhat.com> Date: Thu, 15 Apr 2021 14:48:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210407020451.924822-23-kashyap.desai@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On 4/7/21 4:04 AM, Kashyap Desai wrote: > Read PCI_EXT_CAP_ID_DSN to know security status. > > Driver will throw an warning message when a non-secure type controller > is detected. Purpose of this interface is to avoid interacting with > any firmware which is not secured/signed by Broadcom. > Any tampering on Firmware component will be detected by hardware > and it will be communicated to the driver to avoid any further > interaction with that component. > > Signed-off-by: Kashyap Desai > Reviewed-by: Hannes Reinecke > Cc: sathya.prakash@broadcom.com Looks good Reviewed-by: Tomas Henzl