All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amdgpu: drop flags check for CHIP_IP_DISCOVERY
@ 2022-01-14 15:02 Alex Deucher
  2022-01-14 15:06 ` Zhang, Hawking
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Alex Deucher @ 2022-01-14 15:02 UTC (permalink / raw)
  To: amd-gfx; +Cc: Alex Deucher

Support for IP based discovery is in place now so this
check is no longer required.

Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index 224d073022ac..25e3ed351fd6 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
@@ -1903,11 +1903,6 @@ static int amdgpu_pci_probe(struct pci_dev *pdev,
 			return -ENODEV;
 	}
 
-	if (flags == CHIP_IP_DISCOVERY) {
-		DRM_INFO("Unsupported asic.  Remove me when IP discovery init is in place.\n");
-		return -ENODEV;
-	}
-
 	if (amdgpu_virtual_display ||
 	    amdgpu_device_asic_has_dc_support(flags & AMD_ASIC_MASK))
 		supports_atomic = true;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* RE: [PATCH] drm/amdgpu: drop flags check for CHIP_IP_DISCOVERY
  2022-01-14 15:02 [PATCH] drm/amdgpu: drop flags check for CHIP_IP_DISCOVERY Alex Deucher
@ 2022-01-14 15:06 ` Zhang, Hawking
  2022-01-14 15:41 ` Christian König
  2022-01-15 14:16 ` Chen, Guchun
  2 siblings, 0 replies; 4+ messages in thread
From: Zhang, Hawking @ 2022-01-14 15:06 UTC (permalink / raw)
  To: Deucher, Alexander, amd-gfx; +Cc: Deucher, Alexander

[AMD Official Use Only]

Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>

Regards,
Hawking
-----Original Message-----
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Alex Deucher
Sent: Friday, January 14, 2022 23:03
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander <Alexander.Deucher@amd.com>
Subject: [PATCH] drm/amdgpu: drop flags check for CHIP_IP_DISCOVERY

Support for IP based discovery is in place now so this check is no longer required.

Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index 224d073022ac..25e3ed351fd6 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
@@ -1903,11 +1903,6 @@ static int amdgpu_pci_probe(struct pci_dev *pdev,
 			return -ENODEV;
 	}
 
-	if (flags == CHIP_IP_DISCOVERY) {
-		DRM_INFO("Unsupported asic.  Remove me when IP discovery init is in place.\n");
-		return -ENODEV;
-	}
-
 	if (amdgpu_virtual_display ||
 	    amdgpu_device_asic_has_dc_support(flags & AMD_ASIC_MASK))
 		supports_atomic = true;
--
2.34.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amdgpu: drop flags check for CHIP_IP_DISCOVERY
  2022-01-14 15:02 [PATCH] drm/amdgpu: drop flags check for CHIP_IP_DISCOVERY Alex Deucher
  2022-01-14 15:06 ` Zhang, Hawking
@ 2022-01-14 15:41 ` Christian König
  2022-01-15 14:16 ` Chen, Guchun
  2 siblings, 0 replies; 4+ messages in thread
From: Christian König @ 2022-01-14 15:41 UTC (permalink / raw)
  To: Alex Deucher, amd-gfx

Am 14.01.22 um 16:02 schrieb Alex Deucher:
> Support for IP based discovery is in place now so this
> check is no longer required.
>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

Acked-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 5 -----
>   1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index 224d073022ac..25e3ed351fd6 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -1903,11 +1903,6 @@ static int amdgpu_pci_probe(struct pci_dev *pdev,
>   			return -ENODEV;
>   	}
>   
> -	if (flags == CHIP_IP_DISCOVERY) {
> -		DRM_INFO("Unsupported asic.  Remove me when IP discovery init is in place.\n");
> -		return -ENODEV;
> -	}
> -
>   	if (amdgpu_virtual_display ||
>   	    amdgpu_device_asic_has_dc_support(flags & AMD_ASIC_MASK))
>   		supports_atomic = true;


^ permalink raw reply	[flat|nested] 4+ messages in thread
* RE: [PATCH] drm/amdgpu: drop flags check for CHIP_IP_DISCOVERY
  2022-01-14 15:02 [PATCH] drm/amdgpu: drop flags check for CHIP_IP_DISCOVERY Alex Deucher
  2022-01-14 15:06 ` Zhang, Hawking
  2022-01-14 15:41 ` Christian König
@ 2022-01-15 14:16 ` Chen, Guchun
  2 siblings, 0 replies; 4+ messages in thread
From: Chen, Guchun @ 2022-01-15 14:16 UTC (permalink / raw)
  To: Deucher, Alexander, amd-gfx; +Cc: Deucher, Alexander

Reviewed-by: Guchun Chen <guchun.chen@amd.com>


Regards,
Guchun

-----Original Message-----
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Alex Deucher
Sent: Friday, January 14, 2022 11:03 PM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander <Alexander.Deucher@amd.com>
Subject: [PATCH] drm/amdgpu: drop flags check for CHIP_IP_DISCOVERY

Support for IP based discovery is in place now so this check is no longer required.

Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index 224d073022ac..25e3ed351fd6 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
@@ -1903,11 +1903,6 @@ static int amdgpu_pci_probe(struct pci_dev *pdev,
 			return -ENODEV;
 	}
 
-	if (flags == CHIP_IP_DISCOVERY) {
-		DRM_INFO("Unsupported asic.  Remove me when IP discovery init is in place.\n");
-		return -ENODEV;
-	}
-
 	if (amdgpu_virtual_display ||
 	    amdgpu_device_asic_has_dc_support(flags & AMD_ASIC_MASK))
 		supports_atomic = true;
--
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-15 14:16 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-14 15:02 [PATCH] drm/amdgpu: drop flags check for CHIP_IP_DISCOVERY Alex Deucher
2022-01-14 15:06 ` Zhang, Hawking
2022-01-14 15:41 ` Christian König
2022-01-15 14:16 ` Chen, Guchun

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.