From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: "Joel Stanley" <joel@jms.id.au>, "Cédric Le Goater" <clg@kaod.org>
Cc: Andrew Jeffery <andrew@aj.id.au>,
Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH v4 2/3] aspeed: Integrate HACE
Date: Wed, 24 Mar 2021 10:47:49 +0100 [thread overview]
Message-ID: <30ea65c8-ce09-c582-fe98-64315bb54e62@amsat.org> (raw)
In-Reply-To: <20210324070955.125941-3-joel@jms.id.au>
On 3/24/21 8:09 AM, Joel Stanley wrote:
> Add the hash and crypto engine model to the Aspeed socs.
>
> Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> v3: Rebase on upstream
> v4: Update integration for soc-specific hace objects
> ---
> docs/system/arm/aspeed.rst | 2 +-
> include/hw/arm/aspeed_soc.h | 3 +++
> hw/arm/aspeed_ast2600.c | 15 +++++++++++++++
> hw/arm/aspeed_soc.c | 16 ++++++++++++++++
> 4 files changed, 35 insertions(+), 1 deletion(-)
LGTM.
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
next prev parent reply other threads:[~2021-03-24 9:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 7:09 [PATCH v4 0/3] hw/misc: Model ASPEED hash and crypto engine Joel Stanley
2021-03-24 7:09 ` [PATCH v4 1/3] hw: Model ASPEED's Hash and Crypto Engine Joel Stanley
2021-03-24 7:26 ` Cédric Le Goater
2021-03-24 9:46 ` Philippe Mathieu-Daudé
2021-03-24 7:09 ` [PATCH v4 2/3] aspeed: Integrate HACE Joel Stanley
2021-03-24 7:21 ` Cédric Le Goater
2021-03-24 9:47 ` Philippe Mathieu-Daudé [this message]
2021-03-24 7:09 ` [PATCH v4 3/3] tests/qtest: Add test for Aspeed HACE Joel Stanley
2021-03-24 7:21 ` Cédric Le Goater
2021-03-24 9:05 ` Thomas Huth
2021-03-24 7:30 ` [PATCH v4 0/3] hw/misc: Model ASPEED hash and crypto engine no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30ea65c8-ce09-c582-fe98-64315bb54e62@amsat.org \
--to=f4bug@amsat.org \
--cc=andrew@aj.id.au \
--cc=clg@kaod.org \
--cc=joel@jms.id.au \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.