From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3233C433F5 for ; Wed, 9 Mar 2022 07:37:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230120AbiCIHiz (ORCPT ); Wed, 9 Mar 2022 02:38:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230415AbiCIHiy (ORCPT ); Wed, 9 Mar 2022 02:38:54 -0500 Received: from mail-m121144.qiye.163.com (mail-m121144.qiye.163.com [115.236.121.144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44B603FBF7 for ; Tue, 8 Mar 2022 23:37:51 -0800 (PST) Received: from [172.16.12.141] (unknown [58.22.7.114]) by mail-m121144.qiye.163.com (Hmail) with ESMTPA id 41C10AC0283; Wed, 9 Mar 2022 15:37:49 +0800 (CST) Message-ID: <30f195d6-e9d7-3da6-89fa-4a064a1f6bf9@rock-chips.com> Date: Wed, 9 Mar 2022 15:37:48 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v7 22/24] drm: rockchip: Add VOP2 driver Content-Language: en-US From: Andy Yan To: Daniel Stone Cc: Sascha Hauer , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, Benjamin Gaignard , Sandy Huang , linux-rockchip@lists.infradead.org, Michael Riesch , kernel@pengutronix.de, Peter Geis , linux-arm-kernel@lists.infradead.org References: <20220225075150.2729401-1-s.hauer@pengutronix.de> <20220225075150.2729401-23-s.hauer@pengutronix.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUlKS0tKN1dZLVlBSVdZDwkaFQgSH1lBWRlDGhpWSk5JSEJOGh 1OSRoeVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWU9LSFVKSktITUpVS1kG X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6PjY6Qyo4Cz5IMzAYFSwLUU8N PQsKFBhVSlVKTU9NQ0pKT01CQktKVTMWGhIXVRoVHwJVAhoVOwkUGBBWGBMSCwhVGBQWRVlXWRIL WUFZTkNVSUlVTFVKSk9ZV1kIAVlBT0hMSTcG X-HM-Tid: 0a7f6d9cd74ab039kuuu41c10ac0283 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Daniel: On 3/9/22 10:03, Andy Yan wrote: > Hi Daniel: > > On 3/8/22 22:04, Daniel Stone wrote: >> On Tue, 8 Mar 2022 at 08:42, Andy Yan wrote: >>> On 3/7/22 21:09, Daniel Stone wrote: >>>> On Mon, 7 Mar 2022 at 12:18, Andy Yan wrote: >>>>> When run a weston 10.0.0: >>>>> >>>>>     # export XDG_RUNTIME_DIR=/tmp >>>>>     # weston --backend=drm-backend.so --use-pixma --tty=2 >>>>> --continue=without-input >>>>> >>>>> I got the following error: >>>>> >>>>> drm_atomic_check_only [PLANE:31:Smart0-win0] CRTC set but no FB >>>> Can you please start Weston with --logger-scopes=log,drm-backend and >>>> attach the output? >>> Please see the weston ouput here[0] >> Are you running with musl perhaps? > Do you mean the C library? I chose uClib-ng in buildroot, not use musl. >> Either way, please make sure your >> libdrm build includes commit 79fa377c8bdc84fde99c6a6ac17e554971c617be. > > > The upstream buildroot use libdrm2.4.109, this commit[0] if from > libdrm2.4.110 > > I cherry-pick this patch to my local libdrm, but has no effect, still > has "atomic: couldn't commit new state" error. > > I have do a search in libdrm and weston, but find no one call > drmModeAtomicMerge, is that right? > > [0]https://gitlab.freedesktop.org/mesa/drm/-/merge_requests/167 > With your patch applied from libdrm2.4.110, I do a make clean for buidlroot, than build it again,  That's take effect. I can see only the second value (non-zero FB) of plane 31 commit to the kernel. So this is works. Maybe the buidroot should update libdrm package. Thank you. >> >> Cheers, >> Daniel > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DEA68C433F5 for ; Wed, 9 Mar 2022 07:38:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:From:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Q+2/pC3yTI/jlr2Upgm06vpAvsneCIJvHly58nSG7NU=; b=jtqiowAyy4xd+F VCkAA+ny7oL4tWdpDmo+V7KYCSs9gdwsb76C33COH/G0pVPfYoaeLjeOOogtlXtlNgiF3zPtNpFju hKxN3iUAFfhbP2+8ZeQ/1mR5SnlS0ZsS38EWXher5wNu6ijZFl3wqd7nEwtAMnHK7tLugsg2jjkUq 9ZxppiKlnwag+SVYoZNt35GvqGIB/sykxze8n8yWPY3O85gohV1xC25XV351d0yZel0UDD8EmQJOL E6R9Lz50Ab4obxBtYCmzcuFntvlmMJ0KWygKy50kaIxdpiCkNEe0iOe1wcfD9/sLeQuQK7waZIQTN /OJnzt7jPACqxmPjuPOQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRqtZ-007cqz-Rh; Wed, 09 Mar 2022 07:38:05 +0000 Received: from mail-m121144.qiye.163.com ([115.236.121.144]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRqtM-007cor-Tg; Wed, 09 Mar 2022 07:37:54 +0000 Received: from [172.16.12.141] (unknown [58.22.7.114]) by mail-m121144.qiye.163.com (Hmail) with ESMTPA id 41C10AC0283; Wed, 9 Mar 2022 15:37:49 +0800 (CST) Message-ID: <30f195d6-e9d7-3da6-89fa-4a064a1f6bf9@rock-chips.com> Date: Wed, 9 Mar 2022 15:37:48 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v7 22/24] drm: rockchip: Add VOP2 driver Content-Language: en-US From: Andy Yan To: Daniel Stone Cc: Sascha Hauer , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, Benjamin Gaignard , Sandy Huang , linux-rockchip@lists.infradead.org, Michael Riesch , kernel@pengutronix.de, Peter Geis , linux-arm-kernel@lists.infradead.org References: <20220225075150.2729401-1-s.hauer@pengutronix.de> <20220225075150.2729401-23-s.hauer@pengutronix.de> In-Reply-To: X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUlKS0tKN1dZLVlBSVdZDwkaFQgSH1lBWRlDGhpWSk5JSEJOGh 1OSRoeVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWU9LSFVKSktITUpVS1kG X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6PjY6Qyo4Cz5IMzAYFSwLUU8N PQsKFBhVSlVKTU9NQ0pKT01CQktKVTMWGhIXVRoVHwJVAhoVOwkUGBBWGBMSCwhVGBQWRVlXWRIL WUFZTkNVSUlVTFVKSk9ZV1kIAVlBT0hMSTcG X-HM-Tid: 0a7f6d9cd74ab039kuuu41c10ac0283 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220308_233753_132723_574ED9DD X-CRM114-Status: GOOD ( 17.34 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGkgRGFuaWVsOgoKT24gMy85LzIyIDEwOjAzLCBBbmR5IFlhbiB3cm90ZToKPiBIaSBEYW5pZWw6 Cj4KPiBPbiAzLzgvMjIgMjI6MDQsIERhbmllbCBTdG9uZSB3cm90ZToKPj4gT24gVHVlLCA4IE1h ciAyMDIyIGF0IDA4OjQyLCBBbmR5IFlhbiA8YW5keS55YW5Acm9jay1jaGlwcy5jb20+IHdyb3Rl Ogo+Pj4gT24gMy83LzIyIDIxOjA5LCBEYW5pZWwgU3RvbmUgd3JvdGU6Cj4+Pj4gT24gTW9uLCA3 IE1hciAyMDIyIGF0IDEyOjE4LCBBbmR5IFlhbiA8YW5keS55YW5Acm9jay1jaGlwcy5jb20+IHdy b3RlOgo+Pj4+PiBXaGVuIHJ1biBhIHdlc3RvbiAxMC4wLjA6Cj4+Pj4+Cj4+Pj4+IMKgwqDCoCAj IGV4cG9ydCBYREdfUlVOVElNRV9ESVI9L3RtcAo+Pj4+PiDCoMKgwqAgIyB3ZXN0b24gLS1iYWNr ZW5kPWRybS1iYWNrZW5kLnNvIC0tdXNlLXBpeG1hIC0tdHR5PTIKPj4+Pj4gLS1jb250aW51ZT13 aXRob3V0LWlucHV0Cj4+Pj4+Cj4+Pj4+IEkgZ290IHRoZSBmb2xsb3dpbmcgZXJyb3I6Cj4+Pj4+ Cj4+Pj4+IGRybV9hdG9taWNfY2hlY2tfb25seSBbUExBTkU6MzE6U21hcnQwLXdpbjBdIENSVEMg c2V0IGJ1dCBubyBGQgo+Pj4+IENhbiB5b3UgcGxlYXNlIHN0YXJ0IFdlc3RvbiB3aXRoIC0tbG9n Z2VyLXNjb3Blcz1sb2csZHJtLWJhY2tlbmQgYW5kCj4+Pj4gYXR0YWNoIHRoZSBvdXRwdXQ/Cj4+ PiBQbGVhc2Ugc2VlIHRoZSB3ZXN0b24gb3VwdXQgaGVyZVswXQo+PiBBcmUgeW91IHJ1bm5pbmcg d2l0aCBtdXNsIHBlcmhhcHM/Cj4gRG8geW91IG1lYW4gdGhlIEMgbGlicmFyeT8gSSBjaG9zZSB1 Q2xpYi1uZyBpbiBidWlsZHJvb3QsIG5vdCB1c2UgbXVzbC4KPj4gRWl0aGVyIHdheSwgcGxlYXNl IG1ha2Ugc3VyZSB5b3VyCj4+IGxpYmRybSBidWlsZCBpbmNsdWRlcyBjb21taXQgNzlmYTM3N2M4 YmRjODRmZGU5OWM2YTZhYzE3ZTU1NDk3MWM2MTdiZS4KPgo+Cj4gVGhlIHVwc3RyZWFtIGJ1aWxk cm9vdCB1c2UgbGliZHJtMi40LjEwOSwgdGhpcyBjb21taXRbMF0gaWYgZnJvbSAKPiBsaWJkcm0y LjQuMTEwCj4KPiBJIGNoZXJyeS1waWNrIHRoaXMgcGF0Y2ggdG8gbXkgbG9jYWwgbGliZHJtLCBi dXQgaGFzIG5vIGVmZmVjdCwgc3RpbGwgCj4gaGFzICJhdG9taWM6IGNvdWxkbid0IGNvbW1pdCBu ZXcgc3RhdGUiIGVycm9yLgo+Cj4gSSBoYXZlIGRvIGEgc2VhcmNoIGluIGxpYmRybSBhbmQgd2Vz dG9uLCBidXQgZmluZCBubyBvbmUgY2FsbCAKPiBkcm1Nb2RlQXRvbWljTWVyZ2UsIGlzIHRoYXQg cmlnaHQ/Cj4KPiBbMF1odHRwczovL2dpdGxhYi5mcmVlZGVza3RvcC5vcmcvbWVzYS9kcm0vLS9t ZXJnZV9yZXF1ZXN0cy8xNjcKPgoKV2l0aCB5b3VyIHBhdGNoIGFwcGxpZWQgZnJvbSBsaWJkcm0y LjQuMTEwLCBJIGRvIGEgbWFrZSBjbGVhbiBmb3IgCmJ1aWRscm9vdCwgdGhhbiBidWlsZCBpdCBh Z2FpbizCoCBUaGF0J3MgdGFrZSBlZmZlY3QuCgpJIGNhbiBzZWUgb25seSB0aGUgc2Vjb25kIHZh bHVlIChub24temVybyBGQikgb2YgcGxhbmUgMzEgY29tbWl0IHRvIHRoZSAKa2VybmVsLiBTbyB0 aGlzIGlzIHdvcmtzLgoKTWF5YmUgdGhlIGJ1aWRyb290IHNob3VsZCB1cGRhdGUgbGliZHJtIHBh Y2thZ2UuCgpUaGFuayB5b3UuCgo+Pgo+PiBDaGVlcnMsCj4+IERhbmllbAo+Cj4gX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBMaW51eC1yb2NrY2hpcCBt YWlsaW5nIGxpc3QKPiBMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCj4gaHR0cDov L2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yb2NrY2hpcAoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtcm9ja2No aXAgbWFpbGluZyBsaXN0CkxpbnV4LXJvY2tjaGlwQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDov L2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yb2NrY2hpcAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BAED4C433F5 for ; Wed, 9 Mar 2022 07:37:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E8EB910E3AA; Wed, 9 Mar 2022 07:37:52 +0000 (UTC) Received: from mail-m121144.qiye.163.com (mail-m121144.qiye.163.com [115.236.121.144]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9F80610E3AA for ; Wed, 9 Mar 2022 07:37:51 +0000 (UTC) Received: from [172.16.12.141] (unknown [58.22.7.114]) by mail-m121144.qiye.163.com (Hmail) with ESMTPA id 41C10AC0283; Wed, 9 Mar 2022 15:37:49 +0800 (CST) Message-ID: <30f195d6-e9d7-3da6-89fa-4a064a1f6bf9@rock-chips.com> Date: Wed, 9 Mar 2022 15:37:48 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v7 22/24] drm: rockchip: Add VOP2 driver Content-Language: en-US From: Andy Yan To: Daniel Stone References: <20220225075150.2729401-1-s.hauer@pengutronix.de> <20220225075150.2729401-23-s.hauer@pengutronix.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUlKS0tKN1dZLVlBSVdZDwkaFQgSH1lBWRlDGhpWSk5JSEJOGh 1OSRoeVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWU9LSFVKSktITUpVS1kG X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6PjY6Qyo4Cz5IMzAYFSwLUU8N PQsKFBhVSlVKTU9NQ0pKT01CQktKVTMWGhIXVRoVHwJVAhoVOwkUGBBWGBMSCwhVGBQWRVlXWRIL WUFZTkNVSUlVTFVKSk9ZV1kIAVlBT0hMSTcG X-HM-Tid: 0a7f6d9cd74ab039kuuu41c10ac0283 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Benjamin Gaignard , Peter Geis , Sascha Hauer , Sandy Huang , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Michael Riesch , kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Daniel: On 3/9/22 10:03, Andy Yan wrote: > Hi Daniel: > > On 3/8/22 22:04, Daniel Stone wrote: >> On Tue, 8 Mar 2022 at 08:42, Andy Yan wrote: >>> On 3/7/22 21:09, Daniel Stone wrote: >>>> On Mon, 7 Mar 2022 at 12:18, Andy Yan wrote: >>>>> When run a weston 10.0.0: >>>>> >>>>>     # export XDG_RUNTIME_DIR=/tmp >>>>>     # weston --backend=drm-backend.so --use-pixma --tty=2 >>>>> --continue=without-input >>>>> >>>>> I got the following error: >>>>> >>>>> drm_atomic_check_only [PLANE:31:Smart0-win0] CRTC set but no FB >>>> Can you please start Weston with --logger-scopes=log,drm-backend and >>>> attach the output? >>> Please see the weston ouput here[0] >> Are you running with musl perhaps? > Do you mean the C library? I chose uClib-ng in buildroot, not use musl. >> Either way, please make sure your >> libdrm build includes commit 79fa377c8bdc84fde99c6a6ac17e554971c617be. > > > The upstream buildroot use libdrm2.4.109, this commit[0] if from > libdrm2.4.110 > > I cherry-pick this patch to my local libdrm, but has no effect, still > has "atomic: couldn't commit new state" error. > > I have do a search in libdrm and weston, but find no one call > drmModeAtomicMerge, is that right? > > [0]https://gitlab.freedesktop.org/mesa/drm/-/merge_requests/167 > With your patch applied from libdrm2.4.110, I do a make clean for buidlroot, than build it again,  That's take effect. I can see only the second value (non-zero FB) of plane 31 commit to the kernel. So this is works. Maybe the buidroot should update libdrm package. Thank you. >> >> Cheers, >> Daniel > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18DCEC433EF for ; Wed, 9 Mar 2022 07:39:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:From:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=duUXCxhJiTTXOOJsB0cBEWoYfrYKItiu4D7c5KpImzc=; b=XLzVISQ41ZDzZD 0Z5QzblNFvT5LQNAFiSVWfrdTZr6ERuMZVZ72V0QUXixxpH/CNdeX3uyi4aFOn7NAagbSuZDzEzij hbpjc2LYeu6PSc7hg+58Q8SvtjY8VdiRSDxsaChN/dz0XYzKXnQgUhX3/c8/FSaSLcK4z0PEysr1L brafi0dkDap1V9Z7UmpC76YbIUauELqi4vrDMP4Q+o7Fo6p5HOed6S7KSXOKS4rS4wRhjBTP6CCDE XmAt9c6F0mtbbgaucusti2mYPx7bKGnm6nFKNR28desmzJMUd2bBn4KbF09nyZ4HuY452JVoMDgzb fw7T1LU8wohIjEs8XsKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRqtR-007cps-Jj; Wed, 09 Mar 2022 07:37:57 +0000 Received: from mail-m121144.qiye.163.com ([115.236.121.144]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRqtM-007cor-Tg; Wed, 09 Mar 2022 07:37:54 +0000 Received: from [172.16.12.141] (unknown [58.22.7.114]) by mail-m121144.qiye.163.com (Hmail) with ESMTPA id 41C10AC0283; Wed, 9 Mar 2022 15:37:49 +0800 (CST) Message-ID: <30f195d6-e9d7-3da6-89fa-4a064a1f6bf9@rock-chips.com> Date: Wed, 9 Mar 2022 15:37:48 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v7 22/24] drm: rockchip: Add VOP2 driver Content-Language: en-US From: Andy Yan To: Daniel Stone Cc: Sascha Hauer , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, Benjamin Gaignard , Sandy Huang , linux-rockchip@lists.infradead.org, Michael Riesch , kernel@pengutronix.de, Peter Geis , linux-arm-kernel@lists.infradead.org References: <20220225075150.2729401-1-s.hauer@pengutronix.de> <20220225075150.2729401-23-s.hauer@pengutronix.de> In-Reply-To: X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUlKS0tKN1dZLVlBSVdZDwkaFQgSH1lBWRlDGhpWSk5JSEJOGh 1OSRoeVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWU9LSFVKSktITUpVS1kG X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6PjY6Qyo4Cz5IMzAYFSwLUU8N PQsKFBhVSlVKTU9NQ0pKT01CQktKVTMWGhIXVRoVHwJVAhoVOwkUGBBWGBMSCwhVGBQWRVlXWRIL WUFZTkNVSUlVTFVKSk9ZV1kIAVlBT0hMSTcG X-HM-Tid: 0a7f6d9cd74ab039kuuu41c10ac0283 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220308_233753_132723_574ED9DD X-CRM114-Status: GOOD ( 17.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgRGFuaWVsOgoKT24gMy85LzIyIDEwOjAzLCBBbmR5IFlhbiB3cm90ZToKPiBIaSBEYW5pZWw6 Cj4KPiBPbiAzLzgvMjIgMjI6MDQsIERhbmllbCBTdG9uZSB3cm90ZToKPj4gT24gVHVlLCA4IE1h ciAyMDIyIGF0IDA4OjQyLCBBbmR5IFlhbiA8YW5keS55YW5Acm9jay1jaGlwcy5jb20+IHdyb3Rl Ogo+Pj4gT24gMy83LzIyIDIxOjA5LCBEYW5pZWwgU3RvbmUgd3JvdGU6Cj4+Pj4gT24gTW9uLCA3 IE1hciAyMDIyIGF0IDEyOjE4LCBBbmR5IFlhbiA8YW5keS55YW5Acm9jay1jaGlwcy5jb20+IHdy b3RlOgo+Pj4+PiBXaGVuIHJ1biBhIHdlc3RvbiAxMC4wLjA6Cj4+Pj4+Cj4+Pj4+IMKgwqDCoCAj IGV4cG9ydCBYREdfUlVOVElNRV9ESVI9L3RtcAo+Pj4+PiDCoMKgwqAgIyB3ZXN0b24gLS1iYWNr ZW5kPWRybS1iYWNrZW5kLnNvIC0tdXNlLXBpeG1hIC0tdHR5PTIKPj4+Pj4gLS1jb250aW51ZT13 aXRob3V0LWlucHV0Cj4+Pj4+Cj4+Pj4+IEkgZ290IHRoZSBmb2xsb3dpbmcgZXJyb3I6Cj4+Pj4+ Cj4+Pj4+IGRybV9hdG9taWNfY2hlY2tfb25seSBbUExBTkU6MzE6U21hcnQwLXdpbjBdIENSVEMg c2V0IGJ1dCBubyBGQgo+Pj4+IENhbiB5b3UgcGxlYXNlIHN0YXJ0IFdlc3RvbiB3aXRoIC0tbG9n Z2VyLXNjb3Blcz1sb2csZHJtLWJhY2tlbmQgYW5kCj4+Pj4gYXR0YWNoIHRoZSBvdXRwdXQ/Cj4+ PiBQbGVhc2Ugc2VlIHRoZSB3ZXN0b24gb3VwdXQgaGVyZVswXQo+PiBBcmUgeW91IHJ1bm5pbmcg d2l0aCBtdXNsIHBlcmhhcHM/Cj4gRG8geW91IG1lYW4gdGhlIEMgbGlicmFyeT8gSSBjaG9zZSB1 Q2xpYi1uZyBpbiBidWlsZHJvb3QsIG5vdCB1c2UgbXVzbC4KPj4gRWl0aGVyIHdheSwgcGxlYXNl IG1ha2Ugc3VyZSB5b3VyCj4+IGxpYmRybSBidWlsZCBpbmNsdWRlcyBjb21taXQgNzlmYTM3N2M4 YmRjODRmZGU5OWM2YTZhYzE3ZTU1NDk3MWM2MTdiZS4KPgo+Cj4gVGhlIHVwc3RyZWFtIGJ1aWxk cm9vdCB1c2UgbGliZHJtMi40LjEwOSwgdGhpcyBjb21taXRbMF0gaWYgZnJvbSAKPiBsaWJkcm0y LjQuMTEwCj4KPiBJIGNoZXJyeS1waWNrIHRoaXMgcGF0Y2ggdG8gbXkgbG9jYWwgbGliZHJtLCBi dXQgaGFzIG5vIGVmZmVjdCwgc3RpbGwgCj4gaGFzICJhdG9taWM6IGNvdWxkbid0IGNvbW1pdCBu ZXcgc3RhdGUiIGVycm9yLgo+Cj4gSSBoYXZlIGRvIGEgc2VhcmNoIGluIGxpYmRybSBhbmQgd2Vz dG9uLCBidXQgZmluZCBubyBvbmUgY2FsbCAKPiBkcm1Nb2RlQXRvbWljTWVyZ2UsIGlzIHRoYXQg cmlnaHQ/Cj4KPiBbMF1odHRwczovL2dpdGxhYi5mcmVlZGVza3RvcC5vcmcvbWVzYS9kcm0vLS9t ZXJnZV9yZXF1ZXN0cy8xNjcKPgoKV2l0aCB5b3VyIHBhdGNoIGFwcGxpZWQgZnJvbSBsaWJkcm0y LjQuMTEwLCBJIGRvIGEgbWFrZSBjbGVhbiBmb3IgCmJ1aWRscm9vdCwgdGhhbiBidWlsZCBpdCBh Z2FpbizCoCBUaGF0J3MgdGFrZSBlZmZlY3QuCgpJIGNhbiBzZWUgb25seSB0aGUgc2Vjb25kIHZh bHVlIChub24temVybyBGQikgb2YgcGxhbmUgMzEgY29tbWl0IHRvIHRoZSAKa2VybmVsLiBTbyB0 aGlzIGlzIHdvcmtzLgoKTWF5YmUgdGhlIGJ1aWRyb290IHNob3VsZCB1cGRhdGUgbGliZHJtIHBh Y2thZ2UuCgpUaGFuayB5b3UuCgo+Pgo+PiBDaGVlcnMsCj4+IERhbmllbAo+Cj4gX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBMaW51eC1yb2NrY2hpcCBt YWlsaW5nIGxpc3QKPiBMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCj4gaHR0cDov L2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yb2NrY2hpcAoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtl cm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5l bAo=