From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v3 0/4] Hyper-V Netvsc PMD Date: Wed, 18 Apr 2018 14:25:45 +0100 Message-ID: <30f5aec8-3653-28cc-270e-493d7cc53eee@intel.com> References: <20180417215324.8576-1-sthemmin@microsoft.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: Stephen Hemminger To: Stephen Hemminger , dev@dpdk.org Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 9C2167ED0 for ; Wed, 18 Apr 2018 15:25:48 +0200 (CEST) In-Reply-To: <20180417215324.8576-1-sthemmin@microsoft.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/17/2018 10:53 PM, Stephen Hemminger wrote: > This is a revised version of the Hyper-V native bus (VMBus) > and network device (netvsc) drivers. This virtual device > is used in Microsoft Hyper-V in Windows 10, Windows Server 2016 > and Azure. Most of this code was extracted from FreeBSD and some of > this is from earlier code donated by Brocade. > > Only Linux is supported at present, but the code is split > to allow future FreeBSD and Windows support. > > This version works with upstream kernel (4.16) but in that > mode only a single queue is supported. With additional > patches that are pending for 5.0 kernel, multi-queue > support works as well. > > Device binding is best done via driverctl; this required some > additional fixes to kernel and driverctl to work correctly. > Linux kernel vmbus support needed to support sysfs driver_override > and driverctl needed to handle non-PCI bus from udev. > https://gitlab.com/driverctl/driverctl/merge_requests/3 > http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-April/118889.html > > v3 > - fix documentation to format correctly and include more info > about binding > - fix build on 32 bit > - minor white space and indentation fixes > > Stephen Hemminger (4): > bus/vmbus: add hyper-v virtual bus support > net/netvsc: add hyper-v netvsc network device > net/netvsc: add documentation > bus/vmbus and net/netvsc: add meson build support Overall this is a bus driver implementation and a net driver implementation, it is not API that effect other part of the DPDK or end user. As long as it is not breaking anything and documented I am for getting the patch as experimental for this release. There are few minor comments on patches.