From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5750C433F5 for ; Wed, 10 Nov 2021 12:27:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 827846102A for ; Wed, 10 Nov 2021 12:27:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231460AbhKJMaj (ORCPT ); Wed, 10 Nov 2021 07:30:39 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:34915 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229653AbhKJMai (ORCPT ); Wed, 10 Nov 2021 07:30:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636547270; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dYLRQH0TP4O3xvYZerqmbmFmpTBL4DQnhLEPVVOshr8=; b=EBCJu5UKB2pL/rSLZltY/V/UZz25FGGuuF0XPnWUCOLG34uV6/IaZGHopirAC3ZbbsQaoJ /j0Br+ESGVMAP2n58UzW6j3NhKgBjsAhrrmSs4sMUP4BL6rniDVkCIthuKiSbrm2fSPCHE GMP4p0sILCMMFApkCddgoyL6mn2E694= Received: from mail-oi1-f199.google.com (mail-oi1-f199.google.com [209.85.167.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-201-iK2fQjZzMF-WRq_jkZtL_g-1; Wed, 10 Nov 2021 07:27:49 -0500 X-MC-Unique: iK2fQjZzMF-WRq_jkZtL_g-1 Received: by mail-oi1-f199.google.com with SMTP id r10-20020aca440a000000b002a81c7a19ccso1492012oia.7 for ; Wed, 10 Nov 2021 04:27:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=dYLRQH0TP4O3xvYZerqmbmFmpTBL4DQnhLEPVVOshr8=; b=zeoLPi1s+sjD9wtoB0rb+HhPR6Ptzfs0gEo6OGfi0Y4tQEjfJMDFc7YCBh7L0cGaF8 eLP+yBLXDEWbZR5YNd58j20t9feU1qBkXxz4vKtYVfMpzK4AsvwvSogA9aVjnbZ3CFvz goFPzB1fADCWLJdJImPcOrLLe1KaWEFEbVozFQZ/ukSKv2h2Jgp3KTeDI5xzYXSPdkh7 W+D8qRXZ5f/18gdfJ4ZtaN+GtLxVi0nrFO6pwR45SyGTdg6QTkqmj6yy39rL21/6Tn/K cr0PGgTy+w/3Sb02/UFqdxw3NAnIljhjqJrPAgq7hIlddG29oyORN9Yfsc7eLDCecEWr oVZA== X-Gm-Message-State: AOAM532CKMgpc2L59ASjLUr9G2zSYrAdCeFhk/oznuGrWAw3XDgMrdYr 4wQ6aT2cwmoMMhn+fOjyGJbP0o2W1wtUfWmuFYF6j59sxlnJsraXy7n01hqDH4fWi/Rmw24vME+ CmYy0JmFY1nkDkFVgmGonAdeU X-Received: by 2002:a05:6830:25c6:: with SMTP id d6mr12545951otu.240.1636547268278; Wed, 10 Nov 2021 04:27:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJxnXhWz6Tm1aQTYJ1ZH0K0WyVfJMRvn68Fsd1Y8zL14GrIvur82vWO2ukeKeUAu5n+umO8QFA== X-Received: by 2002:a05:6830:25c6:: with SMTP id d6mr12545936otu.240.1636547268109; Wed, 10 Nov 2021 04:27:48 -0800 (PST) Received: from localhost.localdomain (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id l7sm7389756oog.22.2021.11.10.04.27.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Nov 2021 04:27:47 -0800 (PST) Subject: Re: [PATCH v1 1/1] fpga: dfl: pci: Use pci_find_vsec_capability() when looking for DFL To: Andy Shevchenko Cc: Moritz Fischer , Matthew Gerlach , linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, Wu Hao , Xu Yilun References: <20211109154127.18455-1-andriy.shevchenko@linux.intel.com> <8ccc133a-fb47-4548-fee3-d57775a5166d@redhat.com> <39ac1f40-66ab-6c7e-0042-8fcdc062ed00@redhat.com> From: Tom Rix Message-ID: <3106bd57-9144-6a4d-8ad9-3ebf804018ab@redhat.com> Date: Wed, 10 Nov 2021 04:27:45 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/10/21 12:24 AM, Andy Shevchenko wrote: > On Tue, Nov 09, 2021 at 10:27:58AM -0800, Tom Rix wrote: >> On 11/9/21 10:05 AM, Andy Shevchenko wrote: >>> On Tue, Nov 09, 2021 at 07:55:43AM -0800, Tom Rix wrote: >>>> On 11/9/21 7:41 AM, Andy Shevchenko wrote: > ... > >>>>> + voff = pci_find_vsec_capability(dev, PCI_VENDOR_ID_INTEL, PCI_VSEC_ID_INTEL_DFLS); >>>> This may be a weakness in the origin code, but intel isn't the exclusive >>>> user of DFL. >>> This does not change the original code. If you think so, this can be extended >>> later on. >> I would rather see this fixed now or explained why this isn't a problem. > This is out of scope of this change in a few ways: > - we don't do 2+ things in one patch > - the change doesn't change behaviour > - the change is a simple cleanup > - another vendor may well have quite different VSEC ID for DFL > > If you think that it should be needed, one can come up with it later on. Fixing a problem is more useful than a cleanup. The fix should come first. Tom >