From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B27BC6786C for ; Fri, 12 Oct 2018 13:26:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0D59720865 for ; Fri, 12 Oct 2018 13:26:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D59720865 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728741AbeJLU6n (ORCPT ); Fri, 12 Oct 2018 16:58:43 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:41815 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728053AbeJLU6n (ORCPT ); Fri, 12 Oct 2018 16:58:43 -0400 Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id BAC35A5DA32A0; Fri, 12 Oct 2018 21:26:05 +0800 (CST) Received: from [127.0.0.1] (10.202.226.41) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.399.0; Fri, 12 Oct 2018 21:25:57 +0800 Subject: Re: [PATCH] perf tools: Store ids for events with their own cpus perf_event__synthesize_event_update_cpus To: Jiri Olsa , Arnaldo Carvalho de Melo References: <712b7c31-f681-7737-71e7-c028b8d2bba5@huawei.com> <20180927160210.GF6916@krava> <4ac88076-60fa-4509-7fa0-2f99d73174d2@huawei.com> <20181002111621.GA6357@krava> <20181003113643.GA31725@krava> <594506a2-8cb3-3d09-82ab-5cb6d8c31ed0@huawei.com> <20181003141627.GA6341@krava> <20181003212052.GA32371@krava> <20181009100049.GF6499@krava> CC: Mark Rutland , Andi Kleen , Peter Zijlstra , Will Deacon , Linuxarm , "linux-kernel@vger.kernel.org" , Alexander Shishkin , Ingo Molnar , Namhyung Kim , "linux-arm-kernel@lists.infradead.org" From: John Garry Message-ID: <31101407-0bcd-2fbf-361e-43cbcb81cd19@huawei.com> Date: Fri, 12 Oct 2018 14:25:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20181009100049.GF6499@krava> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.226.41] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/10/2018 11:00, Jiri Olsa wrote: > On Thu, Oct 04, 2018 at 10:20:39AM +0100, John Garry wrote: > > SNIP > >>> We synthesize an update event that needs to touch the evsel >>> id array, which is not defined at that time. Fixing this by >>> forcing the id allocation for events with theeir own cpus. /s/theeir/their/ >>> >>> Reported-by: John Garry >>> Link: http://lkml.kernel.org/n/tip-8x4n7o34yheigoxm1jibflm6@git.kernel.org >> >> Tested-by: John Garry >> >> In terms of adding to stable, LT v4.14 is not affected, but 4.18.x is. >> >> Thanks, >> John > > Arnaldo, could you please pick up this one > Just a friendly reminder on this patch. How about re-send with an updated commit message also? Thanks, John > thanks, > jirka > >> >>> Signed-off-by: Jiri Olsa >>> --- >>> tools/perf/builtin-report.c | 1 + >>> tools/perf/util/evsel.c | 3 +++ >>> 2 files changed, 4 insertions(+) >>> >>> diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c >>> index c0703979c51d..257c9c18cb7e 100644 >>> --- a/tools/perf/builtin-report.c >>> +++ b/tools/perf/builtin-report.c >>> @@ -980,6 +980,7 @@ int cmd_report(int argc, const char **argv) >>> .id_index = perf_event__process_id_index, >>> .auxtrace_info = perf_event__process_auxtrace_info, >>> .auxtrace = perf_event__process_auxtrace, >>> + .event_update = perf_event__process_event_update, >>> .feature = process_feature_event, >>> .ordered_events = true, >>> .ordering_requires_timestamps = true, >>> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c >>> index ac6cfb8b085e..7a0d5fbaf3c1 100644 >>> --- a/tools/perf/util/evsel.c >>> +++ b/tools/perf/util/evsel.c >>> @@ -1088,6 +1088,9 @@ void perf_evsel__config(struct perf_evsel *evsel, struct record_opts *opts, >>> attr->exclude_user = 1; >>> } >>> >>> + if (evsel->own_cpus) >>> + evsel->attr.read_format |= PERF_FORMAT_ID; >>> + >>> /* >>> * Apply event specific term settings, >>> * it overloads any global configuration. >>> >> >> > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > > . > From mboxrd@z Thu Jan 1 00:00:00 1970 From: john.garry@huawei.com (John Garry) Date: Fri, 12 Oct 2018 14:25:49 +0100 Subject: [PATCH] perf tools: Store ids for events with their own cpus perf_event__synthesize_event_update_cpus In-Reply-To: <20181009100049.GF6499@krava> References: <712b7c31-f681-7737-71e7-c028b8d2bba5@huawei.com> <20180927160210.GF6916@krava> <4ac88076-60fa-4509-7fa0-2f99d73174d2@huawei.com> <20181002111621.GA6357@krava> <20181003113643.GA31725@krava> <594506a2-8cb3-3d09-82ab-5cb6d8c31ed0@huawei.com> <20181003141627.GA6341@krava> <20181003212052.GA32371@krava> <20181009100049.GF6499@krava> Message-ID: <31101407-0bcd-2fbf-361e-43cbcb81cd19@huawei.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 09/10/2018 11:00, Jiri Olsa wrote: > On Thu, Oct 04, 2018 at 10:20:39AM +0100, John Garry wrote: > > SNIP > >>> We synthesize an update event that needs to touch the evsel >>> id array, which is not defined at that time. Fixing this by >>> forcing the id allocation for events with theeir own cpus. /s/theeir/their/ >>> >>> Reported-by: John Garry >>> Link: http://lkml.kernel.org/n/tip-8x4n7o34yheigoxm1jibflm6 at git.kernel.org >> >> Tested-by: John Garry >> >> In terms of adding to stable, LT v4.14 is not affected, but 4.18.x is. >> >> Thanks, >> John > > Arnaldo, could you please pick up this one > Just a friendly reminder on this patch. How about re-send with an updated commit message also? Thanks, John > thanks, > jirka > >> >>> Signed-off-by: Jiri Olsa >>> --- >>> tools/perf/builtin-report.c | 1 + >>> tools/perf/util/evsel.c | 3 +++ >>> 2 files changed, 4 insertions(+) >>> >>> diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c >>> index c0703979c51d..257c9c18cb7e 100644 >>> --- a/tools/perf/builtin-report.c >>> +++ b/tools/perf/builtin-report.c >>> @@ -980,6 +980,7 @@ int cmd_report(int argc, const char **argv) >>> .id_index = perf_event__process_id_index, >>> .auxtrace_info = perf_event__process_auxtrace_info, >>> .auxtrace = perf_event__process_auxtrace, >>> + .event_update = perf_event__process_event_update, >>> .feature = process_feature_event, >>> .ordered_events = true, >>> .ordering_requires_timestamps = true, >>> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c >>> index ac6cfb8b085e..7a0d5fbaf3c1 100644 >>> --- a/tools/perf/util/evsel.c >>> +++ b/tools/perf/util/evsel.c >>> @@ -1088,6 +1088,9 @@ void perf_evsel__config(struct perf_evsel *evsel, struct record_opts *opts, >>> attr->exclude_user = 1; >>> } >>> >>> + if (evsel->own_cpus) >>> + evsel->attr.read_format |= PERF_FORMAT_ID; >>> + >>> /* >>> * Apply event specific term settings, >>> * it overloads any global configuration. >>> >> >> > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > > . >