From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9D59C4320E for ; Fri, 27 Aug 2021 20:17:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 95EAA60FE7 for ; Fri, 27 Aug 2021 20:17:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231496AbhH0USH (ORCPT ); Fri, 27 Aug 2021 16:18:07 -0400 Received: from mxout01.lancloud.ru ([45.84.86.81]:58790 "EHLO mxout01.lancloud.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229591AbhH0USH (ORCPT ); Fri, 27 Aug 2021 16:18:07 -0400 Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout01.lancloud.ru D7CD320D394B Received: from LanCloud Received: from LanCloud Received: from LanCloud Subject: Re: [PATCH net-next 13/13] ravb: Add reset support To: Biju Das , "David S. Miller" , Jakub Kicinski CC: Lad Prabhakar , Andrew Lunn , Sergei Shtylyov , "Geert Uytterhoeven" , Adam Ford , Yoshihiro Shimoda , , , Chris Paterson , Biju Das References: <20210825070154.14336-1-biju.das.jz@bp.renesas.com> <20210825070154.14336-14-biju.das.jz@bp.renesas.com> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: <3114f468-f454-4289-bc1f-befdadac9994@omp.ru> Date: Fri, 27 Aug 2021 23:17:07 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210825070154.14336-14-biju.das.jz@bp.renesas.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT02.lancloud.ru (fd00:f066::142) To LFEX1907.lancloud.ru (fd00:f066::207) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 8/25/21 10:01 AM, Biju Das wrote: > Reset support is present on R-Car. Let's support it, if it is > available. > > Signed-off-by: Biju Das > Reviewed-by: Lad Prabhakar [...] > diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c > index 7a144b45e41d..0f85f2d97b18 100644 > --- a/drivers/net/ethernet/renesas/ravb_main.c > +++ b/drivers/net/ethernet/renesas/ravb_main.c [...] > @@ -2349,6 +2358,7 @@ static int ravb_probe(struct platform_device *pdev) > > pm_runtime_put(&pdev->dev); > pm_runtime_disable(&pdev->dev); > + reset_control_assert(rstc); > return error; > } > > @@ -2374,6 +2384,7 @@ static int ravb_remove(struct platform_device *pdev) > netif_napi_del(&priv->napi[RAVB_BE]); > ravb_mdio_release(priv); > pm_runtime_disable(&pdev->dev); > + reset_control_assert(priv->rstc); > free_netdev(ndev); > platform_set_drvdata(pdev, NULL); > Is it possible to get into/out of reset in open()/close() methods? Otherwise, looks good (I'm not much into reset h/w) Reviewed-by: Sergey Shtylyov MBR, Sergey