From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Agner Date: Tue, 05 Jul 2016 16:14:10 -0700 Subject: [U-Boot] [PATCH 4/9] mx7: set soc environment according to exact SoC type In-Reply-To: References: <20160703193354.25900-1-stefan@agner.ch> <20160703193354.25900-5-stefan@agner.ch> <7c4acd79f34bca4ab7ea125cabc51b01@agner.ch> Message-ID: <3125c2721a91596142ca10a84d9e1e58@agner.ch> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 2016-07-05 13:56, Fabio Estevam wrote: > On Tue, Jul 5, 2016 at 5:47 PM, Stefan Agner wrote: > >> Sounds sensible. Would be the first use of >> CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG in arch/arm/, but I guess that is >> fine. > > To keep the consistency you could add > CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG in your board file, just like the > other boards. Yeah sure, to define it I would put into our board config. But what I ment here is it would be the first use of CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG in _code_ under arch/arm. All other uses of CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG are in board specific code under boards/... > >> Note that CONFIG_SYS_SOC, which defines the environment variable "soc", >> is currently defined "mx7" by default... >> >> What do you think, do we want >> CONFIG_ARCH_MISC_INIT/CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG set for i.MX >> 7 Sabre/Warp7? Put it in Common directly? Afaik those boards only exist >> in a single variant, hence they always will load the same device tree >> and therefore it wouldn't be really required to determine the SoC at >> runtime. > > Correct: we don't need to use CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG for > mx7sabresd/warp as they only use a single variant of the MX7 chip. Ok, use it only in our config then. -- Stefan