From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f196.google.com ([209.85.192.196]:42428 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751968AbeB0QhZ (ORCPT ); Tue, 27 Feb 2018 11:37:25 -0500 Received: by mail-pf0-f196.google.com with SMTP id a16so2336186pfn.9 for ; Tue, 27 Feb 2018 08:37:25 -0800 (PST) Subject: Re: [PATCH net-next] team: Use extack to report enslavement failures To: Ido Schimmel , netdev@vger.kernel.org Cc: davem@davemloft.net, jiri@mellanox.com, mlxsw@mellanox.com References: <20180227153808.10740-1-idosch@mellanox.com> From: David Ahern Message-ID: <31272e07-a7d6-499d-f1c1-caa2d50e0fb8@gmail.com> Date: Tue, 27 Feb 2018 09:37:23 -0700 MIME-Version: 1.0 In-Reply-To: <20180227153808.10740-1-idosch@mellanox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On 2/27/18 8:38 AM, Ido Schimmel wrote: > Use extack inside team's enslavement function and also propagate it to > the netdevice notifier to allow enslaved ports to report the failure > reason. Example: > > $ teamd -t team0 -d -c '{"runner": {"name": "lacp"}}' > $ ip link set dev lo master team0 > Error: Loopback device can't be added as a team port. > > Signed-off-by: Ido Schimmel > Acked-by: Jiri Pirko > --- > drivers/net/team/team.c | 16 +++++++++++----- > 1 file changed, 11 insertions(+), 5 deletions(-) > LGTM. Acked-by: David Ahern