From: Heiko Stuebner <heiko@sntech.de>
To: linux-rockchip@lists.infradead.org,
Michael Riesch <michael.riesch@wolfvision.net>
Cc: ivan@ivan.computer, punitagrawal@gmail.com,
Michael Riesch <michael.riesch@wolfvision.net>
Subject: Re: [RFC PATCH 2/3] net: stmmac: dwmac-rk: clean up includes
Date: Tue, 21 Sep 2021 16:34:02 +0200 [thread overview]
Message-ID: <3129085.aeNJFYEL58@phil> (raw)
In-Reply-To: <20210915170255.30561-3-michael.riesch@wolfvision.net>
Am Mittwoch, 15. September 2021, 19:02:54 CEST schrieb Michael Riesch:
> Sort includes alphabetically and remove unused includes.
>
> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
This is nice in its own right
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> ---
> drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 14 +++++---------
> 1 file changed, 5 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
> index 0db8be543ee1..96ec7d73a74a 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
> @@ -7,20 +7,16 @@
> * Chen-Zhi (Roger Chen) <roger.chen@rock-chips.com>
> */
>
> -#include <linux/stmmac.h>
> -#include <linux/bitops.h>
> #include <linux/clk.h>
> -#include <linux/phy.h>
> -#include <linux/of_net.h>
> -#include <linux/gpio.h>
> +#include <linux/mfd/syscon.h>
> #include <linux/module.h>
> -#include <linux/of_gpio.h>
> #include <linux/of_device.h>
> +#include <linux/of_net.h>
> +#include <linux/phy.h>
> #include <linux/platform_device.h>
> -#include <linux/regulator/consumer.h>
> -#include <linux/delay.h>
> -#include <linux/mfd/syscon.h>
> #include <linux/regmap.h>
> +#include <linux/regulator/consumer.h>
> +#include <linux/stmmac.h>
>
> #include "stmmac_platform.h"
>
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2021-09-21 14:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 17:02 [RFC PATCH 0/3] net: stmmac: dwmac-rk: use stmmac helper functions and clean up Michael Riesch
2021-09-15 17:02 ` [RFC PATCH 1/3] net: stmmac: dwmac-rk: use stmmac helper functions for pm ops and remove Michael Riesch
2021-09-21 14:23 ` Heiko Stuebner
2021-09-15 17:02 ` [RFC PATCH 2/3] net: stmmac: dwmac-rk: clean up includes Michael Riesch
2021-09-21 14:34 ` Heiko Stuebner [this message]
2021-09-15 17:02 ` [RFC PATCH 3/3] net: stmmac: dwmac-rk: use stmmac helper functions for clock management Michael Riesch
2021-09-15 23:29 ` [RFC PATCH 0/3] net: stmmac: dwmac-rk: use stmmac helper functions and clean up Punit Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3129085.aeNJFYEL58@phil \
--to=heiko@sntech.de \
--cc=ivan@ivan.computer \
--cc=linux-rockchip@lists.infradead.org \
--cc=michael.riesch@wolfvision.net \
--cc=punitagrawal@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.