From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6D0FC433EF for ; Sun, 5 Sep 2021 21:08:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B1F4F60F92 for ; Sun, 5 Sep 2021 21:08:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233779AbhIEVJe (ORCPT ); Sun, 5 Sep 2021 17:09:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231968AbhIEVJe (ORCPT ); Sun, 5 Sep 2021 17:09:34 -0400 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80880C061575 for ; Sun, 5 Sep 2021 14:08:30 -0700 (PDT) Received: by mail-ed1-x533.google.com with SMTP id s25so6682143edw.0 for ; Sun, 05 Sep 2021 14:08:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TSZVN/xDExOJoq3d1TZIuZP5CsJa9TOn/k0uIYOt3pU=; b=kTScqyopi4qn+SqT7G+N4MP/bT11PvCEKEtGXZOPEpwUJjx7ubCqPGGLWhkZHpsN7l l6+ok9AoaRlIib7iOf4yRQodsbl/0UU0pPtlTSY9rulOTOdFTgrAvW/hd5jSOlizPXIF +DvM1rSKo6l0xa+8ClOeNlT1VAR0RCt6GkLN9EAoLyY9wn0Rrbv1BroGSH1lt2Vi40la UWJd0UKcTm157/rFRzBSBZyYS3dRHxteTxGs4jcPXqp3tTMZmdk4HnMvq6EjTxgLDTeV sN82e31tmO3WuM7chPIKH6fmSw0DTI/9XC9qy7SjlKlCHM0z+s6EdrpbHX5yb0QEggS6 mjfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TSZVN/xDExOJoq3d1TZIuZP5CsJa9TOn/k0uIYOt3pU=; b=cfMWV5OscxzqO3woIWsBNp4v/Fc2M1KSUUCfmj2lmxxirlicT9BtUFJVZDo66z6Jsq NztYkGB6zxu/srkcAql2tJvUJf9+knQW1T2gmcuqCwYKY893THara8clIueHokttao4s rdIrxAUnfAsg55XvEt3AxnFbwq56GUKnPo8nvvqmasArNnUOoxkuJrCEwno56TjzzGOu VEtqZhMQImIZbfzfgUZwb6ICZ0Y/QFuFEYADkfTQdTJQqxq/Q7uV74QJqqbfvb3+HPAh 9QdLqgwk3gDcpyzhvevD/ZY032klm4Ct3sF4E6WN6ikZo3nG3wJ88IK8Gxd+X/hjlCAc yyuQ== X-Gm-Message-State: AOAM530JctZIfOnq3pAykA6IOPn3e0uH+mf9BK4KUfPJ+PHcGGN7oy1f P88TjYItajqcvZflxkZ0Ys0AT90/u0KXiA== X-Google-Smtp-Source: ABdhPJwJfAe1EIbL2mWxoXbAY7mtmzLmoFK4sL24zCMN8etBYvrt91Yn7Ad8Ch/lADKi+BcXAJPvWw== X-Received: by 2002:aa7:cd92:: with SMTP id x18mr10016319edv.325.1630876109190; Sun, 05 Sep 2021 14:08:29 -0700 (PDT) Received: from kista.localnet (cpe-86-58-29-253.static.triera.net. [86.58.29.253]) by smtp.gmail.com with ESMTPSA id h7sm3407796edr.4.2021.09.05.14.08.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Sep 2021 14:08:28 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: devicetree@vger.kernel.org, Rob Herring , Frank Rowand , Chen-Yu Tsai , Maxime Ripard , Maxime Ripard Cc: linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v2 44/52] ARM: dts: v3s: Remove useless DMA properties Date: Sun, 05 Sep 2021 23:08:27 +0200 Message-ID: <3131369.y1uDJ13AhA@kista> In-Reply-To: <20210901091852.479202-45-maxime@cerno.tech> References: <20210901091852.479202-1-maxime@cerno.tech> <20210901091852.479202-45-maxime@cerno.tech> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Maxime! Dne sreda, 01. september 2021 ob 11:18:44 CEST je Maxime Ripard napisal(a): > The crypto engine binding doesn't allow for any DMA property, yet the > v3s define some. Remove them. > > Signed-off-by: Maxime Ripard > --- > arch/arm/boot/dts/sun8i-v3s.dtsi | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi b/arch/arm/boot/dts/sun8i- v3s.dtsi > index b30bc1a25ebb..44382e36e825 100644 > --- a/arch/arm/boot/dts/sun8i-v3s.dtsi > +++ b/arch/arm/boot/dts/sun8i-v3s.dtsi > @@ -285,8 +285,6 @@ crypto@1c15000 { > interrupts = ; > clocks = <&ccu CLK_BUS_CE>, <&ccu CLK_CE>; > clock-names = "ahb", "mod"; > - dmas = <&dma 16>, <&dma 16>; > - dma-names = "rx", "tx"; Since V3s documentation mentions those DMA channels, wouldn't be better to update bindings instead? Best regards, Jernej > resets = <&ccu RST_BUS_CE>; > reset-names = "ahb"; > }; > -- > 2.31.1 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1E48C433F5 for ; Sun, 5 Sep 2021 21:10:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7161160F5E for ; Sun, 5 Sep 2021 21:10:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7161160F5E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iA0+a0fcaDDnL98DgRTDRljiRQpbNW3dmMAkvlKUk6w=; b=KnZmwrmqJ4447N W5k7GK9nL2rsm2Jk3xClPuz8veEPGqmUFP9ada2MfjpVhgl9udqRBrpS9uZgBnzgGmAkJZ8miGgaM hYIYK3dj7ku3Xa6ZKy84v5m4t7P4pLVAfkjKs2T55hkJaBdmKLfj1oFy4YtSX9+AYXCCkaOaGhw91 LVd8mg/o/3IyVI50LHOTow2uLrFzYtaOLzUte1HGMhaJFTGy21VyLHQitOKwovxk+NZrQg6VwqirZ PR3ydCn5NP9k57eLQW+tKsPHs3gusq0vVP6CfC+dpWbLXfIHZqcEgXGF1hzfAj4htYg4/dn9y0QKt TW/4aqlgTDd1WYp6HPAA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mMzNT-00GW5e-Ga; Sun, 05 Sep 2021 21:08:35 +0000 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mMzNO-00GW42-Uo for linux-arm-kernel@lists.infradead.org; Sun, 05 Sep 2021 21:08:32 +0000 Received: by mail-ed1-x531.google.com with SMTP id j13so6582689edv.13 for ; Sun, 05 Sep 2021 14:08:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TSZVN/xDExOJoq3d1TZIuZP5CsJa9TOn/k0uIYOt3pU=; b=kTScqyopi4qn+SqT7G+N4MP/bT11PvCEKEtGXZOPEpwUJjx7ubCqPGGLWhkZHpsN7l l6+ok9AoaRlIib7iOf4yRQodsbl/0UU0pPtlTSY9rulOTOdFTgrAvW/hd5jSOlizPXIF +DvM1rSKo6l0xa+8ClOeNlT1VAR0RCt6GkLN9EAoLyY9wn0Rrbv1BroGSH1lt2Vi40la UWJd0UKcTm157/rFRzBSBZyYS3dRHxteTxGs4jcPXqp3tTMZmdk4HnMvq6EjTxgLDTeV sN82e31tmO3WuM7chPIKH6fmSw0DTI/9XC9qy7SjlKlCHM0z+s6EdrpbHX5yb0QEggS6 mjfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TSZVN/xDExOJoq3d1TZIuZP5CsJa9TOn/k0uIYOt3pU=; b=p8ov45bw/xzHsg5xP/zbJlivOlx8rICNMDrR76fGe2pJgR86hkLviKjv1pNwK/nT7i lOil7X43fPtcwozrwAbZdF98Qmp2+Dy15dxAezha/GLhVFMFx5QVie8jJFehDkUEHqkh QnEmmzpRvfwcQY/Yx5OsaUqW3BzNPZPAqOUNG1nS6cvV4SJG7KSk6kB9vCzF0XOIPso7 GxWiOt+7FUmlLjMJowHX/bPlUJCd0Xq8cUwRTR0YgnQ75afSa5ZLWjARPPbf+eA6xftL rlPQSUMNiaT0Ep5NzXmTTMeN6hXG0+ClcUkiX2DvtEAte/0AnDdoprZX827HRMfY68zV jUxQ== X-Gm-Message-State: AOAM532HnVu/kDUyWxUvCQmUkLpoMnvCem0IURePUpaOVyw6BM14A4bG sYDzmk25XGpHPsskb9dh7EM= X-Google-Smtp-Source: ABdhPJwJfAe1EIbL2mWxoXbAY7mtmzLmoFK4sL24zCMN8etBYvrt91Yn7Ad8Ch/lADKi+BcXAJPvWw== X-Received: by 2002:aa7:cd92:: with SMTP id x18mr10016319edv.325.1630876109190; Sun, 05 Sep 2021 14:08:29 -0700 (PDT) Received: from kista.localnet (cpe-86-58-29-253.static.triera.net. [86.58.29.253]) by smtp.gmail.com with ESMTPSA id h7sm3407796edr.4.2021.09.05.14.08.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Sep 2021 14:08:28 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: devicetree@vger.kernel.org, Rob Herring , Frank Rowand , Chen-Yu Tsai , Maxime Ripard , Maxime Ripard Cc: linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v2 44/52] ARM: dts: v3s: Remove useless DMA properties Date: Sun, 05 Sep 2021 23:08:27 +0200 Message-ID: <3131369.y1uDJ13AhA@kista> In-Reply-To: <20210901091852.479202-45-maxime@cerno.tech> References: <20210901091852.479202-1-maxime@cerno.tech> <20210901091852.479202-45-maxime@cerno.tech> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210905_140831_058243_5EBDC580 X-CRM114-Status: GOOD ( 14.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Maxime! Dne sreda, 01. september 2021 ob 11:18:44 CEST je Maxime Ripard napisal(a): > The crypto engine binding doesn't allow for any DMA property, yet the > v3s define some. Remove them. > > Signed-off-by: Maxime Ripard > --- > arch/arm/boot/dts/sun8i-v3s.dtsi | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi b/arch/arm/boot/dts/sun8i- v3s.dtsi > index b30bc1a25ebb..44382e36e825 100644 > --- a/arch/arm/boot/dts/sun8i-v3s.dtsi > +++ b/arch/arm/boot/dts/sun8i-v3s.dtsi > @@ -285,8 +285,6 @@ crypto@1c15000 { > interrupts = ; > clocks = <&ccu CLK_BUS_CE>, <&ccu CLK_CE>; > clock-names = "ahb", "mod"; > - dmas = <&dma 16>, <&dma 16>; > - dma-names = "rx", "tx"; Since V3s documentation mentions those DMA channels, wouldn't be better to update bindings instead? Best regards, Jernej > resets = <&ccu RST_BUS_CE>; > reset-names = "ahb"; > }; > -- > 2.31.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel