From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3] gro: add missing invalid TCP header length check Date: Thu, 17 Jan 2019 22:41:11 +0100 Message-ID: <3141903.1XLmcNQKVu@xps> References: <1547132768-2384-1-git-send-email-jiayu.hu@intel.com> <1547599533-124469-1-git-send-email-jiayu.hu@intel.com> <2601191342CEEE43887BDE71AB977258010D9047CF@irsmsx105.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, "Ananyev, Konstantin" , "stable@dpdk.org" To: "Hu, Jiayu" Return-path: In-Reply-To: <2601191342CEEE43887BDE71AB977258010D9047CF@irsmsx105.ger.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 16/01/2019 10:49, Ananyev, Konstantin: > From: Hu, Jiayu > > > > When the TCP header length of input packets is invalid (i.e., less > > than 20 bytes or greater than 60 bytes), check_seq_option() will > > access illegal memory area when compare TCP Options, which may > > cause a segmentation fault. > > > > This patch adds missing invalid TCP header length check to avoid > > illegal memory accesses. > > > > Fixes: 0d2cbe59b719 ("lib/gro: support TCP/IPv4") > > Fixes: 9e0b9d2ec0f4 ("gro: support VxLAN GRO") > > Cc: stable@dpdk.org > > > > Signed-off-by: Jiayu Hu > > Tested-by: Yinan Wang > > Acked-by: Konstantin Ananyev Applied, thanks