From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH 1/3] cpufreq / gx: Fix __init attribute locations Date: Tue, 13 Aug 2013 15:19:40 +0200 Message-ID: <3142844.ubsh56jNy7@vostro.rjw.lan> References: <1376389210-11470-1-git-send-email-hanjun.guo@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7Bit Return-path: Received: from hydra.sisk.pl ([212.160.235.94]:41052 "EHLO hydra.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757857Ab3HMNJP (ORCPT ); Tue, 13 Aug 2013 09:09:15 -0400 In-Reply-To: <1376389210-11470-1-git-send-email-hanjun.guo@linaro.org> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Hanjun Guo Cc: Viresh Kumar , cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, patches@linaro.org, linaro-kernel@lists.linaro.org, linaro-acpi@lists.linaro.org On Tuesday, August 13, 2013 06:20:08 PM Hanjun Guo wrote: > __init belongs after the return type on functions, not before it. > > Signed-off-by: Hanjun Guo All 3 patches in the series queued up for 3.12. Thanks, Rafael > --- > drivers/cpufreq/gx-suspmod.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/gx-suspmod.c b/drivers/cpufreq/gx-suspmod.c > index 3dfc99b..e30fd16 100644 > --- a/drivers/cpufreq/gx-suspmod.c > +++ b/drivers/cpufreq/gx-suspmod.c > @@ -183,7 +183,7 @@ static void gx_write_byte(int reg, int value) > * gx_detect_chipset: > * > **/ > -static __init struct pci_dev *gx_detect_chipset(void) > +static struct pci_dev * __init gx_detect_chipset(void) > { > struct pci_dev *gx_pci = NULL; > > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.