From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH 4/4] szedata2: add 100G link speed
Date: Tue, 15 Mar 2016 21:51:20 +0100
Message-ID: <3143083.jraRr5hQp4@xps13>
References: <1457992546-32230-1-git-send-email-thomas.monjalon@6wind.com>
 <8527284.jAONBlNGsn@xps13> <56E8133C.2020307@cesnet.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Cc: marcdevel@gmail.com, dev@dpdk.org
To: Matej Vido <vido@cesnet.cz>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51])
 by dpdk.org (Postfix) with ESMTP id 05E54137C
 for <dev@dpdk.org>; Tue, 15 Mar 2016 21:52:47 +0100 (CET)
Received: by mail-wm0-f51.google.com with SMTP id p65so44370834wmp.0
 for <dev@dpdk.org>; Tue, 15 Mar 2016 13:52:47 -0700 (PDT)
In-Reply-To: <56E8133C.2020307@cesnet.cz>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-03-15 14:50, Matej Vido:
>=20
> D=C5=88a 15.03.2016 o 14:41 Thomas Monjalon nap=C3=ADsal(a):
> > Thanks for the series completing the ethdev rework with the same sp=
litting.
> >
> > 2016-03-15 14:12, Matej Vido:
> >> Temporary 10G constant is replaced with 100G constant.
> >> Item speed_capa from struct rte_eth_dev_info is set with 100G flag=
.
> > [...]
> >> @@ -1161,7 +1162,7 @@ eth_link_update(struct rte_eth_dev *dev,
> >>   =09=09 * will be changed to support 100Gbps speed change
> >>   =09=09 * this value to 100G.
> >>   =09=09 */
> >> -=09=09link.link_speed =3D ETH_SPEED_NUM_10G;
> >> +=09=09link.link_speed =3D ETH_SPEED_NUM_100G;
> > Shouldn't we remove the above comment?
> Yes, I forgot. Should I remove the comment and send again or could yo=
u=20
> do it when merging with original series?

I'll do it, thanks.