All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Mcnamara, John" <john.mcnamara@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v3 1/2] version: switch to year/month version numbers
Date: Wed, 10 Feb 2016 18:20:16 +0100	[thread overview]
Message-ID: <3149452.Rm3BBxm9PK@xps13> (raw)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE2024518DC@IRSMSX103.ger.corp.intel.com>

2016-02-10 17:11, Mcnamara, John:
> Hi Alejandro,
> 
> Please note the above change to the nfp_net.c code due to the name change
> in the version macro names.
> 
> 
> I was originally going to change it to this:
> 
>     #if RTE_VER_YEAR == 2 && RTE_VER_MONTH >= 1
>         dev_info->hash_key_size = NFP_NET_CFG_RSS_KEY_SZ;
>     #endif
> 
> Or better:
> 
>     #if RTE_VERSION >= 0x02010000
>         dev_info->hash_key_size = NFP_NET_CFG_RSS_KEY_SZ;
>     #endif

Or better:
	#if RTE_VERSION >= RTE_VERSION_NUM(2,1,0,0)

> However, since the code was added in DPDK 2.2 the version check doesn't seem
> necessary, so I removed it. If you need it back in for some reason let me know.

A version check is needed for external applications or external drivers.
It should not exist in the git tree.

  reply	other threads:[~2016-02-10 17:21 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-21 13:26 [PATCH 0/3] switch to using YY.MM version numbers Bruce Richardson
2015-12-21 13:26 ` [PATCH 1/3] version: switch to year/month " Bruce Richardson
2016-02-10 14:33   ` [PATCH v2 1/2] " John McNamara
2016-02-10 14:33     ` [PATCH v2 2/2] doc: rename release notes 2.3 to 16.04 John McNamara
2016-02-10 15:11     ` [PATCH v2 1/2] version: switch to year/month version numbers Thomas Monjalon
2016-02-10 15:31       ` Bruce Richardson
2016-02-10 16:52       ` Mcnamara, John
2015-12-21 13:26 ` [PATCH 2/3] version: adjust printing for new version scheme Bruce Richardson
2015-12-28 22:25   ` Thomas Monjalon
2016-02-10 14:28     ` Mcnamara, John
2015-12-21 13:26 ` [PATCH 3/3] doc: rename release 2.3 to 16.04 Bruce Richardson
2016-02-10 17:02 ` [PATCH v3 1/2] version: switch to year/month version numbers John McNamara
2016-02-10 17:02   ` [PATCH v3 2/2] doc: rename release notes 2.3 to 16.04 John McNamara
2016-02-10 17:11   ` [PATCH v3 1/2] version: switch to year/month version numbers Mcnamara, John
2016-02-10 17:20     ` Thomas Monjalon [this message]
2016-02-10 21:49   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3149452.Rm3BBxm9PK@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=john.mcnamara@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.