From: Arnd Bergmann <arnd@arndb.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Lee Jones <lee.jones@linaro.org>, "Andrew F. Davis" <afd@ti.com>,
Marc Zyngier <marc.zyngier@arm.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
linux-kernel@vger.kernel.org,
Marcin Niestroj <m.niestroj@grinn-global.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH] [RFC] irqchip or mfd/tps65217: fix link error
Date: Wed, 14 Sep 2016 15:56:35 +0200 [thread overview]
Message-ID: <3153379.K6IZxfs9ll@wuerfel> (raw)
In-Reply-To: <alpine.DEB.2.20.1609141129440.6233@nanos>
On Wednesday, September 14, 2016 11:31:17 AM CEST Thomas Gleixner wrote:
> On Wed, 14 Sep 2016, Arnd Bergmann wrote:
> > Building tps65217 as a loadable module (as done in allmodconfig)
> > now fails after we started calling irq_set_parent():
> >
> > ERROR: "irq_set_parent" [drivers/mfd/tps65217.ko] undefined!
> >
> > The two obvious workarounds are either to force the driver
> > to be built-in, or to make that symbol exported to modules.
> >
> > As it's not clear to me if either of them would be acceptable,
> > I'm sending both of them here, please comment on which one
> > you want to have, or whether the driver should handle this
> > differently and not call irq_set_parent() at all.
>
> The question is why it needs to call that. But if it's justified, then I'm
> not opposed to export it.
Ok. I just noticed that I forgot to put the right people on Cc
that worked on the patch originally, fixed that now.
My other approach of making the symbol "bool" in the meantime has
caused another problem when CONFIG_I2C=m:
drivers/mfd/tps65217.o: In function `tps65217_init':
tps65217.c:(.init.text+0x8): undefined reference to `i2c_register_driver'
drivers/mfd/tps65217.o: In function `tps65217_probe':
tps65217.c:(.text.tps65217_probe+0x94): undefined reference to `__devm_regmap_init_i2c'
so the dependency would be "depends on I2C=y", getting increasingly
ugly. I'll let Marcin or Grygorii reply on why the call is needed,
we can then either export the symbol or change the code.
Arnd
next prev parent reply other threads:[~2016-09-14 13:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 8:22 [PATCH] [RFC] irqchip or mfd/tps65217: fix link error Arnd Bergmann
2016-09-14 9:31 ` Thomas Gleixner
2016-09-14 13:56 ` Arnd Bergmann [this message]
2016-09-14 15:09 ` Marcin Niestroj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3153379.K6IZxfs9ll@wuerfel \
--to=arnd@arndb.de \
--cc=afd@ti.com \
--cc=daniel.lezcano@linaro.org \
--cc=grygorii.strashko@ti.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.niestroj@grinn-global.com \
--cc=marc.zyngier@arm.com \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.