From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp181.sjtu.edu.cn (smtp181.sjtu.edu.cn [202.120.2.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E1033FC7 for ; Fri, 24 Sep 2021 02:57:56 +0000 (UTC) Received: from proxy02.sjtu.edu.cn (smtp188.sjtu.edu.cn [202.120.2.188]) by smtp181.sjtu.edu.cn (Postfix) with ESMTPS id 6A7D01008CBCD; Fri, 24 Sep 2021 10:57:53 +0800 (CST) Received: from localhost (localhost.localdomain [127.0.0.1]) by proxy02.sjtu.edu.cn (Postfix) with ESMTP id 4CB78200BC2D9; Fri, 24 Sep 2021 10:57:53 +0800 (CST) X-Virus-Scanned: amavisd-new at Received: from proxy02.sjtu.edu.cn ([127.0.0.1]) by localhost (proxy02.sjtu.edu.cn [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id mox-xDx8C2lv; Fri, 24 Sep 2021 10:57:53 +0800 (CST) Received: from [192.168.10.98] (unknown [202.120.40.82]) (Authenticated sender: qtxuning1999@sjtu.edu.cn) by proxy02.sjtu.edu.cn (Postfix) with ESMTPSA id 2FB9E200B5750; Fri, 24 Sep 2021 10:57:19 +0800 (CST) Message-ID: <3159c45c-b417-c157-e108-c0e12af2e122@sjtu.edu.cn> Date: Fri, 24 Sep 2021 10:57:18 +0800 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.1 Subject: Re: [PATCH] staging: vchip_arm: Fix misuse of %x Content-Language: en-US To: Greg KH , nsaenz@kernel.org, peterz@infradead.org, maz@kernel.org, bsegall@google.com, rdunlap@infradead.org, airlied@redhat.com, kan.liang@linux.intel.com, odin@uged.al, phil@raspberrypi.com Cc: bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20210923035554.669434-1-qtxuning1999@sjtu.edu.cn> From: Guo Zhi In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2021/9/23 13:19, Greg KH wrote: > On Thu, Sep 23, 2021 at 11:55:54AM +0800, Guo Zhi wrote: >> Pointers should be printed with %p or %px rather than >> cast to (unsigned long) and printed with %lx. >> Change %lx to %pK to print the pointers. >> >> Signed-off-by: Guo Zhi >> --- >> .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c >> index b5aac862a29..408e5fe710b 100644 >> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c >> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c >> @@ -591,11 +591,11 @@ service_callback(enum vchiq_reason reason, struct vchiq_header *header, >> return VCHIQ_SUCCESS; >> >> vchiq_log_trace(vchiq_arm_log_level, >> - "%s - service %lx(%d,%p), reason %d, header %lx, instance %lx, bulk_userdata %lx", >> - __func__, (unsigned long)user_service, >> + "%s - service %pK(%d,%p), reason %d, header %pK, instance %pK, bulk_userdata %pK", >> + __func__, user_service, >> service->localport, user_service->userdata, >> - reason, (unsigned long)header, >> - (unsigned long)instance, (unsigned long)bulk_userdata); >> + reason, header, >> + instance, bulk_userdata); > Why print this out at all? What uses this? Can it just be deleted? > > thanks, > > greg k-h This information is printed for debugging usage. But malicious user process can also print it through debugfs at /sys/kernel/debug. As it can be used for debugging, it's a little radical to just delete. Therefore, I suggest replacing %lx with %pK to avoid kernel address leakage. thanks, Guo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBFB9C433F5 for ; Fri, 24 Sep 2021 03:00:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7C1B9610F7 for ; Fri, 24 Sep 2021 03:00:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7C1B9610F7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sjtu.edu.cn Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/w2RlFEXQk3HD164D95N8vpUOQo+6EQgMDhjh82fyew=; b=vPKotjImy0znl/ PXyFcQzYUw/dUjnRmTBG4QyKDVh2coTUODsluSiNPWlj58BLM0QYNkZjg4BJngNpHHiTqo8qAsgcQ lLwvIlxGJsww7JyOEtuB0sjEOa6G1n1k14AazxZy1ZE7zqJKUyIZRe3XFOow5yNk/+0osqo97WShX FtVOdNc3A4xvUo87rBPFlqd8fx4MaIrWapJ73aC5qiiZAekPNVaMoR9LmmwcCR1XLpsdMbZlcme5s qPYOXsf70N/yHEPBsA2xM3tZE4Rb01qfzPSGWD9tpg7Gi1wDjMwowqvuBZMdXiXeBB3FY1GRKEnJP wXlsqs+sV+j2JGe0v2Kg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mTbPa-00CxKG-22; Fri, 24 Sep 2021 02:58:06 +0000 Received: from smtp181.sjtu.edu.cn ([202.120.2.181]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mTbPW-00CxJ5-5F; Fri, 24 Sep 2021 02:58:04 +0000 Received: from proxy02.sjtu.edu.cn (smtp188.sjtu.edu.cn [202.120.2.188]) by smtp181.sjtu.edu.cn (Postfix) with ESMTPS id 6A7D01008CBCD; Fri, 24 Sep 2021 10:57:53 +0800 (CST) Received: from localhost (localhost.localdomain [127.0.0.1]) by proxy02.sjtu.edu.cn (Postfix) with ESMTP id 4CB78200BC2D9; Fri, 24 Sep 2021 10:57:53 +0800 (CST) X-Virus-Scanned: amavisd-new at Received: from proxy02.sjtu.edu.cn ([127.0.0.1]) by localhost (proxy02.sjtu.edu.cn [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id mox-xDx8C2lv; Fri, 24 Sep 2021 10:57:53 +0800 (CST) Received: from [192.168.10.98] (unknown [202.120.40.82]) (Authenticated sender: qtxuning1999@sjtu.edu.cn) by proxy02.sjtu.edu.cn (Postfix) with ESMTPSA id 2FB9E200B5750; Fri, 24 Sep 2021 10:57:19 +0800 (CST) Message-ID: <3159c45c-b417-c157-e108-c0e12af2e122@sjtu.edu.cn> Date: Fri, 24 Sep 2021 10:57:18 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.1 Subject: Re: [PATCH] staging: vchip_arm: Fix misuse of %x Content-Language: en-US To: Greg KH , nsaenz@kernel.org, peterz@infradead.org, maz@kernel.org, bsegall@google.com, rdunlap@infradead.org, airlied@redhat.com, kan.liang@linux.intel.com, odin@uged.al, phil@raspberrypi.com Cc: bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20210923035554.669434-1-qtxuning1999@sjtu.edu.cn> From: Guo Zhi In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210923_195802_437269_F8904A49 X-CRM114-Status: GOOD ( 12.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2021/9/23 13:19, Greg KH wrote: > On Thu, Sep 23, 2021 at 11:55:54AM +0800, Guo Zhi wrote: >> Pointers should be printed with %p or %px rather than >> cast to (unsigned long) and printed with %lx. >> Change %lx to %pK to print the pointers. >> >> Signed-off-by: Guo Zhi >> --- >> .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c >> index b5aac862a29..408e5fe710b 100644 >> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c >> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c >> @@ -591,11 +591,11 @@ service_callback(enum vchiq_reason reason, struct vchiq_header *header, >> return VCHIQ_SUCCESS; >> >> vchiq_log_trace(vchiq_arm_log_level, >> - "%s - service %lx(%d,%p), reason %d, header %lx, instance %lx, bulk_userdata %lx", >> - __func__, (unsigned long)user_service, >> + "%s - service %pK(%d,%p), reason %d, header %pK, instance %pK, bulk_userdata %pK", >> + __func__, user_service, >> service->localport, user_service->userdata, >> - reason, (unsigned long)header, >> - (unsigned long)instance, (unsigned long)bulk_userdata); >> + reason, header, >> + instance, bulk_userdata); > Why print this out at all? What uses this? Can it just be deleted? > > thanks, > > greg k-h This information is printed for debugging usage. But malicious user process can also print it through debugfs at /sys/kernel/debug. As it can be used for debugging, it's a little radical to just delete. Therefore, I suggest replacing %lx with %pK to avoid kernel address leakage. thanks, Guo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel