From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Cc: linux-renesas-soc@vger.kernel.org, kieran.bingham@ideasonboard.com
Subject: Re: [PATCH 4/5] vsp-lib: Support RPF frame cropping
Date: Fri, 10 Feb 2017 11:20:20 +0200 [thread overview]
Message-ID: <31635178.gz5IoCATKn@avalon> (raw)
In-Reply-To: <a5a3445637837e9bca24ccc6585e40f52acbe069.1486562055.git-series.kieran.bingham@ideasonboard.com>
Hi Kieran,
Thank you for the patch.
On Wednesday 08 Feb 2017 14:03:59 Kieran Bingham wrote:
> From: Kieran Bingham <kieran.bingham@ideasonboard.com>
>
> Pass the optional '--crop (X,Y)/WxH' parameter through reference_frame
> allowing the input to be cropped for comparison
>
> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> ---
> scripts/vsp-lib.sh | 37 +++++++++++++++++++++++++++++++++++++
> 1 file changed, 37 insertions(+)
>
> diff --git a/scripts/vsp-lib.sh b/scripts/vsp-lib.sh
> index 08bf8f36c582..42a4bb20d1be 100755
> --- a/scripts/vsp-lib.sh
> +++ b/scripts/vsp-lib.sh
> @@ -162,6 +162,9 @@ reference_frame() {
> vflip)
> [ x$value = x1 ] && options="$options --vflip"
> ;;
> + crop)
> + options="$options --crop $value"
> + ;;
Could you please keep the options sorted alphabetically ?
> esac
> done
>
> @@ -717,6 +720,40 @@ format_rpf_wpf() {
> __vsp_wpf_format=$5
> }
>
> +format_crop_rpf_wpf() {
> + local rpf=$1
> + local wpf=$2
> + local infmt=$(format_v4l2_to_mbus $3)
> + local size=$4
> + local outfmt=$(format_v4l2_to_mbus $5)
> + local rpfcrop=$6
> + local wpfcrop=$7
> + local rpfoutsize=
> + local outsize=
> +
> + if [ x$rpfcrop != 'x' ] ; then
I don't think this will work properly. You want to test for the presence of an
RPF crop argument. If it's absent, and the WPF crop argument is specified, WPF
crop will be stored in $6, and will thus be assigned to $rpfcrop.
I see two possible solutions. One of them is to make the RPF crop argument
mandatory. After all, given the function name, one can expect RPF crop to be
specified, otherwise the caller should use rpf-wpf, not crop-rpf-wpf. Another
more versatile option would be to add RPF crop support to the existing
format_rpf_wpf() crop function, and make both RPF and WPF crop optional. You
could use named option for that (rcrop=... wcrop=...) or use a special value
to indicate that an option should be skipped (for instance "- (0,0)/640x480"
to set the WPF crop rectangle without setting the RPF crop rectangle).
> + rpfcrop="crop:$rpfcrop"
> + rpfoutsize=$(echo $rpfcrop | sed 's/.*\///')
> + else
> + rpfoutsize=$size
> + fi
> +
> + if [ x$wpfcrop != 'x' ] ; then
> + wpfcrop="crop:$wpfcrop"
> + outsize=$(echo $wpfcrop | sed 's/.*\///')
> + else
> + outsize=$rpfoutsize
> + fi
> +
> + $mediactl -d $mdev -V "'$dev rpf.$rpf':0 [fmt:$infmt/$size $rpfcrop]"
> + $mediactl -d $mdev -V "'$dev rpf.$rpf':1 [fmt:$infmt/$rpfoutsize]"
> + $mediactl -d $mdev -V "'$dev wpf.$wpf':0 [fmt:$infmt/$rpfoutsize
> $wpfcrop]"
> + $mediactl -d $mdev -V "'$dev wpf.$wpf':1 [fmt:$outfmt/$outsize]"
> +
> + __vsp_rpf_format=$3
> + __vsp_wpf_format=$5
> +}
> +
> format_wpf() {
> local format=$(format_v4l2_to_mbus $1)
> local size=$2
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2017-02-10 9:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-08 14:03 [PATCH 0/5] vsp-tests: Implement RPF cropping tests Kieran Bingham
2017-02-08 14:03 ` [PATCH 1/5] vsp-lib: sort output frames correctly Kieran Bingham
2017-02-10 9:21 ` Laurent Pinchart
2017-02-08 14:03 ` [PATCH 2/5] vsp-lib: Filter non-filesystem regular characters Kieran Bingham
2017-02-10 7:58 ` Laurent Pinchart
2017-02-10 9:08 ` Kieran Bingham
2017-02-08 14:03 ` [PATCH 3/5] gen-image: Implement option to parse an input crop Kieran Bingham
2017-02-10 8:19 ` Laurent Pinchart
2017-02-10 11:18 ` Kieran Bingham
2017-02-13 19:48 ` Laurent Pinchart
2017-02-08 14:03 ` [PATCH 4/5] vsp-lib: Support RPF frame cropping Kieran Bingham
2017-02-10 9:20 ` Laurent Pinchart [this message]
2017-02-10 14:53 ` Kieran Bingham
2017-02-08 14:04 ` [PATCH 5/5] tests: Add RPF cropping test Kieran Bingham
2017-02-10 9:22 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31635178.gz5IoCATKn@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.