From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5088A173 for ; Sun, 25 Jul 2021 06:18:26 +0000 (UTC) Received: by mail-ej1-f52.google.com with SMTP id hp25so10074105ejc.11 for ; Sat, 24 Jul 2021 23:18:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=H84xqmHa11HAMqr9XluZ8mJDnlXU0Q8/GhOSAy8zvbM=; b=cmQOMOf2zHkdTV4I/WOFI3ckqJfmc0ANzqy+eZw5qW+Nt6w8J1fEHJOxe4RHIbuXAR 2tWnXZMKI7qcJdKAJeLBtnqFveIzRAmW5Dq8+RSzHTWCtkqA9XQYdOS88imW/BIYt2x8 nNMOeNSwJJVdz5e6ADwVsy7rSWdbW73lRwbz7x8oxQxrL8JrxXcD/jYy/AOcC58KZqmJ KDeGPw3KhZDFvLIyETypvOJ9vF2Jx9iwuyIIRBSglTHdDjVc9h1zKkZo2tIyllDz/mdH uCV9iMU6SBDknoDJlE0lhEqOMGi7jsSsPO5tSWlIuFIagF3osnOtT7iU/kVmTtkIndX5 aoog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=H84xqmHa11HAMqr9XluZ8mJDnlXU0Q8/GhOSAy8zvbM=; b=CokE5s0raNxDg5QPXGVVob//furmqGSbg0YG/m8195FEk4fCc5uhLj/rA7gXjk+c2B 3UCPBdtIPKzOAQsBxNcbS7mzAOOXHhUo/fsHk9lgIunsKRNWn7XNIjuEvC+02ATCYSds NV1P/UREQjcUVZuCfsWmd6m4hX83wuN/QrFSDhHmpdMlLvHP/l430/8MNd/MwzI5NH+J uDmxsRgKdClWN7B4z5/xYjnSw8LPm2tzb9mq06qGeHL3+2VzA2uZ1C1O3f+Qb07m/7aR oL/nEWxvsYXyDXh9+NWQfXCJgeKL8UREDlU5XUEHT28y2rtFn0aBtVYCsj1e4wB0zORf i1uw== X-Gm-Message-State: AOAM533POhF9UsRcmOeNI0LqnmGFIWLHtKrqAfZ8fcrD1FoDv0eBsaoz jPvqjGidzSAxHhmFYaH56KgjXZPY3q4ztJs/ X-Google-Smtp-Source: ABdhPJxmktaNZZWpA+AkVzso45vOYilURFR4DO15pvLqar0nqql5+tqf/hzTtJ+kgzkAffPjCdcAuw== X-Received: by 2002:a17:906:58c9:: with SMTP id e9mr11821418ejs.144.1627193904701; Sat, 24 Jul 2021 23:18:24 -0700 (PDT) Received: from kista.localnet (cpe-86-58-46-198.static.triera.net. [86.58.46.198]) by smtp.gmail.com with ESMTPSA id ja13sm13028177ejc.82.2021.07.24.23.18.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Jul 2021 23:18:24 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Maxime Ripard , Chen-Yu Tsai , Andre Przywara Cc: Rob Herring , Icenowy Zheng , Samuel Holland , linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Ondrej Jirman , Alessandro Zummo , Alexandre Belloni , linux-rtc@vger.kernel.org Subject: Re: [PATCH v8 06/11] rtc: sun6i: Add support for RTCs without external LOSCs Date: Sun, 25 Jul 2021 08:18:23 +0200 Message-ID: <3166830.bveH9cQ5e6@kista> In-Reply-To: <20210723153838.6785-7-andre.przywara@arm.com> References: <20210723153838.6785-1-andre.przywara@arm.com> <20210723153838.6785-7-andre.przywara@arm.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Hi Andre! Dne petek, 23. julij 2021 ob 17:38:33 CEST je Andre Przywara napisal(a): > Some newer Allwinner RTCs (for instance the one in the H616 SoC) lack > a pin for an external 32768 Hz oscillator. As a consequence, this LOSC > can't be selected as the RTC clock source, and we must rely on the > internal RC oscillator. > To allow additions of clocks to the RTC node, add a feature bit to ignore > any provided clocks for now (the current code would think this is the > external LOSC). Later DTs and code can then for instance add the PLL > based clock input, and older kernel won't get confused. > > Signed-off-by: Andre Przywara > --- > drivers/rtc/rtc-sun6i.c | 16 +++++++++++----- > 1 file changed, 11 insertions(+), 5 deletions(-) > Acked-by: Jernej Skrabec Best regards, Jernej From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4478C4338F for ; Sun, 25 Jul 2021 06:19:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 686C060E09 for ; Sun, 25 Jul 2021 06:19:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 686C060E09 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yhB7T/ivvADch4RPOXWfy5MqCBfX4DE7vUjyMiejbvc=; b=N4G46XGgAHN6mm H/whKI4NbcJEJF+FgxPfVI/OI3u5wO0zwbTmstVq46z2mlbQTisZpQzpAg41mfz4ZKAiBsWgUHLqP WyTu1g22S1v+8iZpapd7luj8+vlxRVjq4o/TrGnnA4oDvzda/U158z+gpp179Mun6YhP1LtPLoCE/ 0d0OtikjQIGDcS/0LBmGxo5DgxbXxcoeFRIXXYOB4t0k6lWBNOL2AS44Uejc2BL2QYCnKBl4oF7aX EavCA491TDqzR4GZnVyl+GVcx7AwZ/N7QEUFZJQMEr4pQYFnZfOkA9fntIJPRxdLKDerFT3K9JFXy yeku5a6KJ8y+2Zi0j8lw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m7XT4-008I8q-JP; Sun, 25 Jul 2021 06:18:30 +0000 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m7XT0-008I8M-7F for linux-arm-kernel@lists.infradead.org; Sun, 25 Jul 2021 06:18:27 +0000 Received: by mail-ej1-x62e.google.com with SMTP id hb6so10168233ejc.8 for ; Sat, 24 Jul 2021 23:18:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=H84xqmHa11HAMqr9XluZ8mJDnlXU0Q8/GhOSAy8zvbM=; b=cmQOMOf2zHkdTV4I/WOFI3ckqJfmc0ANzqy+eZw5qW+Nt6w8J1fEHJOxe4RHIbuXAR 2tWnXZMKI7qcJdKAJeLBtnqFveIzRAmW5Dq8+RSzHTWCtkqA9XQYdOS88imW/BIYt2x8 nNMOeNSwJJVdz5e6ADwVsy7rSWdbW73lRwbz7x8oxQxrL8JrxXcD/jYy/AOcC58KZqmJ KDeGPw3KhZDFvLIyETypvOJ9vF2Jx9iwuyIIRBSglTHdDjVc9h1zKkZo2tIyllDz/mdH uCV9iMU6SBDknoDJlE0lhEqOMGi7jsSsPO5tSWlIuFIagF3osnOtT7iU/kVmTtkIndX5 aoog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=H84xqmHa11HAMqr9XluZ8mJDnlXU0Q8/GhOSAy8zvbM=; b=fDghy0wFtPszcy3NmxmqgKRm14VTESax/ySDGx8TB2BiB0sv/Yq1HkIWSHeEtw2PVx BNRLskBLjru7ysPLdBIIh+3wOyBwD6ziKaFHoIyt6ZActWTUZhmOiqFHfcbAYCwUmU0q o+q635NTKKQT8jzTzo7LxRFibWoOKNqqrRT8p4NctSTjmVRpYNS6wz+iVKkzzxGD7WrE TI/ollNr5MPj/U5jPjUITR8ZqHZBwNWXkdO6RquhMsxUNqBifoHtq1lCdO0UWWa4nzD1 CLLNK+jXtDjaDk0z1ZeEAj86Wh62UFScFgh/IWnqRN5AB7A4np5T+wloKAu37Z+hkpVg dBeA== X-Gm-Message-State: AOAM531Q01GM6NKvhknzfznqr6whTGGer7yzH8yv5AGZhcpy+t14ofUe 03k/yj1g0VnHpHW3+TQ9BMc= X-Google-Smtp-Source: ABdhPJxmktaNZZWpA+AkVzso45vOYilURFR4DO15pvLqar0nqql5+tqf/hzTtJ+kgzkAffPjCdcAuw== X-Received: by 2002:a17:906:58c9:: with SMTP id e9mr11821418ejs.144.1627193904701; Sat, 24 Jul 2021 23:18:24 -0700 (PDT) Received: from kista.localnet (cpe-86-58-46-198.static.triera.net. [86.58.46.198]) by smtp.gmail.com with ESMTPSA id ja13sm13028177ejc.82.2021.07.24.23.18.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Jul 2021 23:18:24 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Maxime Ripard , Chen-Yu Tsai , Andre Przywara Cc: Rob Herring , Icenowy Zheng , Samuel Holland , linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Ondrej Jirman , Alessandro Zummo , Alexandre Belloni , linux-rtc@vger.kernel.org Subject: Re: [PATCH v8 06/11] rtc: sun6i: Add support for RTCs without external LOSCs Date: Sun, 25 Jul 2021 08:18:23 +0200 Message-ID: <3166830.bveH9cQ5e6@kista> In-Reply-To: <20210723153838.6785-7-andre.przywara@arm.com> References: <20210723153838.6785-1-andre.przywara@arm.com> <20210723153838.6785-7-andre.przywara@arm.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210724_231826_335939_DEBD177D X-CRM114-Status: GOOD ( 15.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andre! Dne petek, 23. julij 2021 ob 17:38:33 CEST je Andre Przywara napisal(a): > Some newer Allwinner RTCs (for instance the one in the H616 SoC) lack > a pin for an external 32768 Hz oscillator. As a consequence, this LOSC > can't be selected as the RTC clock source, and we must rely on the > internal RC oscillator. > To allow additions of clocks to the RTC node, add a feature bit to ignore > any provided clocks for now (the current code would think this is the > external LOSC). Later DTs and code can then for instance add the PLL > based clock input, and older kernel won't get confused. > > Signed-off-by: Andre Przywara > --- > drivers/rtc/rtc-sun6i.c | 16 +++++++++++----- > 1 file changed, 11 insertions(+), 5 deletions(-) > Acked-by: Jernej Skrabec Best regards, Jernej _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel