From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10543C4338F for ; Fri, 20 Aug 2021 08:44:34 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D34B06113C for ; Fri, 20 Aug 2021 08:44:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D34B06113C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.169333.309295 (Exim 4.92) (envelope-from ) id 1mH08V-0007X5-VB; Fri, 20 Aug 2021 08:44:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 169333.309295; Fri, 20 Aug 2021 08:44:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mH08V-0007Wy-RS; Fri, 20 Aug 2021 08:44:23 +0000 Received: by outflank-mailman (input) for mailman id 169333; Fri, 20 Aug 2021 08:44:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mH08U-0007Ws-SE for xen-devel@lists.xenproject.org; Fri, 20 Aug 2021 08:44:22 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mH08T-0005qx-Tr; Fri, 20 Aug 2021 08:44:21 +0000 Received: from [54.239.6.184] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mH08T-0002oY-O7; Fri, 20 Aug 2021 08:44:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=DtPwRcEZ/aM5yJ/Y/W3ruWx1Xb7pA5ZdSgCqTjlA0xs=; b=AeyT1DMy0Qzk2lZCeQItkP0X5d 3qcQSy4CVzdEesF7JmPQmth4webN3KY1Nf3iTIEVY05frjR8+qHrHYSBGvgNYynJE9mETpN7rsIvj DMHPeA7Z1t8JrDjhNHCDM4fj0GFplwLzbnHuHAP4cojB21OqnTfgB3RC9blrlqIHwb14=; Subject: Re: [XEN RFC PATCH 22/40] xen/arm: introduce a helper to parse device tree processor node To: Wei Chen , "xen-devel@lists.xenproject.org" , "sstabellini@kernel.org" , "jbeulich@suse.com" Cc: Bertrand Marquis References: <20210811102423.28908-1-wei.chen@arm.com> <20210811102423.28908-23-wei.chen@arm.com> From: Julien Grall Message-ID: <317048b1-adfd-d537-aff4-4018e50f348a@xen.org> Date: Fri, 20 Aug 2021 09:44:20 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit On 20/08/2021 03:23, Wei Chen wrote: > Hi Julien, Hi Wei, >> -----Original Message----- >> From: Julien Grall >> Sent: 2021年8月20日 2:13 >> To: Wei Chen ; xen-devel@lists.xenproject.org; >> sstabellini@kernel.org; jbeulich@suse.com >> Cc: Bertrand Marquis >> Subject: Re: [XEN RFC PATCH 22/40] xen/arm: introduce a helper to parse >> device tree processor node >> >> Hi Wei, >> >> On 11/08/2021 11:24, Wei Chen wrote: >>> Processor NUMA ID information is stored in device tree's processor >>> node as "numa-node-id". We need a new helper to parse this ID from >>> processor node. If we get this ID from processor node, this ID's >>> validity still need to be checked. Once we got a invalid NUMA ID >>> from any processor node, the device tree will be marked as NUMA >>> information invalid. >>> >>> Signed-off-by: Wei Chen >>> --- >>> xen/arch/arm/numa_device_tree.c | 41 +++++++++++++++++++++++++++++++-- >>> 1 file changed, 39 insertions(+), 2 deletions(-) >>> >>> diff --git a/xen/arch/arm/numa_device_tree.c >> b/xen/arch/arm/numa_device_tree.c >>> index 1c74ad135d..37cc56acf3 100644 >>> --- a/xen/arch/arm/numa_device_tree.c >>> +++ b/xen/arch/arm/numa_device_tree.c >>> @@ -20,16 +20,53 @@ >>> #include >>> #include >>> #include >>> +#include >> >> Nothing in this file seems to depend on xen/device_tree.h. So why do you >> need to include it? >> > > I remember that without this header file, device_tree_get_u32 in this patch > will cause compiling failed. I looked at the prototype of device_tree_get_u32() and I can't find how it depends on bits from device_tree.h. Can you paste the compilation error? > >>> +#include >>> >>> s8 device_tree_numa = 0; >>> +static nodemask_t processor_nodes_parsed __initdata; >>> >>> -int srat_disabled(void) >>> +static int srat_disabled(void) >>> { >>> return numa_off || device_tree_numa < 0; >>> } >>> >>> -void __init bad_srat(void) >>> +static __init void bad_srat(void) >>> { >>> printk(KERN_ERR "DT: NUMA information is not used.\n"); >>> device_tree_numa = -1; >>> } >>> + >>> +/* Callback for device tree processor affinity */ >>> +static int __init dtb_numa_processor_affinity_init(nodeid_t node) >>> +{ >>> + if ( srat_disabled() ) >>> + return -EINVAL; >>> + else if ( node == NUMA_NO_NODE || node >= MAX_NUMNODES ) { >>> + bad_srat(); >>> + return -EINVAL; >>> + } >>> + >>> + node_set(node, processor_nodes_parsed); >>> + >>> + device_tree_numa = 1; >>> + printk(KERN_INFO "DT: NUMA node %u processor parsed\n", node); >>> + >>> + return 0; >>> +} >>> + >>> +/* Parse CPU NUMA node info */ >>> +int __init device_tree_parse_numa_cpu_node(const void *fdt, int node) >>> +{ >>> + uint32_t nid; >>> + >>> + nid = device_tree_get_u32(fdt, node, "numa-node-id", MAX_NUMNODES); >>> + printk(XENLOG_WARNING "CPU on NUMA node:%u\n", nid); >>> + if ( nid >= MAX_NUMNODES ) >>> + { >>> + printk(XENLOG_WARNING "Node id %u exceeds maximum value\n", >> nid); >>> + return -EINVAL; >>> + } >>> + >>> + return dtb_numa_processor_affinity_init(nid); >>> +} >>> >> >> -- >> Julien Grall Cheers, -- Julien Grall