From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5538C433F5 for ; Tue, 26 Apr 2022 15:59:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352736AbiDZQCv (ORCPT ); Tue, 26 Apr 2022 12:02:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352731AbiDZQCt (ORCPT ); Tue, 26 Apr 2022 12:02:49 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 257D816A5EE for ; Tue, 26 Apr 2022 08:59:39 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id l7so37057492ejn.2 for ; Tue, 26 Apr 2022 08:59:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=IE5WdDoFR9vCBN7dCO3EiE00nBi4kE/GvRYTPFuengA=; b=uAJmI3Pj5Ngxs35JNs0qJ/cLsAm6ZoUCdy76uRTYT9+Z1/KhgAaieAS8CSZNRJdiGC 4icruyLaS2b3j68ffd1FQii1CRcoKYiGEsi1WkjqyCQEST0CeCVJputyIDElvsb0MIvL ZZUFcuTf1rogLT79mSdLkCMMwfBd1LoMFDVRvduF9/wjNBPtaI5Ef/uK4PHTPU181ZxI JOT9lurbEVBv68bOo/IT+AKBxBBhQEktpdyCp/8MfkCZ8yhP39IUls/sfEKYogPU00+n RMi3N2n0pPksskrRF0l5AL0/Z8YSuaL9P2DmZsw3MvuYRexm3WsKL3bvIu3O4KinMIqL vhmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=IE5WdDoFR9vCBN7dCO3EiE00nBi4kE/GvRYTPFuengA=; b=5/iwoz993pK8jaoeQHlHzrgHyqExeG8mugeNY9lhvCnLhTTFwXLgrw6EzDDcnoEcDQ UsKaZMfXKK12aMTqLb5VRncxM0hAVdEAVrrDylc0zJTCMRzYRY5DBUIMPWaNGaC60XFS 0Hz0ESjwJXHZ9jTs77PginaXrFZe9MEnmKL5WadgdRGSlLnL0NQXJJepjLUuu64LqGDP DJIvS9E3dQLep7C2INCsg71vv2oh831qO9ks7AwObcHoc3ZLFu3yvZM4MEL21AdCHqS1 aiZWu3ckcs68mk8NbrpP7ylWAF9OFg7xgvz8AgHfaRg4BZ+Rig2JF/iUuV+Oy2i1ey2G Sapw== X-Gm-Message-State: AOAM533fI34aGnHJv8SIN53NnnYbL4w/vEXki1bvYEJv1loLVaz/0rsC m4m6an4gRCbcEhw7kJXZoKZFOA== X-Google-Smtp-Source: ABdhPJyD555vYRh8BhSe3kVw/JNEcQgwHjOkSDdSDmnLNaL5jq9Crlx6eOVDsZNck52443oEXklXCw== X-Received: by 2002:a17:906:7c5:b0:6e8:7c6f:4f49 with SMTP id m5-20020a17090607c500b006e87c6f4f49mr22050294ejc.378.1650988777608; Tue, 26 Apr 2022 08:59:37 -0700 (PDT) Received: from [192.168.0.252] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id q16-20020a056402519000b00425f60d7109sm1294360edd.54.2022.04.26.08.59.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Apr 2022 08:59:36 -0700 (PDT) Message-ID: <3171818a-82c2-3f29-03e4-fd2b7d8947fc@linaro.org> Date: Tue, 26 Apr 2022 17:59:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2 1/2] dt-bindings: interrupt-controller: fsl,ls-extirq: convert to YAML Content-Language: en-US To: Michael Walle Cc: Rob Herring , Krzysztof Kozlowski , Li Yang , Shawn Guo , Thomas Gleixner , Marc Zyngier , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220425140214.32448-1-michael@walle.cc> <658851ed-33fd-8e2b-7db7-ef1ca9e31c33@linaro.org> <83b596d0570c779c61c3c37c6f512679@walle.cc> <6fec63c911c88a375fc024f6ca0e946d@walle.cc> From: Krzysztof Kozlowski In-Reply-To: <6fec63c911c88a375fc024f6ca0e946d@walle.cc> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/04/2022 09:28, Michael Walle wrote: > Am 2022-04-26 08:53, schrieb Krzysztof Kozlowski: >> On 25/04/2022 23:58, Michael Walle wrote: >>>>> + reg: >>>>> + maxItems: 1 >>>>> + description: >>>>> + Specifies the Interrupt Polarity Control Register (INTPCR) in >>>>> the >>>>> + SCFG or the External Interrupt Control Register (IRQCR) in >>>>> the >>>>> ISC. >>>>> + >>>>> + interrupt-map: >>> >>> btw. >>> >>> minItems: 12 >>> maxItems: 12 >>> >>> Isn't working here, is that expected? The validator seem to get the >>> count >>> of the elements of one tuple wrong. >>> >>> I.e. >>> arch/arm64/boot/dts/freescale/fsl-ls2080a-rdb.dtb: >>> interrupt-controller@14: interrupt-map: [[0, 0, 1, 0, 0, 4, 1, 0], [1, >>> 0, 1, 4, 2, 0, 1, 0], [2, 4, 3, 0, 1, 0, 3, 4], [4, 0, 1, 0, 4, 4, 5, >>> 0], [1, 0, 5, 4, 6, 0, 1, 0], [6, 4, 7, 0, 1, 0, 7, 4], [8, 0, 1, 0, >>> 8, >>> 4, 9, 0], [1, 0, 9, 4, 10, 0, 1, 0], [10, 4, 11, 0, 1, 0, 11, 4]] is >>> too >>> short >> >> >> Works for me (in different schema)... maybe update your dtschema? > > Just updated to the latest one. But I'm still getting the same errors. > > $ dt-validate -V > 2022.4 > > /home/mwalle/repos/b-linux-arm64/arch/arm64/boot/dts/freescale/fsl-ls1088a-qds.dtb: > interrupt-controller@14: interrupt-map: [[0, 0, 1, 0, 0, 4, 1, 0], [1, > 0, 1, 4, 2, 0, 1, 0], [2, 4, 3, 0, 1, 0, 3, 4], [4, 0, 1, 0, 4, 4, 5, > 0], [1, 0, 5, 4, 6, 0, 1, 0], [6, 4, 7, 0, 1, 0, 7, 4], [8, 0, 1, 0, 8, > 4, 9, 0], [1, 0, 9, 4, 10, 0, 1, 0], [10, 4, 11, 0, 1, 0, 11, 4]] is too > short > From schema: > /home/mwalle/repos/linux-mw/Documentation/devicetree/bindings/interrupt-controller/fsl,ls-extirq.yaml > > How is the length of one entry calculated? If you add maxItems to your original v2 binding example, it works. If you replace your example with ls1088a and use maxItems:12, it works. So maybe something is wrong in your modified patch (which we do not have so we cannot test it)? Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C74CBC433F5 for ; Tue, 26 Apr 2022 16:00:17 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Knmmw1ysZz3brQ for ; Wed, 27 Apr 2022 02:00:16 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=uAJmI3Pj; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linaro.org (client-ip=2a00:1450:4864:20::62e; helo=mail-ej1-x62e.google.com; envelope-from=krzysztof.kozlowski@linaro.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=uAJmI3Pj; dkim-atps=neutral Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4KnmmD5jJHz2xBk for ; Wed, 27 Apr 2022 01:59:40 +1000 (AEST) Received: by mail-ej1-x62e.google.com with SMTP id l7so37057493ejn.2 for ; Tue, 26 Apr 2022 08:59:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=IE5WdDoFR9vCBN7dCO3EiE00nBi4kE/GvRYTPFuengA=; b=uAJmI3Pj5Ngxs35JNs0qJ/cLsAm6ZoUCdy76uRTYT9+Z1/KhgAaieAS8CSZNRJdiGC 4icruyLaS2b3j68ffd1FQii1CRcoKYiGEsi1WkjqyCQEST0CeCVJputyIDElvsb0MIvL ZZUFcuTf1rogLT79mSdLkCMMwfBd1LoMFDVRvduF9/wjNBPtaI5Ef/uK4PHTPU181ZxI JOT9lurbEVBv68bOo/IT+AKBxBBhQEktpdyCp/8MfkCZ8yhP39IUls/sfEKYogPU00+n RMi3N2n0pPksskrRF0l5AL0/Z8YSuaL9P2DmZsw3MvuYRexm3WsKL3bvIu3O4KinMIqL vhmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=IE5WdDoFR9vCBN7dCO3EiE00nBi4kE/GvRYTPFuengA=; b=KKh0O1ZVk4Ish5oNwkb8MLdpyR4QqF7HhBUxEne7RXxnK8hEDmYSawSHNepvM4BtaJ jYyrBKqxCGA1s1X9pOVIw8adCPbh8FhaIo4iB7ASpI43kL4gDmdziM8XVEAFWmZLGxfP JHIEYNFVOJinxDFeU34j0/IWxxeueywjpBGcjhsnNIIXMf4ZIlG6lAUEnk3qZ2Yn02DK GSw68QC4Rv2DCeepB6y3hHzJ4HsNacOP2fhctcqaY+neuyZzXaQUmBj3CbufUEr+kyDK dDtSsitlpP2WyzPiAvnu7WrIq1lakWGFb8mVoagiUKDHKGfSpD9b/4MMRIK4L0lSDK2f valw== X-Gm-Message-State: AOAM5314HHhQH9/n6LvS29Cf7lcDmW3nwhAExCKx5vfDQ/se0BReKgun enFGGJeV5LSbHGFqHXivyoc6Rw== X-Google-Smtp-Source: ABdhPJyD555vYRh8BhSe3kVw/JNEcQgwHjOkSDdSDmnLNaL5jq9Crlx6eOVDsZNck52443oEXklXCw== X-Received: by 2002:a17:906:7c5:b0:6e8:7c6f:4f49 with SMTP id m5-20020a17090607c500b006e87c6f4f49mr22050294ejc.378.1650988777608; Tue, 26 Apr 2022 08:59:37 -0700 (PDT) Received: from [192.168.0.252] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id q16-20020a056402519000b00425f60d7109sm1294360edd.54.2022.04.26.08.59.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Apr 2022 08:59:36 -0700 (PDT) Message-ID: <3171818a-82c2-3f29-03e4-fd2b7d8947fc@linaro.org> Date: Tue, 26 Apr 2022 17:59:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2 1/2] dt-bindings: interrupt-controller: fsl, ls-extirq: convert to YAML Content-Language: en-US To: Michael Walle References: <20220425140214.32448-1-michael@walle.cc> <658851ed-33fd-8e2b-7db7-ef1ca9e31c33@linaro.org> <83b596d0570c779c61c3c37c6f512679@walle.cc> <6fec63c911c88a375fc024f6ca0e946d@walle.cc> From: Krzysztof Kozlowski In-Reply-To: <6fec63c911c88a375fc024f6ca0e946d@walle.cc> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Marc Zyngier , linuxppc-dev@lists.ozlabs.org, Li Yang , Rob Herring , Krzysztof Kozlowski , Thomas Gleixner , Shawn Guo , linux-arm-kernel@lists.infradead.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 26/04/2022 09:28, Michael Walle wrote: > Am 2022-04-26 08:53, schrieb Krzysztof Kozlowski: >> On 25/04/2022 23:58, Michael Walle wrote: >>>>> + reg: >>>>> + maxItems: 1 >>>>> + description: >>>>> + Specifies the Interrupt Polarity Control Register (INTPCR) in >>>>> the >>>>> + SCFG or the External Interrupt Control Register (IRQCR) in >>>>> the >>>>> ISC. >>>>> + >>>>> + interrupt-map: >>> >>> btw. >>> >>> minItems: 12 >>> maxItems: 12 >>> >>> Isn't working here, is that expected? The validator seem to get the >>> count >>> of the elements of one tuple wrong. >>> >>> I.e. >>> arch/arm64/boot/dts/freescale/fsl-ls2080a-rdb.dtb: >>> interrupt-controller@14: interrupt-map: [[0, 0, 1, 0, 0, 4, 1, 0], [1, >>> 0, 1, 4, 2, 0, 1, 0], [2, 4, 3, 0, 1, 0, 3, 4], [4, 0, 1, 0, 4, 4, 5, >>> 0], [1, 0, 5, 4, 6, 0, 1, 0], [6, 4, 7, 0, 1, 0, 7, 4], [8, 0, 1, 0, >>> 8, >>> 4, 9, 0], [1, 0, 9, 4, 10, 0, 1, 0], [10, 4, 11, 0, 1, 0, 11, 4]] is >>> too >>> short >> >> >> Works for me (in different schema)... maybe update your dtschema? > > Just updated to the latest one. But I'm still getting the same errors. > > $ dt-validate -V > 2022.4 > > /home/mwalle/repos/b-linux-arm64/arch/arm64/boot/dts/freescale/fsl-ls1088a-qds.dtb: > interrupt-controller@14: interrupt-map: [[0, 0, 1, 0, 0, 4, 1, 0], [1, > 0, 1, 4, 2, 0, 1, 0], [2, 4, 3, 0, 1, 0, 3, 4], [4, 0, 1, 0, 4, 4, 5, > 0], [1, 0, 5, 4, 6, 0, 1, 0], [6, 4, 7, 0, 1, 0, 7, 4], [8, 0, 1, 0, 8, > 4, 9, 0], [1, 0, 9, 4, 10, 0, 1, 0], [10, 4, 11, 0, 1, 0, 11, 4]] is too > short > From schema: > /home/mwalle/repos/linux-mw/Documentation/devicetree/bindings/interrupt-controller/fsl,ls-extirq.yaml > > How is the length of one entry calculated? If you add maxItems to your original v2 binding example, it works. If you replace your example with ls1088a and use maxItems:12, it works. So maybe something is wrong in your modified patch (which we do not have so we cannot test it)? Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1123C433EF for ; Tue, 26 Apr 2022 16:00:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=x3EtLob09dZsrRfMBRV3vquJQ5QQeiBTKdI1YGRn9Oc=; b=NihuPUtR1iQseD 7yqwa/hq4Mas+iTLLe4oTeUPVZsJyhCq9l/wxMz9g1DlUKaj0L4uUl8r/50GxHOKXyouNfRYkGYxZ jFdVrPHUKc9Vsdz9C7xwngDr43+0CD7BfhleIevPgM7J2EHC0QKYx897WxRFepxAOVEbAqYZePpJd I+/VQvyGs1Entb4KnyscXolbJi1cVIpzQE2O15pGAnR1yVwMxJLpKLn6/8B+U2zL/UVTBrCItEvps UtaaVjsyUAFxya+K36YCN8LqA2C5lIw+8Mwg+7uFQkdh8pNPqROz6x3nZ7bNwuUlHD+ZqMXBast5l 7U7gKfM7nDR5JP9pn8eg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1njNbO-00FFDO-68; Tue, 26 Apr 2022 15:59:46 +0000 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1njNbK-00FFAv-4P for linux-arm-kernel@lists.infradead.org; Tue, 26 Apr 2022 15:59:43 +0000 Received: by mail-ej1-x62b.google.com with SMTP id g6so14172771ejw.1 for ; Tue, 26 Apr 2022 08:59:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=IE5WdDoFR9vCBN7dCO3EiE00nBi4kE/GvRYTPFuengA=; b=uAJmI3Pj5Ngxs35JNs0qJ/cLsAm6ZoUCdy76uRTYT9+Z1/KhgAaieAS8CSZNRJdiGC 4icruyLaS2b3j68ffd1FQii1CRcoKYiGEsi1WkjqyCQEST0CeCVJputyIDElvsb0MIvL ZZUFcuTf1rogLT79mSdLkCMMwfBd1LoMFDVRvduF9/wjNBPtaI5Ef/uK4PHTPU181ZxI JOT9lurbEVBv68bOo/IT+AKBxBBhQEktpdyCp/8MfkCZ8yhP39IUls/sfEKYogPU00+n RMi3N2n0pPksskrRF0l5AL0/Z8YSuaL9P2DmZsw3MvuYRexm3WsKL3bvIu3O4KinMIqL vhmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=IE5WdDoFR9vCBN7dCO3EiE00nBi4kE/GvRYTPFuengA=; b=gvp34EJAam4Jq5obJr1Q2f9jMSeEBqn28dlfS4tgvZFFyQjyZA60FFrkx4BFhitgYs n85v0WSVdwV4aKFZ9f9blf5Gl6H6/Z6UTu236Cp8dyC09Pj+JA07W9vrYlFZq/uANW+c 3qy9RctYYJ5qRFpM+fcqdFfddbdFsJZDx+t8+KKYPhs2xkvAuoZK59qGIepWrcbebD5Z hXtoUCTupcLpSgvxlow1yi+B0w8JS676b8f9Kx6PUqPil6QUXhT+zM3YZ7JSy/GE8tBf EMvhz8EQYWaw2LSpnbfZiEykI+7eNaWGkqQmwj29ddK0mR84fvp9ppXRi0TDM/sspYU4 kzDw== X-Gm-Message-State: AOAM530p5EXDLrArMaH/QGwRJm3RE9UHKDNFddjZno5l0edsqP3J3Kjd ZYzGIgMi8I5sXDtF+wPjuClsFA== X-Google-Smtp-Source: ABdhPJyD555vYRh8BhSe3kVw/JNEcQgwHjOkSDdSDmnLNaL5jq9Crlx6eOVDsZNck52443oEXklXCw== X-Received: by 2002:a17:906:7c5:b0:6e8:7c6f:4f49 with SMTP id m5-20020a17090607c500b006e87c6f4f49mr22050294ejc.378.1650988777608; Tue, 26 Apr 2022 08:59:37 -0700 (PDT) Received: from [192.168.0.252] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id q16-20020a056402519000b00425f60d7109sm1294360edd.54.2022.04.26.08.59.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Apr 2022 08:59:36 -0700 (PDT) Message-ID: <3171818a-82c2-3f29-03e4-fd2b7d8947fc@linaro.org> Date: Tue, 26 Apr 2022 17:59:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2 1/2] dt-bindings: interrupt-controller: fsl, ls-extirq: convert to YAML Content-Language: en-US To: Michael Walle Cc: Rob Herring , Krzysztof Kozlowski , Li Yang , Shawn Guo , Thomas Gleixner , Marc Zyngier , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220425140214.32448-1-michael@walle.cc> <658851ed-33fd-8e2b-7db7-ef1ca9e31c33@linaro.org> <83b596d0570c779c61c3c37c6f512679@walle.cc> <6fec63c911c88a375fc024f6ca0e946d@walle.cc> From: Krzysztof Kozlowski In-Reply-To: <6fec63c911c88a375fc024f6ca0e946d@walle.cc> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220426_085942_229442_8C55F325 X-CRM114-Status: GOOD ( 15.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 26/04/2022 09:28, Michael Walle wrote: > Am 2022-04-26 08:53, schrieb Krzysztof Kozlowski: >> On 25/04/2022 23:58, Michael Walle wrote: >>>>> + reg: >>>>> + maxItems: 1 >>>>> + description: >>>>> + Specifies the Interrupt Polarity Control Register (INTPCR) in >>>>> the >>>>> + SCFG or the External Interrupt Control Register (IRQCR) in >>>>> the >>>>> ISC. >>>>> + >>>>> + interrupt-map: >>> >>> btw. >>> >>> minItems: 12 >>> maxItems: 12 >>> >>> Isn't working here, is that expected? The validator seem to get the >>> count >>> of the elements of one tuple wrong. >>> >>> I.e. >>> arch/arm64/boot/dts/freescale/fsl-ls2080a-rdb.dtb: >>> interrupt-controller@14: interrupt-map: [[0, 0, 1, 0, 0, 4, 1, 0], [1, >>> 0, 1, 4, 2, 0, 1, 0], [2, 4, 3, 0, 1, 0, 3, 4], [4, 0, 1, 0, 4, 4, 5, >>> 0], [1, 0, 5, 4, 6, 0, 1, 0], [6, 4, 7, 0, 1, 0, 7, 4], [8, 0, 1, 0, >>> 8, >>> 4, 9, 0], [1, 0, 9, 4, 10, 0, 1, 0], [10, 4, 11, 0, 1, 0, 11, 4]] is >>> too >>> short >> >> >> Works for me (in different schema)... maybe update your dtschema? > > Just updated to the latest one. But I'm still getting the same errors. > > $ dt-validate -V > 2022.4 > > /home/mwalle/repos/b-linux-arm64/arch/arm64/boot/dts/freescale/fsl-ls1088a-qds.dtb: > interrupt-controller@14: interrupt-map: [[0, 0, 1, 0, 0, 4, 1, 0], [1, > 0, 1, 4, 2, 0, 1, 0], [2, 4, 3, 0, 1, 0, 3, 4], [4, 0, 1, 0, 4, 4, 5, > 0], [1, 0, 5, 4, 6, 0, 1, 0], [6, 4, 7, 0, 1, 0, 7, 4], [8, 0, 1, 0, 8, > 4, 9, 0], [1, 0, 9, 4, 10, 0, 1, 0], [10, 4, 11, 0, 1, 0, 11, 4]] is too > short > From schema: > /home/mwalle/repos/linux-mw/Documentation/devicetree/bindings/interrupt-controller/fsl,ls-extirq.yaml > > How is the length of one entry calculated? If you add maxItems to your original v2 binding example, it works. If you replace your example with ls1088a and use maxItems:12, it works. So maybe something is wrong in your modified patch (which we do not have so we cannot test it)? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel