From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 305B0C433DB for ; Thu, 4 Feb 2021 13:20:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D222964F53 for ; Thu, 4 Feb 2021 13:20:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236161AbhBDNUJ (ORCPT ); Thu, 4 Feb 2021 08:20:09 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:12028 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236029AbhBDNUI (ORCPT ); Thu, 4 Feb 2021 08:20:08 -0500 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4DWfHg4mdLzjJM0; Thu, 4 Feb 2021 21:18:07 +0800 (CST) Received: from [127.0.0.1] (10.69.38.196) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.498.0; Thu, 4 Feb 2021 21:19:20 +0800 Subject: Re: [PATCH] PCI: Use subdir-ccflags-* to inherit debug flag To: =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= CC: , , , References: <1612438215-33105-1-git-send-email-yangyicong@hisilicon.com> From: Yicong Yang Message-ID: <3171ed82-c114-2298-1c03-f7c854fb15c0@hisilicon.com> Date: Thu, 4 Feb 2021 21:19:20 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.69.38.196] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On 2021/2/4 20:28, Krzysztof Wilczyński wrote: > Hi Yicong, > > Thank you for taking care of this! > > By the way, did you have some issues with things like pr_debug() and other > things printing debug information not working correctly before? i cannot remember that i have met any, so maybe they work properly. :) > > On 21-02-04 19:30:15, Yicong Yang wrote: >> From: Junhao He >> >> Use subdir-ccflags-* instead of ccflags-* to inherit the debug >> settings from Kconfig when traversing subdirectories. >> >> Signed-off-by: Junhao He >> Signed-off-by: Yicong Yang >> --- >> drivers/pci/Makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/pci/Makefile b/drivers/pci/Makefile >> index 11cc794..d62c4ac 100644 >> --- a/drivers/pci/Makefile >> +++ b/drivers/pci/Makefile >> @@ -36,4 +36,4 @@ obj-$(CONFIG_PCI_ENDPOINT) += endpoint/ >> obj-y += controller/ >> obj-y += switch/ >> >> -ccflags-$(CONFIG_PCI_DEBUG) := -DDEBUG >> +subdir-ccflags-$(CONFIG_PCI_DEBUG) := -DDEBUG >> -- >> 2.8.1 > > Reviewed-by: Krzysztof Wilczyński > > Krzysztof > > . >