From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH 2/3] IOMMU/x86: make page type checks consistent when mapping pages Date: Mon, 13 May 2019 14:44:10 +0100 Message-ID: <3172ee3f-0800-99a5-e148-d10ecdfd51a8@citrix.com> References: <5C7E77D1020000780021BB0B@prv1-mh.provo.novell.com> <5C7E78F6020000780021BB21@prv1-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hQBFY-0003v4-5Y for xen-devel@lists.xenproject.org; Mon, 13 May 2019 13:44:16 +0000 In-Reply-To: <5C7E78F6020000780021BB21@prv1-mh.provo.novell.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Jan Beulich , xen-devel Cc: George Dunlap , Andrew Cooper , Juergen Gross List-Id: xen-devel@lists.xenproject.org T24gMy81LzE5IDE6MjYgUE0sIEphbiBCZXVsaWNoIHdyb3RlOgo+IFRoZXJlIGFyZSBjdXJyZW50 bHkgdGhyZWUgbW9yZSBvciBsZXNzIGRpZmZlcmVudCBjaGVja3M6Cj4gLSBfZ2V0X3BhZ2VfdHlw ZSgpIGFkanVzdHMgdGhlIElPTU1VIG1hcHBpbmdzIGFjY29yZGluZyB0byB0aGUgbmV3IHR5cGUK PiAgIGFsb25lLAo+IC0gYXJjaF9pb21tdV9wb3B1bGF0ZV9wYWdlX3RhYmxlKCkgd2FudHMganVz dCB0aGUgdHlwZSB0byBiZQo+ICAgUEdUX3dyaXRhYmxlX3BhZ2UsCj4gLSBpb21tdV9od2RvbV9p bml0KCkgYWRkaXRpb25hbGx5IHBlcm1pdHMgYWxsIG90aGVyIHR5cGVzIHdpdGggYSB0eXBlCj4g ICByZWZjb3VudCBvZiB6ZXJvLgo+IFRoZSBjYW5vbmljYWwgb25lIGlzIGluIF9nZXRfcGFnZV90 eXBlKCksIGFuZCBhcyBvZiBYU0EtMjg4Cj4gYXJjaF9pb21tdV9wb3B1bGF0ZV9wYWdlX3RhYmxl KCkgYWxzbyBoYXMgbm8gbmVlZCBhbnltb3JlIHRvIGRlYWwgd2l0aAo+IFBHVF9ub25lIHBhZ2Vz LiBJbiB0aGUgUFYgRG9tMCBjYXNlLCBob3dldmVyLCBQR1Rfbm9uZSBwYWdlcyBhcmUgc3RpbGwK PiBuZWNlc3NhcnkgdG8gY29uc2lkZXIsIHNpbmNlIGluIHRoYXQgY2FzZSBwYWdlcyBkb24ndCBn ZXQgaGFuZGVkIHRvCj4gZ3Vlc3RfcGh5c21hcF9hZGRfZW50cnkoKS4gRnVydGhlcm1vcmUsIHRo ZSBmdW5jdGlvbiBzbyBmYXIgYWxzbwo+IGVzdGFibGlzaGVkIHIvbyBtYXBwaW5ncywgd2hpY2gg aXMgbm90IGluIGxpbmUgd2l0aCB0aGUgcnVsZXMgc2V0IGZvcnRoCj4gYnkgdGhlIFhTQS0yODgg Y2hhbmdlLgo+IAo+IEZvciBhcmNoX2lvbW11X3BvcHVsYXRlX3BhZ2VfdGFibGUoKSB0byBub3Qg ZW5jb3VudGVyIFBHVF9ub25lIHBhZ2VzCj4gYW55bW9yZSBldmVuIGluIGNhc2VzIHdoZXJlIHRo ZSBJT01NVSBnZXRzIGVuYWJsZWQgZm9yIGEgZG9tYWluIG9ubHkKPiB3aGVuIGl0IGlzIGFscmVh ZHkgcnVubmluZywgcmVwbGFjZSB0aGUgSU9NTVUgZGVwZW5kZW5jeSBpbgo+IGd1ZXN0X3BoeXNt YXBfYWRkX2VudHJ5KCkncyBoYW5kbGluZyBvZiBQViBndWVzdHMgdG8gY2hlY2sganVzdCB0aGUK PiBzeXN0ZW0gd2lkZSBzdGF0ZSBpbnN0ZWFkIG9mIHRoZSBkb21haW4gcHJvcGVydHkuCj4gCj4g U2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgo+IAo+IC0tLSBh L3hlbi9hcmNoL3g4Ni9tbS9wMm0uYwo+ICsrKyBiL3hlbi9hcmNoL3g4Ni9tbS9wMm0uYwo+IEBA IC04MzcsMTEgKzgzNywxMSBAQCBndWVzdF9waHlzbWFwX2FkZF9lbnRyeShzdHJ1Y3QgZG9tYWlu ICpkCj4gICAgICAgICAgICoKPiAgICAgICAgICAgKiBSZXRhaW4gdGhpcyBwcm9wZXJ0eSBieSBn cmFiYmluZyBhIHdyaXRhYmxlIHR5cGUgcmVmIGFuZCB0aGVuCj4gICAgICAgICAgICogZHJvcHBp bmcgaXQgaW1tZWRpYXRlbHkuICBUaGUgcmVzdWx0IHdpbGwgYmUgcGFnZXMgdGhhdCBoYXZlIGEK PiAtICAgICAgICAgKiB3cml0YWJsZSB0eXBlIChhbmQgYW4gSU9NTVUgZW50cnkpLCBidXQgYSBj b3VudCBvZiAwIChzdWNoIHRoYXQKPiAtICAgICAgICAgKiBhbnkgZ3Vlc3QtcmVxdWVzdGVkIHR5 cGUgY2hhbmdlcyBzdWNjZWVkIGFuZCByZW1vdmUgdGhlIElPTU1VCj4gLSAgICAgICAgICogZW50 cnkpLgo+ICsgICAgICAgICAqIHdyaXRhYmxlIHR5cGUgKGFuZCBhbiBJT01NVSBlbnRyeSBpZiBu ZWNlc3NhcnkpLCBidXQgYSBjb3VudCBvZiAwCj4gKyAgICAgICAgICogKHN1Y2ggdGhhdCBhbnkg Z3Vlc3QtcmVxdWVzdGVkIHR5cGUgY2hhbmdlcyBzdWNjZWVkIGFuZCByZW1vdmUgdGhlCj4gKyAg ICAgICAgICogSU9NTVUgZW50cnkpLgo+ICAgICAgICAgICAqLwo+IC0gICAgICAgIGlmICggIW5l ZWRfaW9tbXVfcHRfc3luYyhkKSB8fCB0ICE9IHAybV9yYW1fcncgKQo+ICsgICAgICAgIGlmICgg IWlvbW11X2VuYWJsZWQgfHwgdCAhPSBwMm1fcmFtX3J3ICkKPiAgICAgICAgICAgICAgcmV0dXJu IDA7CgpUaGlzIGxvb2tzIGdvb2QuICBPbmUgcXVlc3Rpb24gYWJvdXQgdGhlIG5leHQgb25lLi4u Cgo+ICAKPiAgICAgICAgICBmb3IgKCBpID0gMDsgaSA8ICgxVUwgPDwgcGFnZV9vcmRlcik7ICsr aSwgKytwYWdlICkKPiAtLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9pb21tdS5jCj4gKysr IGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvaW9tbXUuYwo+IEBAIC0xOTIsMjEgKzE5MiwyNyBA QCB2b2lkIF9faHdkb21faW5pdCBpb21tdV9od2RvbV9pbml0KHN0cnVjCj4gIAo+ICAgICAgICAg IHBhZ2VfbGlzdF9mb3JfZWFjaCAoIHBhZ2UsICZkLT5wYWdlX2xpc3QgKQo+ICAgICAgICAgIHsK PiAtICAgICAgICAgICAgdW5zaWduZWQgbG9uZyBtZm4gPSBtZm5feChwYWdlX3RvX21mbihwYWdl KSk7Cj4gLSAgICAgICAgICAgIHVuc2lnbmVkIGxvbmcgZGZuID0gbWZuX3RvX2dtZm4oZCwgbWZu KTsKPiAtICAgICAgICAgICAgdW5zaWduZWQgaW50IG1hcHBpbmcgPSBJT01NVUZfcmVhZGFibGU7 Cj4gLSAgICAgICAgICAgIGludCByZXQ7Cj4gKyAgICAgICAgICAgIGlmICggKHBhZ2UtPnUuaW51 c2UudHlwZV9pbmZvICYgUEdUX3R5cGVfbWFzaykgPT0gUEdUX25vbmUgKQo+ICsgICAgICAgICAg ICB7Cj4gKyAgICAgICAgICAgICAgICBBU1NFUlQoIShwYWdlLT51LmludXNlLnR5cGVfaW5mbyAm IFBHVF9jb3VudF9tYXNrKSk7Cj4gKyAgICAgICAgICAgICAgICBpZiAoIGdldF9wYWdlX2FuZF90 eXBlKHBhZ2UsIGQsIFBHVF93cml0YWJsZV9wYWdlKSApCj4gKyAgICAgICAgICAgICAgICAgICAg cHV0X3BhZ2VfYW5kX3R5cGUocGFnZSk7Cj4gKyAgICAgICAgICAgICAgICBlbHNlIGlmICggIXJj ICkKPiArICAgICAgICAgICAgICAgICAgICByYyA9IC1FQlVTWTsKPiArICAgICAgICAgICAgfQo+ ICAKPiAtICAgICAgICAgICAgaWYgKCAoKHBhZ2UtPnUuaW51c2UudHlwZV9pbmZvICYgUEdUX2Nv dW50X21hc2spID09IDApIHx8Cj4gLSAgICAgICAgICAgICAgICAgKChwYWdlLT51LmludXNlLnR5 cGVfaW5mbyAmIFBHVF90eXBlX21hc2spCj4gLSAgICAgICAgICAgICAgICAgID09IFBHVF93cml0 YWJsZV9wYWdlKSApCj4gLSAgICAgICAgICAgICAgICBtYXBwaW5nIHw9IElPTU1VRl93cml0YWJs ZTsKPiArICAgICAgICAgICAgaWYgKCAoKHBhZ2UtPnUuaW51c2UudHlwZV9pbmZvICYgUEdUX3R5 cGVfbWFzaykgPT0KPiArICAgICAgICAgICAgICAgICAgUEdUX3dyaXRhYmxlX3BhZ2UpICkKPiAr ICAgICAgICAgICAgewo+ICsgICAgICAgICAgICAgICAgdW5zaWduZWQgbG9uZyBtZm4gPSBtZm5f eChwYWdlX3RvX21mbihwYWdlKSk7Cj4gKyAgICAgICAgICAgICAgICB1bnNpZ25lZCBsb25nIGRm biA9IG1mbl90b19nbWZuKGQsIG1mbik7Cj4gKyAgICAgICAgICAgICAgICBpbnQgcmV0ID0gaW9t bXVfbWFwKGQsIF9kZm4oZGZuKSwgX21mbihtZm4pLCAwLAo+ICsgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBJT01NVUZfcmVhZGFibGUgfCBJT01NVUZfd3JpdGFibGUsCj4gKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZmbHVzaF9mbGFncyk7CgpXaGF0J3Mg dGhlIGlkZWEgYmVoaW5kIGNhbGxpbmcgaW9tbXVfbWFwKCkgaGVyZSwgcmF0aGVyIHRoYW4gcmVs eWluZyBvbgp0aGUgb25lIGluIF9nZXRfcGFnZV90eXBlKCk/ICBEb2VzIG5lZWRfaW9tbXVfcHRf c3luYygpIG5vdCB3b3JrIHlldCBhdAp0aGlzIHBvaW50LCBvciBkbyB5b3UgZXhwZWN0IHRoZXJl IHRvIGJlIHBhZ2VzIHRoYXQgaGF2ZSBiZWVuIG1hcmtlZApQR1Rfd3JpdGFibGUgd2l0aG91dCBo YXZpbmcgZ29uZSB0aHJvdWdoIF9nZXRfcGFnZV90eXBlKCk/CgogLUdlb3JnZQoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcg bGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9q ZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12F4EC04AA7 for ; Mon, 13 May 2019 13:44:30 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E2B9C20879 for ; Mon, 13 May 2019 13:44:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E2B9C20879 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hQBFZ-0003v9-B1; Mon, 13 May 2019 13:44:17 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hQBFY-0003v4-5Y for xen-devel@lists.xenproject.org; Mon, 13 May 2019 13:44:16 +0000 X-Inumbo-ID: 315b015a-7585-11e9-9c80-533ef3084ef6 Received: from SMTP03.CITRIX.COM (unknown [162.221.156.55]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 315b015a-7585-11e9-9c80-533ef3084ef6; Mon, 13 May 2019 13:44:13 +0000 (UTC) X-IronPort-AV: E=Sophos;i="5.60,465,1549929600"; d="scan'208";a="85387390" To: Jan Beulich , xen-devel References: <5C7E77D1020000780021BB0B@prv1-mh.provo.novell.com> <5C7E78F6020000780021BB21@prv1-mh.provo.novell.com> From: George Dunlap Openpgp: preference=signencrypt Autocrypt: addr=george.dunlap@citrix.com; prefer-encrypt=mutual; keydata= mQINBFPqG+MBEACwPYTQpHepyshcufo0dVmqxDo917iWPslB8lauFxVf4WZtGvQSsKStHJSj 92Qkxp4CH2DwudI8qpVbnWCXsZxodDWac9c3PordLwz5/XL41LevEoM3NWRm5TNgJ3ckPA+J K5OfSK04QtmwSHFP3G/SXDJpGs+oDJgASta2AOl9vPV+t3xG6xyfa2NMGn9wmEvvVMD44Z7R W3RhZPn/NEZ5gaJhIUMgTChGwwWDOX0YPY19vcy5fT4bTIxvoZsLOkLSGoZb/jHIzkAAznug Q7PPeZJ1kXpbW9EHHaUHiCD9C87dMyty0N3TmWfp0VvBCaw32yFtM9jUgB7UVneoZUMUKeHA fgIXhJ7I7JFmw3J0PjGLxCLHf2Q5JOD8jeEXpdxugqF7B/fWYYmyIgwKutiGZeoPhl9c/7RE Bf6f9Qv4AtQoJwtLw6+5pDXsTD5q/GwhPjt7ohF7aQZTMMHhZuS52/izKhDzIufl6uiqUBge 0lqG+/ViLKwCkxHDREuSUTtfjRc9/AoAt2V2HOfgKORSCjFC1eI0+8UMxlfdq2z1AAchinU0 eSkRpX2An3CPEjgGFmu2Je4a/R/Kd6nGU8AFaE8ta0oq5BSFDRYdcKchw4TSxetkG6iUtqOO ZFS7VAdF00eqFJNQpi6IUQryhnrOByw+zSobqlOPUO7XC5fjnwARAQABtCRHZW9yZ2UgVy4g RHVubGFwIDxkdW5sYXBnQHVtaWNoLmVkdT6JAlcEEwEKAEECGwMFCwkIBwMFFQoJCAsFFgID AQACHgECF4ACGQEWIQTXqBy2bTNXPzpOYFimNjwxBZC0bQUCXEowWQUJDCJ7dgAKCRCmNjwx BZC0beKvEACJ75YlJXd7TnNHgFyiCJkm/qPeoQ3sFGSDZuZh7SKcdt9+3V2bFEb0Mii1hQaz 3hRqZb8sYPHJrGP0ljK09k3wf8k3OuNxziLQBJyzvn7WNlE4wBEcy/Ejo9TVBdA4ph5D0YaZ nqdsPmxe/xlTFuSkgu4ep1v9dfVP1TQR0e+JIBa/Ss+cKC5intKm+8JxpOploAHuzaPu0L/X FapzsIXqgT9eIQeBEgO2hge6h9Jov3WeED/vh8kA7f8c6zQ/gs5E7VGALwsiLrhr0LZFcKcw kI3oCCrB/C/wyPZv789Ra8EXbeRSJmTjcnBwHRPjnjwQmetRDD1t+VyrkC6uujT5jmgOBzaj KCqZ8PcMAssOzdzQtKmjUQ2b3ICPs2X13xZ5M5/OVs1W3TG5gkvMh4YoHi4ilFnOk+v3/j7q 65FG6N0JLb94Ndi80HkIOQQ1XVGTyu6bUPaBg3rWK91Csp1682kD/dNVF3FKHrRLmSVtmEQR 5rK0+VGc/FmR6vd4haKGWIRuPxzg+pBR77avIZpU7C7+UXGuZ5CbHwIdY8LojJg2TuUdqaVj yxmEZLOA8rVHipCGrslRNthVbJrGN/pqtKjCClFZHIAYJQ9EGLHXLG9Pj76opfjHij3MpR3o pCGAh6KsCrfrsvjnpDwqSbngGyEVH030irSk4SwIqZ7FwLkBDQRUWmc6AQgAzpc8Ng5Opbrh iZrn69Xr3js28p+b4a+0BOvC48NfrNovZw4eFeKIzmI/t6EkJkSqBIxobWRpBkwGweENsqnd 0qigmsDw4N7J9Xx0h9ARDqiWxX4jr7u9xauI+CRJ1rBNO3VV30QdACwQ4LqhR/WA+IjdhyMH wj3EJGE61NdP/h0zfaLYAbvEg47/TPThFsm4m8Rd6bX7RkrrOgBbL/AOnYOMEivyfZZKX1vv iEemAvLfdk2lZt7Vm6X/fbKbV8tPUuZELzNedJvTTBS3/l1FVz9OUcLDeWhGEdlxqXH0sYWh E9+PXTAfz5JxKH+LMetwEM8DbuOoDIpmIGZKrZ+2fQARAQABiQNbBBgBCgAmAhsCFiEE16gc tm0zVz86TmBYpjY8MQWQtG0FAlxKMJ4FCQnQ/OQBKcBdIAQZAQoABgUCVFpnOgAKCRCyFcen x4Qb7cXrCAC0qQeEWmLa9oEAPa+5U6wvG1t/mi22gZN6uzQXH1faIOoDehr7PPESE6tuR/vI CTTnaSrd4UDPNeqOqVF07YexWD1LDcQG6PnRqC5DIX1RGE3BaSaMl2pFJP8y+chews11yP8G DBbxaIsTcHZI1iVIC9XLhoeegWi84vYc8F4ziADVfowbmbvcVw11gE8tmALCwTeBeZVteXjh 0OELHwrc1/4j4yvENjIXRO+QLIgk43kB57Upr4tP2MEcs0odgPM+Q+oETOJ00xzLgkTnLPim C1FIW2bOZdTj+Uq6ezRS2LKsNmW+PRRvNyA5ojEbA/faxmAjMZtLdSSSeFK8y4SoCRCmNjwx BZC0bevWEACRu+GyQgrdGmorUptniIeO1jQlpTiP5WpVnk9Oe8SiLoXUhXXNj6EtzyLGpYmf kEAbki+S6WAKnzZd3shL58AuMyDxtFNNjNeKJOcl6FL7JPBIIgIp3wR401Ep+/s5pl3Nw8Ii 157f0T7o8CPb54w6S1WsMkU78WzTxIs/1lLblSMcvyz1Jq64g4OqiWI85JfkzPLlloVf1rzy ebIBLrrmjhCE2tL1RONpE/KRVb+Q+PIs5+YcZ+Q1e0vXWA7NhTWFbWx3+N6WW6gaGpbFbopo FkYRpj+2TA5cX5zW148/xU5/ATEb5vdUkFLUFVy5YNUSyeBHuaf6fGmBrDc47rQjAOt1rmyD 56MUBHpLUbvA6NkPezb7T6bQpupyzGRkMUmSwHiLyQNJQhVe+9NiJJvtEE3jol0JVJoQ9WVn FAzPNCgHQyvbsIF3gYkCYKI0w8EhEoH5FHYLoKS6Jg880IY5rXzoAEfPvLXegy6mhYl+mNVN QUBD4h9XtOvcdzR559lZuC0Ksy7Xqw3BMolmKsRO3gWKhXSna3zKl4UuheyZtubVWoNWP/bn vbyiYnLwuiKDfNAinEWERC8nPKlv3PkZw5d3t46F1Dx0TMf16NmP+azsRpnMZyzpY8BL2eur feSGAOB9qjZNyzbo5nEKHldKWCKE7Ye0EPEjECS1gjKDwbkBDQRUWrq9AQgA7aJ0i1pQSmUR 6ZXZD2YEDxia2ByR0uZoTS7N0NYv1OjU8v6p017u0Fco5+Qoju/fZ97ScHhp5xGVAk5kxZBF DT4ovJd0nIeSr3bbWwfNzGx1waztfdzXt6n3MBKr7AhioB1m+vuk31redUdnhbtvN7O40MC+ fgSk5/+jRGxY3IOVPooQKzUO7M51GoOg4wl9ia3H2EzOoGhN2vpTbT8qCcL92ZZZwkBRldoA Wn7c1hEKSTuT3f1VpSmhjnX0J4uvKZ1V2R7rooKJYFBcySC0wa8aTmAtAvLgfcpe+legOtgq DKzLuN45xzEjyjCiI521t8zxNMPJY9FiCPNv0sCkDwARAQABiQI8BBgBCgAmAhsMFiEE16gc tm0zVz86TmBYpjY8MQWQtG0FAlxKNJYFCQnQrVkACgkQpjY8MQWQtG2Xxg//RrRP+PFYuNXt 9C5hec/JoY24TkGPPd2tMC9usWZVImIk7VlHlAeqHeE0lWU0LRGIvOBITbS9izw6fOVQBvCA Fni56S12fKLusWgWhgu03toT9ZGxZ9W22yfw5uThSHQ4y09wRWAIYvhJsKnPGGC2KDxFvtz5 4pYYNe8Icy4bwsxcgbaSFaRh+mYtts6wE9VzyJvyfTqbe8VrvE+3InG5rrlNn51AO6M4Wv20 iFEgYanJXfhicl0WCQrHyTLfdB5p1w+072CL8uryHQVfD0FcDe+J/wl3bmYze+aD1SlPzFoI MaSIXKejC6oh6DAT4rvU8kMAbX90T834Mvbc3jplaWorNJEwjAH/r+v877AI9Vsmptis+rni JwUissjRbcdlkKBisoUZRPmxQeUifxUpqgulZcYwbEC/a49+WvbaYUriaDLHzg9xisijHwD2 yWV8igBeg+cmwnk0mPz8tIVvwi4lICAgXob7HZiaqKnwaDXs4LiS4vdG5s/ElnE3rIc87yru 24n3ypeDZ6f5LkdqL1UNp5/0Aqbr3EiN7/ina4YVyscy9754l944kyHnnMRLVykg0v+kakj0 h0RJ5LbfLAMM8M52KIA3y14g0Fb7kHLcOUMVcgfQ3PrN6chtC+5l6ouDIlSLR3toxH8Aam7E rIFfe2Dk+lD9A9BVd2rfoHA= Message-ID: <3172ee3f-0800-99a5-e148-d10ecdfd51a8@citrix.com> Date: Mon, 13 May 2019 14:44:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <5C7E78F6020000780021BB21@prv1-mh.provo.novell.com> Content-Language: en-US Subject: Re: [Xen-devel] [PATCH 2/3] IOMMU/x86: make page type checks consistent when mapping pages X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: George Dunlap , Andrew Cooper , Juergen Gross Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Message-ID: <20190513134410.9yBaJQanA4AX9jNsF-SoEaOr-fKpJkT6iijPKNTs9jQ@z> T24gMy81LzE5IDE6MjYgUE0sIEphbiBCZXVsaWNoIHdyb3RlOgo+IFRoZXJlIGFyZSBjdXJyZW50 bHkgdGhyZWUgbW9yZSBvciBsZXNzIGRpZmZlcmVudCBjaGVja3M6Cj4gLSBfZ2V0X3BhZ2VfdHlw ZSgpIGFkanVzdHMgdGhlIElPTU1VIG1hcHBpbmdzIGFjY29yZGluZyB0byB0aGUgbmV3IHR5cGUK PiAgIGFsb25lLAo+IC0gYXJjaF9pb21tdV9wb3B1bGF0ZV9wYWdlX3RhYmxlKCkgd2FudHMganVz dCB0aGUgdHlwZSB0byBiZQo+ICAgUEdUX3dyaXRhYmxlX3BhZ2UsCj4gLSBpb21tdV9od2RvbV9p bml0KCkgYWRkaXRpb25hbGx5IHBlcm1pdHMgYWxsIG90aGVyIHR5cGVzIHdpdGggYSB0eXBlCj4g ICByZWZjb3VudCBvZiB6ZXJvLgo+IFRoZSBjYW5vbmljYWwgb25lIGlzIGluIF9nZXRfcGFnZV90 eXBlKCksIGFuZCBhcyBvZiBYU0EtMjg4Cj4gYXJjaF9pb21tdV9wb3B1bGF0ZV9wYWdlX3RhYmxl KCkgYWxzbyBoYXMgbm8gbmVlZCBhbnltb3JlIHRvIGRlYWwgd2l0aAo+IFBHVF9ub25lIHBhZ2Vz LiBJbiB0aGUgUFYgRG9tMCBjYXNlLCBob3dldmVyLCBQR1Rfbm9uZSBwYWdlcyBhcmUgc3RpbGwK PiBuZWNlc3NhcnkgdG8gY29uc2lkZXIsIHNpbmNlIGluIHRoYXQgY2FzZSBwYWdlcyBkb24ndCBn ZXQgaGFuZGVkIHRvCj4gZ3Vlc3RfcGh5c21hcF9hZGRfZW50cnkoKS4gRnVydGhlcm1vcmUsIHRo ZSBmdW5jdGlvbiBzbyBmYXIgYWxzbwo+IGVzdGFibGlzaGVkIHIvbyBtYXBwaW5ncywgd2hpY2gg aXMgbm90IGluIGxpbmUgd2l0aCB0aGUgcnVsZXMgc2V0IGZvcnRoCj4gYnkgdGhlIFhTQS0yODgg Y2hhbmdlLgo+IAo+IEZvciBhcmNoX2lvbW11X3BvcHVsYXRlX3BhZ2VfdGFibGUoKSB0byBub3Qg ZW5jb3VudGVyIFBHVF9ub25lIHBhZ2VzCj4gYW55bW9yZSBldmVuIGluIGNhc2VzIHdoZXJlIHRo ZSBJT01NVSBnZXRzIGVuYWJsZWQgZm9yIGEgZG9tYWluIG9ubHkKPiB3aGVuIGl0IGlzIGFscmVh ZHkgcnVubmluZywgcmVwbGFjZSB0aGUgSU9NTVUgZGVwZW5kZW5jeSBpbgo+IGd1ZXN0X3BoeXNt YXBfYWRkX2VudHJ5KCkncyBoYW5kbGluZyBvZiBQViBndWVzdHMgdG8gY2hlY2sganVzdCB0aGUK PiBzeXN0ZW0gd2lkZSBzdGF0ZSBpbnN0ZWFkIG9mIHRoZSBkb21haW4gcHJvcGVydHkuCj4gCj4g U2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgo+IAo+IC0tLSBh L3hlbi9hcmNoL3g4Ni9tbS9wMm0uYwo+ICsrKyBiL3hlbi9hcmNoL3g4Ni9tbS9wMm0uYwo+IEBA IC04MzcsMTEgKzgzNywxMSBAQCBndWVzdF9waHlzbWFwX2FkZF9lbnRyeShzdHJ1Y3QgZG9tYWlu ICpkCj4gICAgICAgICAgICoKPiAgICAgICAgICAgKiBSZXRhaW4gdGhpcyBwcm9wZXJ0eSBieSBn cmFiYmluZyBhIHdyaXRhYmxlIHR5cGUgcmVmIGFuZCB0aGVuCj4gICAgICAgICAgICogZHJvcHBp bmcgaXQgaW1tZWRpYXRlbHkuICBUaGUgcmVzdWx0IHdpbGwgYmUgcGFnZXMgdGhhdCBoYXZlIGEK PiAtICAgICAgICAgKiB3cml0YWJsZSB0eXBlIChhbmQgYW4gSU9NTVUgZW50cnkpLCBidXQgYSBj b3VudCBvZiAwIChzdWNoIHRoYXQKPiAtICAgICAgICAgKiBhbnkgZ3Vlc3QtcmVxdWVzdGVkIHR5 cGUgY2hhbmdlcyBzdWNjZWVkIGFuZCByZW1vdmUgdGhlIElPTU1VCj4gLSAgICAgICAgICogZW50 cnkpLgo+ICsgICAgICAgICAqIHdyaXRhYmxlIHR5cGUgKGFuZCBhbiBJT01NVSBlbnRyeSBpZiBu ZWNlc3NhcnkpLCBidXQgYSBjb3VudCBvZiAwCj4gKyAgICAgICAgICogKHN1Y2ggdGhhdCBhbnkg Z3Vlc3QtcmVxdWVzdGVkIHR5cGUgY2hhbmdlcyBzdWNjZWVkIGFuZCByZW1vdmUgdGhlCj4gKyAg ICAgICAgICogSU9NTVUgZW50cnkpLgo+ICAgICAgICAgICAqLwo+IC0gICAgICAgIGlmICggIW5l ZWRfaW9tbXVfcHRfc3luYyhkKSB8fCB0ICE9IHAybV9yYW1fcncgKQo+ICsgICAgICAgIGlmICgg IWlvbW11X2VuYWJsZWQgfHwgdCAhPSBwMm1fcmFtX3J3ICkKPiAgICAgICAgICAgICAgcmV0dXJu IDA7CgpUaGlzIGxvb2tzIGdvb2QuICBPbmUgcXVlc3Rpb24gYWJvdXQgdGhlIG5leHQgb25lLi4u Cgo+ICAKPiAgICAgICAgICBmb3IgKCBpID0gMDsgaSA8ICgxVUwgPDwgcGFnZV9vcmRlcik7ICsr aSwgKytwYWdlICkKPiAtLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9pb21tdS5jCj4gKysr IGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvaW9tbXUuYwo+IEBAIC0xOTIsMjEgKzE5MiwyNyBA QCB2b2lkIF9faHdkb21faW5pdCBpb21tdV9od2RvbV9pbml0KHN0cnVjCj4gIAo+ICAgICAgICAg IHBhZ2VfbGlzdF9mb3JfZWFjaCAoIHBhZ2UsICZkLT5wYWdlX2xpc3QgKQo+ICAgICAgICAgIHsK PiAtICAgICAgICAgICAgdW5zaWduZWQgbG9uZyBtZm4gPSBtZm5feChwYWdlX3RvX21mbihwYWdl KSk7Cj4gLSAgICAgICAgICAgIHVuc2lnbmVkIGxvbmcgZGZuID0gbWZuX3RvX2dtZm4oZCwgbWZu KTsKPiAtICAgICAgICAgICAgdW5zaWduZWQgaW50IG1hcHBpbmcgPSBJT01NVUZfcmVhZGFibGU7 Cj4gLSAgICAgICAgICAgIGludCByZXQ7Cj4gKyAgICAgICAgICAgIGlmICggKHBhZ2UtPnUuaW51 c2UudHlwZV9pbmZvICYgUEdUX3R5cGVfbWFzaykgPT0gUEdUX25vbmUgKQo+ICsgICAgICAgICAg ICB7Cj4gKyAgICAgICAgICAgICAgICBBU1NFUlQoIShwYWdlLT51LmludXNlLnR5cGVfaW5mbyAm IFBHVF9jb3VudF9tYXNrKSk7Cj4gKyAgICAgICAgICAgICAgICBpZiAoIGdldF9wYWdlX2FuZF90 eXBlKHBhZ2UsIGQsIFBHVF93cml0YWJsZV9wYWdlKSApCj4gKyAgICAgICAgICAgICAgICAgICAg cHV0X3BhZ2VfYW5kX3R5cGUocGFnZSk7Cj4gKyAgICAgICAgICAgICAgICBlbHNlIGlmICggIXJj ICkKPiArICAgICAgICAgICAgICAgICAgICByYyA9IC1FQlVTWTsKPiArICAgICAgICAgICAgfQo+ ICAKPiAtICAgICAgICAgICAgaWYgKCAoKHBhZ2UtPnUuaW51c2UudHlwZV9pbmZvICYgUEdUX2Nv dW50X21hc2spID09IDApIHx8Cj4gLSAgICAgICAgICAgICAgICAgKChwYWdlLT51LmludXNlLnR5 cGVfaW5mbyAmIFBHVF90eXBlX21hc2spCj4gLSAgICAgICAgICAgICAgICAgID09IFBHVF93cml0 YWJsZV9wYWdlKSApCj4gLSAgICAgICAgICAgICAgICBtYXBwaW5nIHw9IElPTU1VRl93cml0YWJs ZTsKPiArICAgICAgICAgICAgaWYgKCAoKHBhZ2UtPnUuaW51c2UudHlwZV9pbmZvICYgUEdUX3R5 cGVfbWFzaykgPT0KPiArICAgICAgICAgICAgICAgICAgUEdUX3dyaXRhYmxlX3BhZ2UpICkKPiAr ICAgICAgICAgICAgewo+ICsgICAgICAgICAgICAgICAgdW5zaWduZWQgbG9uZyBtZm4gPSBtZm5f eChwYWdlX3RvX21mbihwYWdlKSk7Cj4gKyAgICAgICAgICAgICAgICB1bnNpZ25lZCBsb25nIGRm biA9IG1mbl90b19nbWZuKGQsIG1mbik7Cj4gKyAgICAgICAgICAgICAgICBpbnQgcmV0ID0gaW9t bXVfbWFwKGQsIF9kZm4oZGZuKSwgX21mbihtZm4pLCAwLAo+ICsgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBJT01NVUZfcmVhZGFibGUgfCBJT01NVUZfd3JpdGFibGUsCj4gKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZmbHVzaF9mbGFncyk7CgpXaGF0J3Mg dGhlIGlkZWEgYmVoaW5kIGNhbGxpbmcgaW9tbXVfbWFwKCkgaGVyZSwgcmF0aGVyIHRoYW4gcmVs eWluZyBvbgp0aGUgb25lIGluIF9nZXRfcGFnZV90eXBlKCk/ICBEb2VzIG5lZWRfaW9tbXVfcHRf c3luYygpIG5vdCB3b3JrIHlldCBhdAp0aGlzIHBvaW50LCBvciBkbyB5b3UgZXhwZWN0IHRoZXJl IHRvIGJlIHBhZ2VzIHRoYXQgaGF2ZSBiZWVuIG1hcmtlZApQR1Rfd3JpdGFibGUgd2l0aG91dCBo YXZpbmcgZ29uZSB0aHJvdWdoIF9nZXRfcGFnZV90eXBlKCk/CgogLUdlb3JnZQoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcg bGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9q ZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA==