From: Xose Vazquez Perez <xose.vazquez@gmail.com>
To: Bart Van Assche <bart.vanassche@sandisk.com>,
device-mapper development <dm-devel@redhat.com>
Subject: Re: [PATCH 15/15] Makefile.inc: Enable -Wextra and -Wformat-nonliteral
Date: Mon, 10 Oct 2016 23:51:03 +0200 [thread overview]
Message-ID: <31744465-5fec-9eb8-760d-9fe55e2707af@gmail.com> (raw)
In-Reply-To: <ed6d4ecb-9460-d11a-da65-fea477fb6ac8@sandisk.com>
On 10/10/2016 09:55 PM, Bart Van Assche wrote:
> On 10/10/2016 12:17 PM, Xose Vazquez Perez wrote:
>>
>> With this patch, clang is emitting four new warnings:
>
> -Wformat-nonliteral helped me to catch a real bug. How about suppressing these warnings with a #pragma statement (see also
> http://clang.llvm.org/docs/UsersManual.html#controlling-diagnostics-via-pragmas)?
I don't know if it's worth pollutes the code to save a pair of clang warnings.
next prev parent reply other threads:[~2016-10-10 21:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-10 19:17 [PATCH 15/15] Makefile.inc: Enable -Wextra and -Wformat-nonliteral Xose Vazquez Perez
2016-10-10 19:55 ` Bart Van Assche
2016-10-10 21:51 ` Xose Vazquez Perez [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-10-04 17:36 [PATCH 00/15] Fifteen multipath-tools patches Bart Van Assche
2016-10-04 17:42 ` [PATCH 15/15] Makefile.inc: Enable -Wextra and -Wformat-nonliteral Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31744465-5fec-9eb8-760d-9fe55e2707af@gmail.com \
--to=xose.vazquez@gmail.com \
--cc=bart.vanassche@sandisk.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.