From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BDA1C38A2A for ; Thu, 7 May 2020 16:26:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 08FC720936 for ; Thu, 7 May 2020 16:26:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726863AbgEGQ0K (ORCPT ); Thu, 7 May 2020 12:26:10 -0400 Received: from foss.arm.com ([217.140.110.172]:35230 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726470AbgEGQ0K (ORCPT ); Thu, 7 May 2020 12:26:10 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1A4B21FB; Thu, 7 May 2020 09:26:10 -0700 (PDT) Received: from [192.168.0.14] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0701C3F71F; Thu, 7 May 2020 09:26:07 -0700 (PDT) From: James Morse Subject: Re: [PATCH 09/26] KVM: arm64: vgic-v3: Take cpu_if pointer directly instead of vcpu To: Marc Zyngier , kvmarm@lists.cs.columbia.edu Cc: linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, Andre Przywara , Christoffer Dall , Dave Martin , Jintack Lim , Alexandru Elisei , George Cherian , "Zengtao (B)" , Will Deacon , Catalin Marinas , Mark Rutland , Julien Thierry , Suzuki K Poulose References: <20200422120050.3693593-1-maz@kernel.org> <20200422120050.3693593-10-maz@kernel.org> Message-ID: <3174eaad-7d8d-0c52-d71c-afc6b991b636@arm.com> Date: Thu, 7 May 2020 17:26:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200422120050.3693593-10-maz@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Hi Marc, Christoffer, On 22/04/2020 13:00, Marc Zyngier wrote: > From: Christoffer Dall > > If we move the used_lrs field to the version-specific cpu interface > structure, the following functions only operate on the struct > vgic_v3_cpu_if and not the full vcpu: > > __vgic_v3_save_state > __vgic_v3_restore_state > __vgic_v3_activate_traps > __vgic_v3_deactivate_traps > __vgic_v3_save_aprs > __vgic_v3_restore_aprs > > This is going to be very useful for nested virt, ... because you don't need to consider whether the vcpu is running in vEL2? > so move the used_lrs > field and change the prototypes and implementations of these functions to > take the cpu_if parameter directly. > No functional change. Looks like no change! Reviewed-by: James Morse Thanks, James From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9189AC38A24 for ; Thu, 7 May 2020 16:26:15 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 0F9352083B for ; Thu, 7 May 2020 16:26:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0F9352083B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 747BE4B3D1; Thu, 7 May 2020 12:26:14 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Jfz8IiRWIWvG; Thu, 7 May 2020 12:26:13 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 566CF4B3CE; Thu, 7 May 2020 12:26:13 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id CBAA14B3CE for ; Thu, 7 May 2020 12:26:11 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SQDskhUngtlG for ; Thu, 7 May 2020 12:26:10 -0400 (EDT) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 810544B323 for ; Thu, 7 May 2020 12:26:10 -0400 (EDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1A4B21FB; Thu, 7 May 2020 09:26:10 -0700 (PDT) Received: from [192.168.0.14] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0701C3F71F; Thu, 7 May 2020 09:26:07 -0700 (PDT) From: James Morse Subject: Re: [PATCH 09/26] KVM: arm64: vgic-v3: Take cpu_if pointer directly instead of vcpu To: Marc Zyngier , kvmarm@lists.cs.columbia.edu References: <20200422120050.3693593-1-maz@kernel.org> <20200422120050.3693593-10-maz@kernel.org> Message-ID: <3174eaad-7d8d-0c52-d71c-afc6b991b636@arm.com> Date: Thu, 7 May 2020 17:26:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200422120050.3693593-10-maz@kernel.org> Content-Language: en-GB Cc: kvm@vger.kernel.org, Andre Przywara , Dave Martin , Will Deacon , George Cherian , "Zengtao \(B\)" , Catalin Marinas , linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu Hi Marc, Christoffer, On 22/04/2020 13:00, Marc Zyngier wrote: > From: Christoffer Dall > > If we move the used_lrs field to the version-specific cpu interface > structure, the following functions only operate on the struct > vgic_v3_cpu_if and not the full vcpu: > > __vgic_v3_save_state > __vgic_v3_restore_state > __vgic_v3_activate_traps > __vgic_v3_deactivate_traps > __vgic_v3_save_aprs > __vgic_v3_restore_aprs > > This is going to be very useful for nested virt, ... because you don't need to consider whether the vcpu is running in vEL2? > so move the used_lrs > field and change the prototypes and implementations of these functions to > take the cpu_if parameter directly. > No functional change. Looks like no change! Reviewed-by: James Morse Thanks, James _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44333C47257 for ; Thu, 7 May 2020 16:26:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 17E3E208D6 for ; Thu, 7 May 2020 16:26:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pZTYdVXO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 17E3E208D6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:References:To:Subject:From:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xqzHElnFK9JqTY8y8EJZ7uSanwVJsZAHwvAZMI1cAjA=; b=pZTYdVXOjGuMOE hkai8E9Y0Ms1/tyIIUShJ9G1ZYVwniyNc/WG/nmOUlF60wT1hyie8AeuwwvzMDQ7o9vwZ9Dgnl0/1 ymg89grmGOt87+eM88a/NO1dhrh+1POHYWHBJdvkcVMVWVML9ir4jjS1LdP2WGleOX3Fgl5xMgz0Z f/eCmrJCzPKnp2nkrSAG7htUJXSWdSiYQE1IyBqI8FPd0bGhHSPW6+rssMNdxtl5NDcr+6Oe8SBfc Vx5H8Cm3Vl+90hiOkzMVEUOFawVxp1oDxWjSKbtsu2gnJJWtMTDOP5s2zCHaM3MQysfjJtPh86sp9 Ik5esAItft3lYGLTmQuw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWjLh-0003kz-L5; Thu, 07 May 2020 16:26:13 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWjLe-0003kH-Pz for linux-arm-kernel@lists.infradead.org; Thu, 07 May 2020 16:26:12 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1A4B21FB; Thu, 7 May 2020 09:26:10 -0700 (PDT) Received: from [192.168.0.14] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0701C3F71F; Thu, 7 May 2020 09:26:07 -0700 (PDT) From: James Morse Subject: Re: [PATCH 09/26] KVM: arm64: vgic-v3: Take cpu_if pointer directly instead of vcpu To: Marc Zyngier , kvmarm@lists.cs.columbia.edu References: <20200422120050.3693593-1-maz@kernel.org> <20200422120050.3693593-10-maz@kernel.org> Message-ID: <3174eaad-7d8d-0c52-d71c-afc6b991b636@arm.com> Date: Thu, 7 May 2020 17:26:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200422120050.3693593-10-maz@kernel.org> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200507_092610_894165_372E2018 X-CRM114-Status: GOOD ( 12.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , kvm@vger.kernel.org, Suzuki K Poulose , Andre Przywara , Christoffer Dall , Dave Martin , Will Deacon , George Cherian , Julien Thierry , "Zengtao \(B\)" , Catalin Marinas , Alexandru Elisei , Jintack Lim , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marc, Christoffer, On 22/04/2020 13:00, Marc Zyngier wrote: > From: Christoffer Dall > > If we move the used_lrs field to the version-specific cpu interface > structure, the following functions only operate on the struct > vgic_v3_cpu_if and not the full vcpu: > > __vgic_v3_save_state > __vgic_v3_restore_state > __vgic_v3_activate_traps > __vgic_v3_deactivate_traps > __vgic_v3_save_aprs > __vgic_v3_restore_aprs > > This is going to be very useful for nested virt, ... because you don't need to consider whether the vcpu is running in vEL2? > so move the used_lrs > field and change the prototypes and implementations of these functions to > take the cpu_if parameter directly. > No functional change. Looks like no change! Reviewed-by: James Morse Thanks, James _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel