From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v3 2/2] eal: fix signed integers in fbarray
Date: Tue, 17 Apr 2018 14:39:27 +0200
Message-ID: <3175682.LQN8HbFZGo@xps>
References: <20180413155417.29643-1-adrien.mazarguil@6wind.com>
 <e2100a0c-6b06-92e3-e52f-a98da7ef4810@intel.com>
 <8624521c-060c-3c22-3e56-d1988b4eeda7@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 61BA68DA9
 for <dev@dpdk.org>; Tue, 17 Apr 2018 14:39:29 +0200 (CEST)
In-Reply-To: <8624521c-060c-3c22-3e56-d1988b4eeda7@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

17/04/2018 13:14, Burakov, Anatoly:
> On 14-Apr-18 11:03 AM, Burakov, Anatoly wrote:
> > On 13-Apr-18 7:43 PM, Adrien Mazarguil wrote:
> >> While debugging startup issues encountered with Clang (see "eal: fix
> >> undefined behavior in fbarray"), I noticed that fbarray stores indices,
> >> sizes and masks on signed integers involved in bitwise operations.
> >>
> >> Such operations almost invariably cause undefined behavior with values 
> >> that
> >> cannot be represented by the result type, as is often the case with
> >> bit-masks and left-shifts.
> >>
> >> This patch replaces them with unsigned integers as a safety measure and
> >> promotes a few internal variables to larger types for consistency.
> >>
> >> Fixes: c44d09811b40 ("eal: add shared indexed file-backed array")
> >> Cc: Anatoly Burakov <anatoly.burakov@intel.com>
> >>
> >> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> >>
> >>
> >> v3 changes:
> >>
> >> - Added INT_MAX upper bound check in fully_validate() as suggested by
> >>    Anatoly.
> >> - Added a sysconf() result check to appease Coverity since 
> >> calc_data_size()
> >>    now takes an unsigned page size (Coverity issues 272598 and 272599).
> >>
> >> v2 changes:
> >>
> >> Removed unnecessary "(unsigned int)" cast leftovers.
> > 
> > Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
> > 
> 
> Still ack, but i think Coverity issues need to be moved to main commit 
> message, as opposed to being in patch notes.

Applied (with Coverity ids added), thanks