Re: [PATCH v2 1/1] misc: bcm-vk: Remove viper from device id table

From: Scott Branden <scott.branden@broadcom.com>
To: Desmond Yan <desmond.yan@broadcom.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] misc: bcm-vk: Remove viper from device id table
Date: Wed, 2 Mar 2022 10:09:43 -0800	[thread overview]
Message-ID: <317b176b-e045-20ce-6092-f93e4b6ef5ad@broadcom.com> (raw)
In-Reply-To: <20220302025340.25602-1-desmond.yan@broadcom.com>

[-- Attachment #1: Type: text/plain, Size: 1024 bytes --]

Looks fine - Viper not officially supported by this driver.

On 2022-03-01 18:53, Desmond Yan wrote:
> As bcm_vk driver is not the production driver for viper, remove
> its pci device id from table.
> 
> Signed-off-by: Desmond Yan <desmond.yan@broadcom.com>
Acked-by: Scott Branden <scott.branden@broadcom.com>
> ---
> Changes since v1:
> - remove Kconfig option and simply remove viper pci id completely
> ---
> drivers/misc/bcm-vk/bcm_vk_dev.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/misc/bcm-vk/bcm_vk_dev.c b/drivers/misc/bcm-vk/bcm_vk_dev.c
> index ad639ee85b2a..a16b99bdaa13 100644
> --- a/drivers/misc/bcm-vk/bcm_vk_dev.c
> +++ b/drivers/misc/bcm-vk/bcm_vk_dev.c
> @@ -1633,7 +1633,6 @@ static void bcm_vk_shutdown(struct pci_dev *pdev)
>   
>   static const struct pci_device_id bcm_vk_ids[] = {
>   	{ PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_VALKYRIE), },
> -	{ PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_VIPER), },
>   	{ }
>   };
>   MODULE_DEVICE_TABLE(pci, bcm_vk_ids);

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]