From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9F5DC54791 for ; Wed, 13 Mar 2024 18:11:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F01B680055; Wed, 13 Mar 2024 14:11:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EB230940010; Wed, 13 Mar 2024 14:11:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D2AF080055; Wed, 13 Mar 2024 14:11:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C0A0F940010 for ; Wed, 13 Mar 2024 14:11:32 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7C28D80846 for ; Wed, 13 Mar 2024 18:11:32 +0000 (UTC) X-FDA: 81892808424.16.9442556 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf17.hostedemail.com (Postfix) with ESMTP id D60E84001C for ; Wed, 13 Mar 2024 18:11:28 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=emMREOiT; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=hnDfF77P; spf=pass (imf17.hostedemail.com: domain of jane.chu@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=jane.chu@oracle.com; dmarc=pass (policy=none) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710353489; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qGjbSfiANT5xZ3lxyyrZDyUKVtSaSj+GdDcl/5wMGZo=; b=cGPoVbvUklZ2234sGcpDFDbf0EhClSoLy7QuZH1gh/DMiJuwrZ9MBjaisJGdfRSuiRYf6r HpRX1TojaXVBDcLR8j7EiHM/EU7b9qah4KfSZIemFREA4eaj695l3RfNiUbi56jT/Jk7Or 0mA6B4DmyZlvjZfaM2E20i3lz6JnlW8= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1710353489; a=rsa-sha256; cv=pass; b=nyaRXNI+8TL3U/K9EUYg3ZwX43zz8S9UU2igXvFHDPuafkR21txYFPYWdrRoTjNEHZBW8m 7OhPKb09imVoHHT2qSJ+ZmtPh+RbTQsbGq/KgtwIpurmVljY7t3Dnwm93jcxVTe3WoDKHM HSJQ8eql0o1zjcCAOjS3TrHgObTepuU= ARC-Authentication-Results: i=2; imf17.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=emMREOiT; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=hnDfF77P; spf=pass (imf17.hostedemail.com: domain of jane.chu@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=jane.chu@oracle.com; dmarc=pass (policy=none) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 42DHxUsk000410; Wed, 13 Mar 2024 18:11:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=qGjbSfiANT5xZ3lxyyrZDyUKVtSaSj+GdDcl/5wMGZo=; b=emMREOiTpWKxr9X4n6z3HjqyRyIzohWy2zrC+iWv+iFjGLi1GS/XfpCKOs/COV+pjczQ hI6Jv/QsYVNvgPBclLayHRMcnWbs9QwEnxFbPjoo8FXJFVNUwp7pj7Z6RLJUjSFqg5KT jrQefxN71Tp8i01pT2z5TsH9RXvgO9WAOgecfk7H42dM5H5ki9s2XCP8ncGNA4THQB3a xWG5YxvpY9gHPWxAgrdVfB7lVqarukpbsQRFzfq57dHii/cA63XFw1zAOmwNRhQrL5n8 ERaO1CLT4uwM+SsNr0pK1qt/h/lxVk/eflfy0eNvfRxhEQabemJnWh9A91cgplYGaSNo BQ== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3wrgausf6q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 13 Mar 2024 18:11:18 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 42DHV4lV009106; Wed, 13 Mar 2024 18:11:16 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2101.outbound.protection.outlook.com [104.47.55.101]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3wre7fenn2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 13 Mar 2024 18:11:16 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XxT25nxjq5me1RGzxPypH8gLXKTrDlyhfs6KT3AwUGnAtnhvva6x3rT0GWuI0OYayogHFxyluDNDvuLnZDIqCqvXURVs61DrhfEc5RrcJ3gxHBu0ff7t2ySWWDzUPvr/+5r+kIfRIoHJAry9GZvlK93MpOict3VXC+lLDOy5OG7NVE6MstnYGCxjgfw85Cawcl7Ur2W22mVe1kjkA0O+BC93+qZUagb7h/vVwflUnn6oGw833myXPWKW4Bq7gUIYM8gfn29hDDZLWV1B4bERcX8nRE377ZzfU7EN34k/rNZgkf4RNsE0dnicOvDibBLgTxTKq6L/RvOLWVBGH7hz0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qGjbSfiANT5xZ3lxyyrZDyUKVtSaSj+GdDcl/5wMGZo=; b=InNpV1kbRlPfE0jJTrhKhfB4FqSKAPZGKNVkjMCrG1zjL1fPqrexR3iDyzBej2mMuo2e8EBvZVdGXn8HNYVGTL8moA9wQUCL/qIPQKuCHRaX3/pYgj4M8NbyWvZkFL7i9pNDUZT3CXUuQ6Kp6XM6iAsgQrsm9fG3M9JESgO/fTPJ58+oB9orAg95wR7DljbrwQPSO5NXgCUzRn7b442tasdgY5bO2Fi/uq/gMgaI4EMR5vwPkdD8WOHxajjQwIq+bQxksn+t91p1qV60WDtjFnIHd8AF1JLdqq7Ba0ACH0ub3f/zogBAS3Nafs376H9eyh7TbMR//t/BbAzcB7sAWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qGjbSfiANT5xZ3lxyyrZDyUKVtSaSj+GdDcl/5wMGZo=; b=hnDfF77PHby/n7Q6RMo15wrZcETIupv+eiOSGpTReOHaw8m2VNaEwwHauvZbL/Flr+cRB9lXblhw3dWq9KwYx9XoH3QPU+nil3I6b3vh0N2kU+BQMD6+Mgc3XUPbBEmvFfatL7AatLSl1K3hZtzwb7ZJRSP1W2ALjgbOfzqwtsw= Received: from SJ0PR10MB4429.namprd10.prod.outlook.com (2603:10b6:a03:2d1::14) by PH7PR10MB5829.namprd10.prod.outlook.com (2603:10b6:510:126::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.35; Wed, 13 Mar 2024 18:11:08 +0000 Received: from SJ0PR10MB4429.namprd10.prod.outlook.com ([fe80::210e:eea7:3142:6088]) by SJ0PR10MB4429.namprd10.prod.outlook.com ([fe80::210e:eea7:3142:6088%5]) with mapi id 15.20.7362.035; Wed, 13 Mar 2024 18:11:08 +0000 Message-ID: <317bf68f-317a-486a-934c-18f2dca5fb2b@oracle.com> Date: Wed, 13 Mar 2024 11:11:04 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/8] mm/memory-failure: Remove fsdax_pgoff argument from __add_to_kill Content-Language: en-US To: Matthew Wilcox Cc: Andrew Morton , ruansy.fnst@fujitsu.com, linux-mm@kvack.org, Miaohe Lin , Naoya Horiguchi , Dan Williams , Jane Chu References: <20240229212036.2160900-1-willy@infradead.org> <20240229212036.2160900-2-willy@infradead.org> <35c987d6-e78e-41df-a157-cc764245fa30@oracle.com> From: Jane Chu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: BL1PR13CA0112.namprd13.prod.outlook.com (2603:10b6:208:2b9::27) To SJ0PR10MB4429.namprd10.prod.outlook.com (2603:10b6:a03:2d1::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR10MB4429:EE_|PH7PR10MB5829:EE_ X-MS-Office365-Filtering-Correlation-Id: 3984e79f-bd27-45fc-c579-08dc4388f4bc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wdYb58+B4xMJXmbaKhfhYlBqCwXAjqHuawsXTDLEYgyn6F0o2YLVTL7O8EN/IPF5CYZpelQMEyYZxgxlbfHvVsst/nRIw/sFKUMl9HiJfB7cqzCQYsbKFpxhjtt8cuNQ5uRNyWjeqRrNToa3qekhp9Zqu9j9eA8moyZgUaE7DPz5RRRZeySEzYGAiwZrXcKMMQJ2NMzzn3G4cwkGpdPPxjHmtVPXYuiniZ6xw/IQIVPBDHfpIT/jD/0TvIBNVYFc6nVzglfPd2dWaCQzI7UCTMfrKipfGlSo2laxh1H9uFNPMEPd6iOidw1vnFf6lkSRjdbsxCrjrR1NlIeo71LcBEHrHs2VnwNkdWnN7PF2tGuyDuaoTBm91rPrcKtvoFhwiB5P14UXvwUrJrBHHKTDF2z0LZyqIEMZ0Fp6f0sRuZPoUhkw5iWV+adCBCis5w11O0jRTsw1q8lEg570411oeo7Y9P85HPPLfRmP+JvCl5ryedR3irZUjAaEb8wYi7HDwUSSzd4VNnCDPN+Qyku7LPBbrVx2ix4TaYrTNR5ORrh0KM+0Nsx1N8a6GcF8rJ7DB7/PG0Awb7BV/WfnownzgLR2kklaW+Dxbd6ENCk83ec= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR10MB4429.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(1800799015);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c3RyK3NkOHpFSlZsRzFlM2w1bm03WGZ6TWsyZ3NCT1kwSFBWQS9sdmRsUGJt?= =?utf-8?B?NXlIRndOYVZGZHFLRXhnU0VFMTZaQlRHRDl5U2h6dWZhV21pVHN4STBNOFdO?= =?utf-8?B?ZjJ4eE9kV2ZERVJIaXV1a2N5cWo1cExCSWRSUFpGQmpkZlgrVkN5cDFNSmJo?= =?utf-8?B?ZmtwaERqbjJlT3dhQ2NqK1dFNmd5T1ROb1dMZm1NcWo2dFhuS0EySHhocU03?= =?utf-8?B?aGNWcXEwLzhFN2xMcGoyU3AzZXBEaTdyU2hCcGpPMEhZeTMzL2Z3bmtpUWdO?= =?utf-8?B?aWM2a3dHckVCeFdHU1k0SUFwSFk0UXVqMWFZVjdzR2pRNWVEV3dILzNLR0tZ?= =?utf-8?B?Ulc3V0t3WGhIakllMFZ2NXdtL2lwUjFRYlJFWWpVUW1ZdmNHMnJiQy8yNVht?= =?utf-8?B?dHpYR3pPWGFZQVk1SXdiL0U5WklsaDdzL0N1NGdtNnFhdHJjaTNncDQ1c3c1?= =?utf-8?B?eDdDczEyTDZIT0Zld25HU0dmeXZRc254Y2tzM2g3UjBBT3ZmRUVEQit1clc3?= =?utf-8?B?MTE2RmZzd3RWc0NncGx4bUIrcnhkZTZOTHIrUWdJWXdLMjVKdkUreW93T3VN?= =?utf-8?B?VGxVdDJVaURSckM4YmxicVYxVW5KSVo3MytIcUtVMDZoTDZxT3ZrUEVrQ2J3?= =?utf-8?B?NnY5Q0lQbnhSMEF3TklSOGQyMDhtYTZWbjRsZ0JKQU44ZzZFd0lKQ2pYRjBF?= =?utf-8?B?WHJ4OHlQaldGTTBkWDRoMmU0T3FZOXVPSHY0K2hUQTlxVW1xQzdtR2p4QjJL?= =?utf-8?B?M2RiOUNYQ2RVdFRZQmtpRUVjTmFkZEJzRjJyVFNIMXB4NGtwYkk3dUZNZ3Ey?= =?utf-8?B?d2E2aXNudlpCcTZITmV4UDJIcG1MVFAzTWVaUHFFUm5KRXZLaXhQYTBDQU5l?= =?utf-8?B?S0xyd3pjSjE2VUo5MEZQYTZhQ1RVc2hqR2hrYlRoRFA3NWtVVzhQRy9QaDBn?= =?utf-8?B?SFNhczNHckNCQ20rSlh2MlE0YWVhbGlVeDJDd3paWEw4eDRUOS9paVphRjVP?= =?utf-8?B?aU9xMDBEaTAzcEo4MVRSQ2VOcnFCTFVHd3ZsVEExL0tqcHBkQkdIbnVGZWxM?= =?utf-8?B?V004ZWhmVGpSUllidi9hY2pZWWJ6NjRuV1g5SURVUzlKY1JDRnJtWUZXbXR3?= =?utf-8?B?QThWenJoWXVBTVZuNDhUWjlhOGk4QVJxalZTdDFmTGhCNG1YQ3hQN3ZBR01W?= =?utf-8?B?cU55eHp4Y0pjTDdnTTJHaTVyMERVdHpMcTdGRjV4SDBxTXdrUTgvaFk2U0N2?= =?utf-8?B?RHRnNGExTllzRGIxcDRFNFZUQmI2VUZmNUVpZlp5U0R1Qk5UblkrTUd4ekox?= =?utf-8?B?SzljbDQ4aEZKcjJpQndCOWx2R1RBNGFBUitvZjFWYmk0ZE1Pcll1ZXUxL25j?= =?utf-8?B?TmdLZ0UyM1c4ZkczMEE0eSsyRGpBc0ZnbzB5bHI1Z21rTXgwWlhoZ1JuU0xG?= =?utf-8?B?SnM5TTBzVStaTUdOTHYyNU9sN2puYmppM0N4MEJZdFlLTmt4Y2sxdS9sMEly?= =?utf-8?B?REJBeURBZ1JDbzdJUXByK0lqUDl2aFhST2hQVlBuNVpCMXpQbVQ2b3RFdDlz?= =?utf-8?B?VjVXd2thUTdrcFp0Y1hjclczWWVOMUtrSm5GVzY4UWs1MUc2QTZSVnlUeXpI?= =?utf-8?B?bE9MMmxJZGtCZ1ltMGFwdjNkdXROSzg1RnNuNFRLSTR2czEvNlBaYkNBMmFQ?= =?utf-8?B?YisrbHAydkFWQ3Q5bkFpSVQrbWZrT3NBMUViOXJJSlUrVHgyMWg1bXpjeXBi?= =?utf-8?B?Y2ZqSWtEaDNWdVpDRUorbWozdU4zK3RVb1JZemw3RGQrTktYcGg4QmJWcEN5?= =?utf-8?B?RHMvT0tXVjl2cVdDYURSenBYMFRUVzVOZG1SRnVSbm1UK3UzK2JKMzUveGxh?= =?utf-8?B?ZHJQYWNBaWJzWGc2UmVSK3R4SlVTNmhPQVJXcTBiVFo4Q1ZDK2FaM29zbGM0?= =?utf-8?B?VGtkUjFvbGwvU0FGYThQeXZPWEpwWmM0Q0RwaUtPOWsveXBzeEZUcGVTZDF0?= =?utf-8?B?Y1RzQmd2ZnhUc1lYTjZ1cDhIT0JGdlM3M1g2MnE2RG9YYThmS2lRUkdWZitk?= =?utf-8?B?b251OGd1RmpLY2l6b3Znc2RYdmZYZUU4M0NESTFZa1lmb1pRV2ZFWnRJTXF4?= =?utf-8?Q?GMOiZY0KA4Yc2kwliPB7A88zc?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: +IonYHAC8BoFvFaUSbLT/yHBJYjSJxeZBqftayTDbmkTuB0wdyj7f1KBsjja1XQe0hKcZgceDJe0m5lqpqZXbaJCCKgcJco2lDRQ2f3Xwfj45xrikiHe6s26E/cGyj6uD/TFCQoCvwfkCRKoQNXSL6VcEx8BsDehurLgqpLaQTf9PNKtU2j61WNCyXsN+Lu01OpSjqgor83tR5dG6wk9cOym8hVh9bIfNyg3ndjzFfBuXPSrcQ9O/7z7jAi/DJLbxZzgXQYsiRhfUT56hC9du5TsyIWLuivgT/IrzUkccysKHCdJCDncqBymF+edqn7/nUmrOC4HWnj14App023iq8hjHA9weA0Ol7w2YIbpPyV+CukikXdvmyEzL2KyI6e7rYJkeCIl7S1OxwbzIoM1j9I/WpZnXotqJmHDpxZQvUXMxkf31HZyLn9HoLyRhZjQ1xSrLXyWseWbrME13ld3wasv3FPJC5m5rRxJOBIvxxOHn1gjwDHqC4eIj4NGE8YTnHJIpI0CtEaDWBgIXunlsh1vt2lnu3hV0fnsudiHKDAqSkrMNiaPnHQJr+SLbaW7W3RijxZjzzB8xNS+zKVWukHhf1dsDKy0Dv2aNROi0ns= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3984e79f-bd27-45fc-c579-08dc4388f4bc X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4429.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2024 18:11:08.2548 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PSgrfszQx82KSY/c55ZIwgn3j9Kxd6saZ/lihrZNLWWt9eWuLHSNwqzIg4QHwVCFLZn1evPSq4ngvFM3I3LaNg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB5829 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-13_09,2024-03-13_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 spamscore=0 mlxlogscore=999 bulkscore=0 phishscore=0 malwarescore=0 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2403130138 X-Proofpoint-GUID: zv67y9r6F-B7nMeNc7_PWAlB1fHy7tdD X-Proofpoint-ORIG-GUID: zv67y9r6F-B7nMeNc7_PWAlB1fHy7tdD X-Rspamd-Queue-Id: D60E84001C X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: p751abw5a9r838wjxeoqajqddntmbtth X-HE-Tag: 1710353488-51551 X-HE-Meta: U2FsdGVkX19eMDa4EtBsS6SmGugV5t78tHiR9vGIuQdsST/3FUcXmjlAC6zU0AgA91CcJh4WhFcAQnrhMNP63nqAqgbCAvXQENm0HUbkFVoM19c2kOfXHNjZRT5Qy+pbuWtFfbKYhnCZGXNQ+o9N70t4WKgr/JGIEOT9xtgjUGKe6u6PPMDbHOSuOPX76yvZNBkmAAD3jMsGF6ykBEPcu0k36RKXpzu1Zu4JeDz8gY7KzQQ8xQhpmcY9yBjO5wJ9Es8KGTLxDlZGAhXXvxBg4mw8TOIKyWMaxM2GQ48oy7d+lODr+481EhbYxjJQn7kfx4Ajqh+INUQrrnyM0OgrO1HrYWFFteCxC/fM0wM6GZGUpC/lu3gh+splW0Pnu2X1tz+sGfa1huQnile1WUI1T42Q5QapnMrgj7yMcrCG+63Iw5op36UQXZE+IDaQYpw2mRuV70KhFdUe3YAJIWEuayQfQ+ZdlrKBmYC8Fw3ftSXBwCEmpE/C2uDt7LUOS9T/5uvb7phIHk0P7kBeBvpqA8lGsBIk4+OF0oRLVf2BdTbvEufQtAyCNI/0ktAmShqZ+jT2XqiH/f7mCQ40Q2GhA05hLzj8VvWXX7bwj5ZxsLB7BUCQ0u33sGgYsR1J8emCjrFPTPGVKbOaPOCPOB+m741+1fPeRwGRYp71Xw4wkIayORgbwGH1KJ51W11b19uqvcfiipeboSaYDittscYQ8kf+RUag/AOcNjLctE2rjeYXvHgKjZBVxLkmndgBQozNxmYAArG69R2BoHVaHyR5MXLM1GAR4E6sWQD/TqNUPGDiUOoodtcQ6KeOA3sQKER80Z0fkg70U+uf2tcCKX8/DFOcez6s9gVJp6jTZY7Kw97SoqQwFCMWfxdN6wOOVmNm2IhzUojBgTknpqA2+bGdcAEmmXKnt3uK6awWxkop1OdKuO6wOtj5qBls3RbXvUtgndLdzz2O5tVk5tVgtEC vdFQXdPm Zvgo9fv/unNazwCKpd1b5jJVuKqzROLE14iyvLYUyps+irMpadN22kBSl+OcG/uiVwnjLrAz1Og7q+v9S737R/+j2Y8tu+f7dKVhkTTuQ6zOFMCWjAnG+USYcKLIICD/UXo9ADCTdXF1XtSqW3JM7oScQn/zRiFCO27BChQRj5tF+mBrsYiDOzbw9ONzr0vupilSoPOHevEL7gcEHZwHgcKjtQbOsn7OUoA5hSlLbcuZtAdZd4nX6ryrY8qhlcAjWr681omspKA8HkWPGzIOZGMYYjz9JVHxt4IKsbOU5qnehqkB5NKJY3RWtS2//vw2KwjGLsKqtG3qSkpyfk8Uw+rrqd+HDYiMc/6+0WmgMfoynAcfzjcyVxeFg4NnaQBypt5YEN4k4aAmrGBh0YzqlqISwwd+juOP3+oJs5kPYQCpwauPDKq/py82KKDIV+VNi2dP4L6n1F2v7Gjxx8133Zwv0RlxvJAWKjCtLezfQKFVtJDORaim4hJPWec6Xl5PAfAlyhujjdrxRf15Zh16/RaNy0OsYLoeATGFWPkj+bQptUcOkKEe5i3IVSDF12IY5WXZgJZU4G9guq0pM/thLEfRDDHRzi9Q1uxEaoxKcFVU3NWB1sPD3Lpn7fLxuBixLZLBv8els2ctQFRVLQqkW/XfioNFc1+pOhEqsCjTxvedKz7rw4owlxYyqvseH4xTjGrxqVX4qlx99a3HHLAGU+2+YPSC01kij9sLNOg1qxuaOhsg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/12/2024 8:23 PM, Matthew Wilcox wrote: > On Tue, Mar 12, 2024 at 07:07:10PM -0700, Jane Chu wrote: >> On 2/29/2024 1:20 PM, Matthew Wilcox (Oracle) wrote: >> >>> Unify the KSM and DAX codepaths by calculating the addr in >>> add_to_kill_fsdax() instead of telling __add_to_kill() to calculate it. >>> >>> Signed-off-by: Matthew Wilcox (Oracle) >>> Cc: Dan Williams >>> --- >>> mm/memory-failure.c | 27 +++++++++------------------ >>> 1 file changed, 9 insertions(+), 18 deletions(-) >>> >>> diff --git a/mm/memory-failure.c b/mm/memory-failure.c >>> index 9349948f1abf..9356227a50bb 100644 >>> --- a/mm/memory-failure.c >>> +++ b/mm/memory-failure.c >>> @@ -416,21 +416,13 @@ static unsigned long dev_pagemap_mapping_shift(struct vm_area_struct *vma, >>> * not much we can do. We just print a message and ignore otherwise. >>> */ >>> -#define FSDAX_INVALID_PGOFF ULONG_MAX >>> - >>> /* >>> * Schedule a process for later kill. >>> * Uses GFP_ATOMIC allocations to avoid potential recursions in the VM. >>> - * >>> - * Note: @fsdax_pgoff is used only when @p is a fsdax page and a >>> - * filesystem with a memory failure handler has claimed the >>> - * memory_failure event. In all other cases, page->index and >>> - * page->mapping are sufficient for mapping the page back to its >>> - * corresponding user virtual address. >>> */ >>> static void __add_to_kill(struct task_struct *tsk, struct page *p, >>> struct vm_area_struct *vma, struct list_head *to_kill, >>> - unsigned long ksm_addr, pgoff_t fsdax_pgoff) >>> + unsigned long addr) >>> { >>> struct to_kill *tk; >>> @@ -440,12 +432,10 @@ static void __add_to_kill(struct task_struct *tsk, struct page *p, >>> return; >>> } >>> - tk->addr = ksm_addr ? ksm_addr : page_address_in_vma(p, vma); >>> - if (is_zone_device_page(p)) { >>> - if (fsdax_pgoff != FSDAX_INVALID_PGOFF) >>> - tk->addr = vma_pgoff_address(fsdax_pgoff, 1, vma); >>> + tk->addr = addr ? addr : page_address_in_vma(p, vma); >>> + if (is_zone_device_page(p)) >>> tk->size_shift = dev_pagemap_mapping_shift(vma, tk->addr); >> Not sure about the simplification.  The fsdax special calculation was added by >> >> commit c36e2024957120566efd99395b5c8cc95b5175c1 >> Author: Shiyang Ruan >> Date:   Fri Jun 3 13:37:29 2022 +0800 >> >>     mm: introduce mf_dax_kill_procs() for fsdax case >> >>     This new function is a variant of mf_generic_kill_procs that accepts a >>     file, offset pair instead of a struct to support multiple files sharing a >>     DAX mapping.  It is intended to be called by the file systems as part of >>     the memory_failure handler after the file system performed a reverse >>     mapping from the storage address to the file and file offset. >> >>     Link: https://lkml.kernel.org/r/20220603053738.1218681-6-ruansy.fnst@fujitsu.co >> m >> [..] >> >> @@ -354,9 +357,15 @@ static void add_to_kill(struct task_struct *tsk, struct page *p, >> >>         } >> >>         tk->addr = page_address_in_vma(p, vma); >> >> -       if (is_zone_device_page(p)) >> >> -               tk->size_shift = dev_pagemap_mapping_shift(p, vma); >> >> -       else >> >> +       if (is_zone_device_page(p)) { >> >> +               /* >> >> +                * Since page->mapping is not used for fsdax, we need >> >> +                * calculate the address based on the vma. >> >> +                */ >> >> +               if (p->pgmap->type == MEMORY_DEVICE_FS_DAX) >> >> +                       tk->addr = vma_pgoff_address(fsdax_pgoff, 1, vma); >> >> +               tk->size_shift = dev_pagemap_mapping_shift(vma, tk->addr); >> >> +       } else >> >>                 tk->size_shift = page_shift(compound_head(p)); >> >> Looks like it was to deal away with this check >> >> unsignedlongpage_address_in_vma (structpage >> *page >> ,structvm_area_struct >> *vma >> ) >> { [..] >> >> }elseif(vma ->vm_file >> ->f_mapping >> !=folio >> ->mapping >> ){ >> return-EFAULT ; >> } >> >> But, by providing nr=1 in vma_pgoff_address(fsdax_pgoff, 1, vma), it also avoided dealing with >> >> wrap around, which perhaps doesn't matter? perhaps noone runs fsdax on 32-bit machine? > I don't understand what you're saying is wrong with this patch. > All I'm doing (apart from the renaming of ksm_addr to addr) is moving > the vma_pgoff_address() call from __add_to_kill() to its caller. > Is there some reason this doesn't work? Sorry for not being clear.   What I meant to say is that, before the patch, page_address_in_vma(p, vma) is the means for determining tk->addr, except for fsdax when filesystems made a claim of wanting to participate in the UE handling, in that case, vma_pgoff_address(fsdax_pgoff, 1, vma) is used instead. The difference between the two means is that, although the former eventually calls the latter _if_ vma->vm_file->f_mapping exists and is stable, what I am unclear from Shiyang Ruan's earlier patch is that, he seems to be concerning a case where f_mapping is not reliable, hence his patch went straight to call vma_pgoff_address(fsdax_pgoff, 1, vma), and on top of that, providing nr=1 to ignore the address wrap around case. So I don't know whether removing the fsdax special case is okay. thanks! -jane