From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC486C433F5 for ; Tue, 4 Oct 2022 14:21:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229739AbiJDOVc (ORCPT ); Tue, 4 Oct 2022 10:21:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229592AbiJDOVZ (ORCPT ); Tue, 4 Oct 2022 10:21:25 -0400 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ECACC5F223 for ; Tue, 4 Oct 2022 07:21:15 -0700 (PDT) Received: by mail-wr1-x42e.google.com with SMTP id r13so68086wrj.11 for ; Tue, 04 Oct 2022 07:21:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EBIFBYTL7bMXiKCqbN4v2KD/O06MsmUI5Kr5v5gQFes=; b=hfmhyOmo176w9X7w+jZ5ldnct3FC2G6CRaFpfD1eZTVDiNxg9OTEWDPb3SCZnSMAfq nrMDXTsKfbgaL67TN09f18QQI/ndXWz430x9nZcuetrlfTvgGLAHcW44mmPofZwyElJb IUtvPC3uJP381g9Qa6qDogdbD564rDou0fogsVgJ3/VakGFREZjv1XrH79mwxiNqjVYX ZNUmPn7VsIXRoqvvqc/+i/x/eANmFv/RBLfx2kbTEetUBOedO2szuY/a8tRc9WqsWdIu ooqxUGPTAxxEuS0OO3BYcTuk1sZBgoD6n2BPuhURaZULus1PQMScGBVe85qRy1gjwnlG JRow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EBIFBYTL7bMXiKCqbN4v2KD/O06MsmUI5Kr5v5gQFes=; b=cTl3OPOCdLwEB2Q1/qaeNIfDXWeVn18vXlf7ZtjV4da1EL57wQ0ybP+YFyM2/lgSVv nxql7CrPlwI9VTa0IGYmCw+DFGle+ZwGT7MRjgSklYIaPttAxl9dE2tGqlk/rvZgXai/ W2od86s9TSjPqxg54l+AmzkF3Hk0z+5CBjvAthLCnwOfq3Ydo6GW+ZkvH8H/qh9ip5Vi E2K4u9svc5loWHgJfqGxECruHwiZ+Jm6uJY9jZlokEXIAkumbeoMarqv0zwYSBzaQp0b aPI1mQoo1H6yUbZ1AZjHrDubh4zXTsXth/zcBnS9DDALYRoyx4KcupvLrSiXPpN53Mzn RoWA== X-Gm-Message-State: ACrzQf3O35XO2q8UJ1qsCFp9mnpGcl29SuJAhDnZ5s/2SPiykVcLKQcN n+W6PRZhV6oUFGWChzk5bFEt3w== X-Google-Smtp-Source: AMsMyM6Bbl5ITWlROk+xrtXQIPJkhHBut7dQpx6fCi9oxlSDeXsuQ9bhFGeba1NDhk/78I4Fp44Ekw== X-Received: by 2002:a05:6000:682:b0:22e:2d5f:ba9e with SMTP id bo2-20020a056000068200b0022e2d5fba9emr9735694wrb.226.1664893273994; Tue, 04 Oct 2022 07:21:13 -0700 (PDT) Received: from ?IPV6:2a05:6e02:1041:c10:c456:8337:99aa:2667? ([2a05:6e02:1041:c10:c456:8337:99aa:2667]) by smtp.googlemail.com with ESMTPSA id v13-20020a05600c214d00b003b505d26776sm18956957wml.5.2022.10.04.07.21.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Oct 2022 07:21:13 -0700 (PDT) Message-ID: <317e3cf1-2e20-d5ec-1bdc-f8537a8231d1@linaro.org> Date: Tue, 4 Oct 2022 16:21:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 4/5] thermal/core: Move the thermal zone lock out of the governors Content-Language: en-US To: Guenter Roeck Cc: rafael@kernel.org, rui.zhang@intel.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Amit Kucheria , Lukasz Luba References: <20220805153834.2510142-1-daniel.lezcano@linaro.org> <20220805153834.2510142-4-daniel.lezcano@linaro.org> <20221004141454.GA1746997@roeck-us.net> From: Daniel Lezcano In-Reply-To: <20221004141454.GA1746997@roeck-us.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/10/2022 16:14, Guenter Roeck wrote: > On Fri, Aug 05, 2022 at 05:38:33PM +0200, Daniel Lezcano wrote: >> All the governors throttling ops are taking/releasing the lock at the >> beginning and the end of the function. >> >> We can move the mutex to the throttling call site instead. >> >> Signed-off-by: Daniel Lezcano >> --- >> drivers/thermal/gov_bang_bang.c | 4 +--- >> drivers/thermal/gov_fair_share.c | 4 +--- >> drivers/thermal/gov_power_allocator.c | 16 ++++++---------- >> drivers/thermal/gov_step_wise.c | 4 +--- >> drivers/thermal/thermal_core.c | 2 ++ > > This doesn't drop the lock from drivers/thermal/gov_user_space.c. > Is that on purpose ? No, it is an oversight. It was fixed after by Rafael -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog