All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ayaka <ayaka@soulik.info>
To: John Youn <John.Youn@synopsys.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"felipe.balbi@linux.intel.com" <felipe.balbi@linux.intel.com>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"heiko@sntech.de" <heiko@sntech.de>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-rockchip@lists.infradead.org" 
	<linux-rockchip@lists.infradead.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"randy.li@rock-chips.com" <randy.li@rock-chips.com>
Subject: Re: [PATCH v7 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform
Date: Wed, 7 Sep 2016 09:19:07 +0800	[thread overview]
Message-ID: <31806DDB-EBF1-4839-81E1-5F7A1D236538@soulik.info> (raw)
In-Reply-To: <ba3e8239-6909-9de1-9cc5-f7ae80825f58@synopsys.com>



從我的 iPad 傳送

> John Youn <John.Youn@synopsys.com> 於 2016年9月7日 上午2:54 寫道:
> 
>> On 9/5/2016 10:15 PM, Kishon Vijay Abraham I wrote:
>> Hi,
>> 
>>> On Sunday 04 September 2016 03:25 AM, Randy Li wrote:
>>> On the rk3288 USB host-only port (the one that's not the OTG-enabled
>>> port) the PHY can get into a bad state when a wakeup is asserted (not
>>> just a wakeup from full system suspend but also a wakeup from
>>> autosuspend).
>>> 
>>> We can get the PHY out of its bad state by asserting its "port reset",
>>> but unfortunately that seems to assert a reset onto the USB bus so it
>>> could confuse things if we don't actually deenumerate / reenumerate the
>>> device.
>>> 
>>> We can also get the PHY out of its bad state by fully resetting it using
>>> the reset from the CRU (clock reset unit) in chip, which does a more full
>>> reset.  The CRU-based reset appears to actually cause devices on the bus
>>> to be removed and reinserted, which fixes the problem (albeit in a hacky
>>> way).
>>> 
>>> It's unfortunate that we need to do a full re-enumeration of devices at
>>> wakeup time, but this is better than alternative of letting the bus get
>>> wedged.
>>> 
>>> Signed-off-by: Randy Li <ayaka@soulik.info>
>>> ---
>>> drivers/usb/dwc2/core_intr.c | 12 ++++++++++++
>>> 1 file changed, 12 insertions(+)
>>> 
>>> diff --git a/drivers/usb/dwc2/core_intr.c b/drivers/usb/dwc2/core_intr.c
>>> index d85c5c9..08485b7 100644
>>> --- a/drivers/usb/dwc2/core_intr.c
>>> +++ b/drivers/usb/dwc2/core_intr.c
>>> @@ -345,6 +345,7 @@ static void dwc2_handle_session_req_intr(struct dwc2_hsotg *hsotg)
>>> static void dwc2_handle_wakeup_detected_intr(struct dwc2_hsotg *hsotg)
>>> {
>>>    int ret;
>>> +    struct device_node *np = hsotg->dev->of_node;
>>> 
>>>    /* Clear interrupt */
>>>    dwc2_writel(GINTSTS_WKUPINT, hsotg->regs + GINTSTS);
>>> @@ -379,6 +380,17 @@ static void dwc2_handle_wakeup_detected_intr(struct dwc2_hsotg *hsotg)
>>>            /* Restart the Phy Clock */
>>>            pcgcctl &= ~PCGCTL_STOPPCLK;
>>>            dwc2_writel(pcgcctl, hsotg->regs + PCGCTL);
>>> +
>>> +            /*
>>> +             * It is a quirk in Rockchip RK3288, causing by
>>> +             * a hardware bug. This will propagate out and
>>> +             * eventually we'll re-enumerate the device. 
>>> +             * Not great but the best we can do 
>>> +             */
>>> +            if (of_device_is_compatible(np, "rockchip,rk3288-usb")
>>> +                    && (NULL != hsotg->phy->ops->reset))
>>> +                hsotg->phy->ops->reset(hsotg->phy);
>> 
>> never call the phy ops directly from the controller driver. It has to be
>> protected as well.
> 
> It looks like we should be calling an API function instead, correct?
> 
Could you give me a example for the wrapper of phy ops?
> Similar to the wrappers for the other ops.
> 
> Regards,
> John

WARNING: multiple messages have this Message-ID
From: Ayaka <ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org>
To: John Youn <John.Youn-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
Cc: "mark.rutland-5wv7dgnIgG8@public.gmane.org"
	<mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org"
	<heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
	"felipe.balbi-VuQAYsv1563Yd54FQh9/CA@public.gmane.org"
	<felipe.balbi-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	"gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org"
	<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
	"linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"randy.li-TNX95d0MmH7DzftRWevZcw@public.gmane.org"
	<randy.li-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org>,
	"linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	"robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
	<robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH v7 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform
Date: Wed, 7 Sep 2016 09:19:07 +0800	[thread overview]
Message-ID: <31806DDB-EBF1-4839-81E1-5F7A1D236538@soulik.info> (raw)
In-Reply-To: <ba3e8239-6909-9de1-9cc5-f7ae80825f58-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>



從我的 iPad 傳送

> John Youn <John.Youn@synopsys.com> 於 2016年9月7日 上午2:54 寫道:
> 
>> On 9/5/2016 10:15 PM, Kishon Vijay Abraham I wrote:
>> Hi,
>> 
>>> On Sunday 04 September 2016 03:25 AM, Randy Li wrote:
>>> On the rk3288 USB host-only port (the one that's not the OTG-enabled
>>> port) the PHY can get into a bad state when a wakeup is asserted (not
>>> just a wakeup from full system suspend but also a wakeup from
>>> autosuspend).
>>> 
>>> We can get the PHY out of its bad state by asserting its "port reset",
>>> but unfortunately that seems to assert a reset onto the USB bus so it
>>> could confuse things if we don't actually deenumerate / reenumerate the
>>> device.
>>> 
>>> We can also get the PHY out of its bad state by fully resetting it using
>>> the reset from the CRU (clock reset unit) in chip, which does a more full
>>> reset.  The CRU-based reset appears to actually cause devices on the bus
>>> to be removed and reinserted, which fixes the problem (albeit in a hacky
>>> way).
>>> 
>>> It's unfortunate that we need to do a full re-enumeration of devices at
>>> wakeup time, but this is better than alternative of letting the bus get
>>> wedged.
>>> 
>>> Signed-off-by: Randy Li <ayaka@soulik.info>
>>> ---
>>> drivers/usb/dwc2/core_intr.c | 12 ++++++++++++
>>> 1 file changed, 12 insertions(+)
>>> 
>>> diff --git a/drivers/usb/dwc2/core_intr.c b/drivers/usb/dwc2/core_intr.c
>>> index d85c5c9..08485b7 100644
>>> --- a/drivers/usb/dwc2/core_intr.c
>>> +++ b/drivers/usb/dwc2/core_intr.c
>>> @@ -345,6 +345,7 @@ static void dwc2_handle_session_req_intr(struct dwc2_hsotg *hsotg)
>>> static void dwc2_handle_wakeup_detected_intr(struct dwc2_hsotg *hsotg)
>>> {
>>>    int ret;
>>> +    struct device_node *np = hsotg->dev->of_node;
>>> 
>>>    /* Clear interrupt */
>>>    dwc2_writel(GINTSTS_WKUPINT, hsotg->regs + GINTSTS);
>>> @@ -379,6 +380,17 @@ static void dwc2_handle_wakeup_detected_intr(struct dwc2_hsotg *hsotg)
>>>            /* Restart the Phy Clock */
>>>            pcgcctl &= ~PCGCTL_STOPPCLK;
>>>            dwc2_writel(pcgcctl, hsotg->regs + PCGCTL);
>>> +
>>> +            /*
>>> +             * It is a quirk in Rockchip RK3288, causing by
>>> +             * a hardware bug. This will propagate out and
>>> +             * eventually we'll re-enumerate the device. 
>>> +             * Not great but the best we can do 
>>> +             */
>>> +            if (of_device_is_compatible(np, "rockchip,rk3288-usb")
>>> +                    && (NULL != hsotg->phy->ops->reset))
>>> +                hsotg->phy->ops->reset(hsotg->phy);
>> 
>> never call the phy ops directly from the controller driver. It has to be
>> protected as well.
> 
> It looks like we should be calling an API function instead, correct?
> 
Could you give me a example for the wrapper of phy ops?
> Similar to the wrappers for the other ops.
> 
> Regards,
> John


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2016-09-07  1:20 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-03 21:55 [PATCH v7 0/4] the fix for the USB HOST1 at " Randy Li
2016-09-03 21:55 ` Randy Li
2016-09-03 21:55 ` [PATCH v7 1/4] phy: Add reset callback Randy Li
2016-09-03 21:55   ` Randy Li
2016-09-03 21:55 ` [PATCH v7 2/4] phy: rockchip-usb: use rockchip_usb_phy_reset to reset phy during wakeup Randy Li
2016-09-03 21:55   ` Randy Li
2016-09-03 21:55 ` [PATCH v7 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform Randy Li
2016-09-03 21:55   ` Randy Li
2016-09-03 22:08   ` Sergei Shtylyov
2016-09-03 22:08     ` Sergei Shtylyov
2016-09-05 13:35   ` David Laight
2016-09-05 13:35     ` David Laight
2016-09-05 23:38     ` Ayaka
2016-09-05 23:38       ` Ayaka
2016-09-06  5:14   ` Kishon Vijay Abraham I
2016-09-06  5:14     ` Kishon Vijay Abraham I
2016-09-06 18:54     ` John Youn
2016-09-06 18:54       ` John Youn
2016-09-07  1:19       ` Ayaka [this message]
2016-09-07  1:19         ` Ayaka
2016-09-07  2:02         ` John Youn
2016-09-07  2:02           ` John Youn
2016-09-03 21:55 ` [PATCH v7 4/4] ARM: dts: rockchip: Point rk3288 dwc2 usb at the full PHY reset Randy Li
2016-09-03 21:55   ` Randy Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=31806DDB-EBF1-4839-81E1-5F7A1D236538@soulik.info \
    --to=ayaka@soulik.info \
    --cc=John.Youn@synopsys.com \
    --cc=devicetree@vger.kernel.org \
    --cc=felipe.balbi@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heiko@sntech.de \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=randy.li@rock-chips.com \
    --cc=robh+dt@kernel.org \
    --subject='Re: [PATCH v7 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.