Re: [PATCH 2/6] scsi: ufs: ufs-qcom: Add support for UFS device version detection

From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Can Guo <quic_cang@quicinc.com>,
	mani@kernel.org, quic_nguyenb@quicinc.com,
	quic_nitirawa@quicinc.com, martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"open list:UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER..." 
	<linux-arm-msm@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/6] scsi: ufs: ufs-qcom: Add support for UFS device version detection
Date: Mon, 11 Sep 2023 11:46:20 +0200	[thread overview]
Message-ID: <31823dc4-6f50-435b-9a20-66471209ec31@linaro.org> (raw)
In-Reply-To: <6225a132-4b7f-bbb4-e863-4e62b99dd79d@quicinc.com>

On 11.09.2023 11:42, Can Guo wrote:
> Hi Konrad,
> 
> On 9/11/2023 5:17 PM, Konrad Dybcio wrote:
>> On 11.09.2023 07:59, Can Guo wrote:
>>> From: "Bao D. Nguyen" <quic_nguyenb@quicinc.com>
>>>
>>> Retrieve UFS device version from UFS host controller's spare register
>>> which is populated by bootloader, and use the UFS device version together
>>> with host controller's HW version to decide the proper power modes which
>>> should be used to configure the UFS PHY.
>> That sounds a bit fishy.. is there no bootloader-independent
>> solution to that? Can't we bring in the code that the bootloader
>> uses to determine these values?
>>
>> Konrad
> 
> 
> Agree, it is.
> 
> 
> All these complexities come from one request from PHY design team - power saving.
> 
> And to achieve power saving, Qualcomm UFS developers are requested to use the
> 
> lowest hanging PHY settings which can sustain the Max agreed HS Gear (btw host
> 
> and UFS device) during UFS's lifecycle in High Level OS,  whereas the power saving
> 
> request does not apply to bootloader, which works for only a few seconds during
> 
> bootup. Hence, there is no such version detect code in bootloader -  it just uses the
> 
> highest PHY settings to configure PHY, boot up UFS and put UFS device version in this
> 
> register.
First of all, your email client seems to be inserting 2 newlines
instead of 1. If you're using thunderbird, you may want to edit:

mail.identity.(default or your mail identity idx).default.compose_html

to `false`

and add that to your internal wiki page, as I see many @quic folks having
this issue.

Going back to the main topic, I don't think we understood each other.
The commit message states:

"Retrieve UFS device version from UFS host controller's spare register
which is populated by bootloader"

Which means the bootloader is able to somehow determine the value
that's in the spare register and write it there.

I'm asking whether we can take the logic behind this value and
move it to Linux so that we don't depend on the bootloader to
guarantee it (e.g. Chrome or some other devices with more exotic
fw may not work this way).

Konrad