From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sameer Pujar Subject: Re: [alsa-devel] [PATCH 4/9] ASoC: tegra: add Tegra210 based I2S driver Date: Wed, 19 Feb 2020 21:40:09 +0530 Message-ID: <319a0922-3de2-5d02-65c3-d96036eea6d9@nvidia.com> References: <1579530198-13431-1-git-send-email-spujar@nvidia.com> <1579530198-13431-5-git-send-email-spujar@nvidia.com> <0c571858-d72c-97c2-2d6a-ead6fdde06eb@nvidia.com> <444731da-c4cd-8578-a732-c803eef31ef0@gmail.com> <598fe377-5b95-d30a-eb64-89a645166d42@gmail.com> <3f51939d-cf4b-f69b-728a-7eb99bbae458@nvidia.com> <34ac1fd3-ae0f-07f2-555f-a55087a2c9dc@nvidia.com> <1a84b393-938f-8bed-d08e-cc3bb6ed4844@gmail.com> <0fc814c2-0dc6-7741-b954-463381ff7fb9@nvidia.com> <9f73afdf-1e9a-cdbd-f972-a022d503ef51@nvidia.com> <264d3354-8a2e-ee12-44ae-aff69213d551@nvidia.com> <075e476a-36bb-5fee-15bc-76af4474a797@gmail.com> <3b42c858-733b-0d17-f457-8043d97f5058@gmail.com> <62b8ffbc-aa32-ae44-6cb4-b176b8ba9b0e@nvidia.com> <847739f8-6f54-cf64-54b8-94707944850b@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <847739f8-6f54-cf64-54b8-94707944850b-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Content-Language: en-GB Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dmitry Osipenko , Jon Hunter Cc: spujar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, atalambedu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, tiwai-IBi9RG/b67k@public.gmane.org, viswanathl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, sharadg-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, rlokhande-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, mkumard-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, dramesh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 2/18/2020 6:30 AM, Dmitry Osipenko wrote: > External email: Use caution opening links or attachments > > > 14.02.2020 17:05, Jon Hunter =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >> On 29/01/2020 03:41, Dmitry Osipenko wrote: >> >> ... >> >>> The !RPM case isn't supported by Tegra anymore in upstream kernel. I'm >>> trying to help to make yours driver better and gave you reasons to >>> remove the unneeded code, while you're keep saying that "there is no >>> harm to retain it", which is not a reason to clutter up the code. I >>> don't feel that it's worthwhile to continue arguing here. >> On further review, it does look like a reasonable argument to get rid of >> this now completely. Like you see less clutter and the soc-core should >> ensure that the card is shutdown before unloading. OK, so fine with me. > And the RPM core ensures that state is synced on disable, sorry if I > didn't make it clear before. > > +1 for less clutter :) Done, I am removing explicit RPM suspend in the next revision. Thanks=20 Dmitry and Jon. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDDF8C34050 for ; Wed, 19 Feb 2020 16:10:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C6E0F24654 for ; Wed, 19 Feb 2020 16:10:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="YRz9DrxY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726756AbgBSQKZ (ORCPT ); Wed, 19 Feb 2020 11:10:25 -0500 Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:18562 "EHLO hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726514AbgBSQKZ (ORCPT ); Wed, 19 Feb 2020 11:10:25 -0500 Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Wed, 19 Feb 2020 08:09:51 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Wed, 19 Feb 2020 08:10:24 -0800 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Wed, 19 Feb 2020 08:10:24 -0800 Received: from [10.25.75.111] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 19 Feb 2020 16:10:14 +0000 CC: , , , , , , , , , , , , , , , Subject: Re: [alsa-devel] [PATCH 4/9] ASoC: tegra: add Tegra210 based I2S driver To: Dmitry Osipenko , Jon Hunter References: <1579530198-13431-1-git-send-email-spujar@nvidia.com> <1579530198-13431-5-git-send-email-spujar@nvidia.com> <0c571858-d72c-97c2-2d6a-ead6fdde06eb@nvidia.com> <444731da-c4cd-8578-a732-c803eef31ef0@gmail.com> <598fe377-5b95-d30a-eb64-89a645166d42@gmail.com> <3f51939d-cf4b-f69b-728a-7eb99bbae458@nvidia.com> <34ac1fd3-ae0f-07f2-555f-a55087a2c9dc@nvidia.com> <1a84b393-938f-8bed-d08e-cc3bb6ed4844@gmail.com> <0fc814c2-0dc6-7741-b954-463381ff7fb9@nvidia.com> <9f73afdf-1e9a-cdbd-f972-a022d503ef51@nvidia.com> <264d3354-8a2e-ee12-44ae-aff69213d551@nvidia.com> <075e476a-36bb-5fee-15bc-76af4474a797@gmail.com> <3b42c858-733b-0d17-f457-8043d97f5058@gmail.com> <62b8ffbc-aa32-ae44-6cb4-b176b8ba9b0e@nvidia.com> <847739f8-6f54-cf64-54b8-94707944850b@gmail.com> From: Sameer Pujar Message-ID: <319a0922-3de2-5d02-65c3-d96036eea6d9@nvidia.com> Date: Wed, 19 Feb 2020 21:40:09 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <847739f8-6f54-cf64-54b8-94707944850b@gmail.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-GB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1582128591; bh=Y4IVG9EdM9GGqYVDnKSi7S7GV3/7tEnqSahIk5yOcYk=; h=X-PGP-Universal:CC:Subject:To:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding: Content-Language; b=YRz9DrxYbhYO6MTRtYvDuHjxISyreNHeLWM8zCWFBDDruqQ7Iu/eWxWcpvrSipAeN +y1QGqIhOVyKFac4zZXp91ebRRec/wz5LQD9o107Ixrks2W4G92ivh3VWFmmT7y/rn fS2qsZQFF36hhMiEBBEhcg/GFGcrYiNQb4RZF2O624d0UvCmvR5ul6qKf+PBYdwWcg JwnX7UiisfcEa6rwlhs5yQTsza33PiBpoZIydDJecnDrCyppBbpk2nc4AZ+X797Va2 kRck5XiZTa3GPHWP+xfSbLUeCSCTquzreb9s3RTCFY3SNL/0l1bHFcF0ZsEI6rxT1a wgbd5x3qJtG6Q== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/18/2020 6:30 AM, Dmitry Osipenko wrote: > External email: Use caution opening links or attachments > > > 14.02.2020 17:05, Jon Hunter =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >> On 29/01/2020 03:41, Dmitry Osipenko wrote: >> >> ... >> >>> The !RPM case isn't supported by Tegra anymore in upstream kernel. I'm >>> trying to help to make yours driver better and gave you reasons to >>> remove the unneeded code, while you're keep saying that "there is no >>> harm to retain it", which is not a reason to clutter up the code. I >>> don't feel that it's worthwhile to continue arguing here. >> On further review, it does look like a reasonable argument to get rid of >> this now completely. Like you see less clutter and the soc-core should >> ensure that the card is shutdown before unloading. OK, so fine with me. > And the RPM core ensures that state is synced on disable, sorry if I > didn't make it clear before. > > +1 for less clutter :) Done, I am removing explicit RPM suspend in the next revision. Thanks=20 Dmitry and Jon. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10DD2C34047 for ; Wed, 19 Feb 2020 16:11:24 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9016724670 for ; Wed, 19 Feb 2020 16:11:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="k/UfAkFq"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="YRz9DrxY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9016724670 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id DD564167D; Wed, 19 Feb 2020 17:10:31 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz DD564167D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1582128681; bh=Y4IVG9EdM9GGqYVDnKSi7S7GV3/7tEnqSahIk5yOcYk=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=k/UfAkFqZZ9igGNIDCigSZ603EJR+a/IxPgeJln386tqeC01FdU6MofEQoOi+QOky E2tS81GWrQTdKqOMxVFqpnv8cC6FxUgZ7QhRSHVhM5CK0HgHJnm2vP6CWsxtxdWaQQ ofJ9/Z+hRgDVMLCDDhkAJ4rrqLfHe4O5AOtZ3980= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 7D3D9F80276; Wed, 19 Feb 2020 17:10:31 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7EC92F80277; Wed, 19 Feb 2020 17:10:30 +0100 (CET) Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 85D41F8025F for ; Wed, 19 Feb 2020 17:10:26 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 85D41F8025F Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="YRz9DrxY" Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Wed, 19 Feb 2020 08:09:51 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Wed, 19 Feb 2020 08:10:24 -0800 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Wed, 19 Feb 2020 08:10:24 -0800 Received: from [10.25.75.111] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 19 Feb 2020 16:10:14 +0000 Subject: Re: [alsa-devel] [PATCH 4/9] ASoC: tegra: add Tegra210 based I2S driver To: Dmitry Osipenko , Jon Hunter References: <1579530198-13431-1-git-send-email-spujar@nvidia.com> <1579530198-13431-5-git-send-email-spujar@nvidia.com> <0c571858-d72c-97c2-2d6a-ead6fdde06eb@nvidia.com> <444731da-c4cd-8578-a732-c803eef31ef0@gmail.com> <598fe377-5b95-d30a-eb64-89a645166d42@gmail.com> <3f51939d-cf4b-f69b-728a-7eb99bbae458@nvidia.com> <34ac1fd3-ae0f-07f2-555f-a55087a2c9dc@nvidia.com> <1a84b393-938f-8bed-d08e-cc3bb6ed4844@gmail.com> <0fc814c2-0dc6-7741-b954-463381ff7fb9@nvidia.com> <9f73afdf-1e9a-cdbd-f972-a022d503ef51@nvidia.com> <264d3354-8a2e-ee12-44ae-aff69213d551@nvidia.com> <075e476a-36bb-5fee-15bc-76af4474a797@gmail.com> <3b42c858-733b-0d17-f457-8043d97f5058@gmail.com> <62b8ffbc-aa32-ae44-6cb4-b176b8ba9b0e@nvidia.com> <847739f8-6f54-cf64-54b8-94707944850b@gmail.com> From: Sameer Pujar Message-ID: <319a0922-3de2-5d02-65c3-d96036eea6d9@nvidia.com> Date: Wed, 19 Feb 2020 21:40:09 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <847739f8-6f54-cf64-54b8-94707944850b@gmail.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-GB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1582128591; bh=Y4IVG9EdM9GGqYVDnKSi7S7GV3/7tEnqSahIk5yOcYk=; h=X-PGP-Universal:CC:Subject:To:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding: Content-Language; b=YRz9DrxYbhYO6MTRtYvDuHjxISyreNHeLWM8zCWFBDDruqQ7Iu/eWxWcpvrSipAeN +y1QGqIhOVyKFac4zZXp91ebRRec/wz5LQD9o107Ixrks2W4G92ivh3VWFmmT7y/rn fS2qsZQFF36hhMiEBBEhcg/GFGcrYiNQb4RZF2O624d0UvCmvR5ul6qKf+PBYdwWcg JwnX7UiisfcEa6rwlhs5yQTsza33PiBpoZIydDJecnDrCyppBbpk2nc4AZ+X797Va2 kRck5XiZTa3GPHWP+xfSbLUeCSCTquzreb9s3RTCFY3SNL/0l1bHFcF0ZsEI6rxT1a wgbd5x3qJtG6Q== Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, spujar@nvidia.com, tiwai@suse.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, lgirdwood@gmail.com, viswanathl@nvidia.com, sharadg@nvidia.com, broonie@kernel.org, atalambedu@nvidia.com, linux-tegra@vger.kernel.org, thierry.reding@gmail.com, rlokhande@nvidia.com, mkumard@nvidia.com, dramesh@nvidia.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 2/18/2020 6:30 AM, Dmitry Osipenko wrote: > External email: Use caution opening links or attachments > > > 14.02.2020 17:05, Jon Hunter =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >> On 29/01/2020 03:41, Dmitry Osipenko wrote: >> >> ... >> >>> The !RPM case isn't supported by Tegra anymore in upstream kernel. I'm >>> trying to help to make yours driver better and gave you reasons to >>> remove the unneeded code, while you're keep saying that "there is no >>> harm to retain it", which is not a reason to clutter up the code. I >>> don't feel that it's worthwhile to continue arguing here. >> On further review, it does look like a reasonable argument to get rid of >> this now completely. Like you see less clutter and the soc-core should >> ensure that the card is shutdown before unloading. OK, so fine with me. > And the RPM core ensures that state is synced on disable, sorry if I > didn't make it clear before. > > +1 for less clutter :) Done, I am removing explicit RPM suspend in the next revision. Thanks=20 Dmitry and Jon.