All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
	Andrey Ignatov <rdna@apple.com>
Cc: dev@dpdk.org, Chenbo Xia <chenbox@nvidia.com>,
	Wei Shen <wshen0123@apple.com>
Subject: Re: [PATCH] vhost: optimize mbuf allocation in virtio Tx packed path
Date: Fri, 29 Mar 2024 14:04:40 +0100	[thread overview]
Message-ID: <319d86b3-c860-4231-b263-732aa4051531@redhat.com> (raw)
In-Reply-To: <20240328195353.0dc838be@hermes.local>

Hi Stephen,

On 3/29/24 03:53, Stephen Hemminger wrote:
> On Thu, 28 Mar 2024 17:10:42 -0700
> Andrey Ignatov <rdna@apple.com> wrote:
> 
>>>
>>> You don't need always inline, the compiler will do it anyway.
>>
>> I can remove it in v2, but it's not completely obvious to me how is it
>> decided when to specify it explicitly and when not?
>>
>> I see plenty of __rte_always_inline in this file:
>>
>> % git grep -c '^static __rte_always_inline' lib/vhost/virtio_net.c
>> lib/vhost/virtio_net.c:66
> 
> 
> Cargo cult really.
> 

Cargo cult... really?

Well, I just did a quick test by comparing IO forwarding with testpmd
between main branch and with adding a patch that removes all the
inline/noinline in lib/vhost/virtio_net.c [0].

main branch: 14.63Mpps
main branch - inline/noinline: 10.24Mpps

Andrey, thanks for the patch, I'll have a look at it next week.

Maxime

[0]: https://pastebin.com/72P2npZ0


  reply	other threads:[~2024-03-29 13:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-28 23:33 [PATCH] vhost: optimize mbuf allocation in virtio Tx packed path Andrey Ignatov
2024-03-28 23:44 ` Stephen Hemminger
2024-03-29  0:10   ` Andrey Ignatov
2024-03-29  2:53     ` Stephen Hemminger
2024-03-29 13:04       ` Maxime Coquelin [this message]
2024-03-29 13:42         ` The effect of inlining Morten Brørup
2024-03-29 20:26           ` Tyler Retzlaff
2024-04-01 15:20           ` Mattias Rönnblom
2024-04-03 16:01             ` Morten Brørup
2024-04-03 10:19 ` [PATCH] vhost: optimize mbuf allocation in virtio Tx packed path Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=319d86b3-c860-4231-b263-732aa4051531@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=chenbox@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=rdna@apple.com \
    --cc=stephen@networkplumber.org \
    --cc=wshen0123@apple.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.