From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59680C83007 for ; Wed, 29 Apr 2020 21:53:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 35C1E20757 for ; Wed, 29 Apr 2020 21:53:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727815AbgD2VxM (ORCPT ); Wed, 29 Apr 2020 17:53:12 -0400 Received: from smtprelay0210.hostedemail.com ([216.40.44.210]:60898 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726911AbgD2VxK (ORCPT ); Wed, 29 Apr 2020 17:53:10 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay03.hostedemail.com (Postfix) with ESMTP id 88EC8837F253; Wed, 29 Apr 2020 21:53:09 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: jump77_1b7053dcfbe42 X-Filterd-Recvd-Size: 2010 Received: from XPS-9350.home (unknown [47.151.136.130]) (Authenticated sender: joe@perches.com) by omf06.hostedemail.com (Postfix) with ESMTPA; Wed, 29 Apr 2020 21:53:08 +0000 (UTC) Message-ID: <31b23951ee2b8e2391f3208b60a7132df18be74e.camel@perches.com> Subject: Re: [PATCH 03/10] efi/x86: Use pr_efi_err for error messages From: Joe Perches To: Arvind Sankar , Ard Biesheuvel Cc: linux-efi , X86 ML , Linux Kernel Mailing List Date: Wed, 29 Apr 2020 14:53:07 -0700 In-Reply-To: <20200429214332.GC1621173@rani.riverdale.lan> References: <20200429174120.1497212-1-nivedita@alum.mit.edu> <20200429174120.1497212-5-nivedita@alum.mit.edu> <20200429214332.GC1621173@rani.riverdale.lan> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2020-04-29 at 17:43 -0400, Arvind Sankar wrote: > On Wed, Apr 29, 2020 at 08:49:21PM +0200, Ard Biesheuvel wrote: > > On Wed, 29 Apr 2020 at 20:47, Joe Perches wrote: > > > On Wed, 2020-04-29 at 13:41 -0400, Arvind Sankar wrote: > > > > Use pr_efi_err instead of bare efi_printk for error messages. > > > > > > Perhaps it'd be better to rename pr_efi_err to eri_err > > > so it's clearer it's a typical efi_ logging function. > > > > > > $ git grep -w --name-only pr_efi_err | \ > > > xargs sed -i 's/\bpr_efi_err\b/efi_err/g' > > > > > > > Yeah, pr_efi_err() is probably not the best name > > Should I rename pr_efi/pr_efi_err to, say, efi_pr_info/efi_pr_error? Perhaps not use pr_ in the name at all. I suggest: pr_efi -> efi_info (or efi_debug or efi_dbg) (it is guarded by an efi_quiet flag, default: on) pr_efi_err -> efi_err