All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nirmoy <nirmodas@amd.com>
To: "Alex Deucher" <alexdeucher@gmail.com>,
	"Christian König" <christian.koenig@amd.com>
Cc: "Deucher, Alexander" <alexander.deucher@amd.com>,
	Huang Rui <Ray.Huang@amd.com>, Nirmoy Das <nirmoy.das@amd.com>,
	amd-gfx list <amd-gfx@lists.freedesktop.org>,
	Nirmoy Das <nirmoy.aiemd@gmail.com>
Subject: Re: [RFC PATCH 2/3] drm/amdgpu: change hw sched list on ctx priority override
Date: Thu, 27 Feb 2020 21:31:57 +0100	[thread overview]
Message-ID: <31b82a5a-4767-1a4b-b74c-61179a52b9e8@amd.com> (raw)
In-Reply-To: <CADnq5_PPqDGn2rP6ep6aEHgjow5mkKUp1=FLLo_mDn-QEsN1KA@mail.gmail.com>


On 2/27/20 3:35 PM, Alex Deucher wrote:
> We shouldn't be changing this at runtime.  We need to set up the queue
> priority at init time and then schedule to the appropriate quueue at
> runtime.  We set the pipe/queue priority in the mqd (memory queue
> descriptor).  When we init the rings we configure the mqds in memory
> and then tell the CP to configure the rings.  The CP then fetches the
> config from memory (the mqd) and pushes the configuration to the hqd
> (hardware queue descriptor).  Currrently we just statically set up the
> queues at driver init time, but the hw has the capability to schedule
> queues dynamically at runtime.  E.g., we could have a per process mqd
> for each queue and then tell the CP to schedule the mqd on the
> hardware at runtime.  For now, I think we should just set up some
> static pools of rings (e.g., normal and high priority or low, normal,
> and high priorities).  Note that you probably want to keep the high
> priority queues on a different pipe from the low/normal priority
> queues.  Depending on the asic there are 1 or 2 MECs (compute micro
> engines) and each MEC supports 4 pipes.  Each pipe can handle up to 8
> queues.

After some debugging I realized we have amdgpu_gfx_compute_queue_acquire()

which forces amdgpu to only use queue 0,1 of every pipe form MEC 0 even 
if we

have more than 1 MEC.


Does it make sense to have two high priority queue on the same pipe ?

Regards,

Nirmoy


> Alex
>
>>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  reply	other threads:[~2020-02-27 20:28 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-26 20:37 [RFC PATCH 0/3] cleanup compute queue priority setting Nirmoy Das
2020-02-26 20:37 ` [RFC PATCH 1/3] drm/amdgpu: implement ring init_priority for compute ring Nirmoy Das
2020-02-27  4:44   ` Alex Deucher
2020-02-27  9:57     ` Nirmoy
2020-02-27  9:55       ` Christian König
2020-02-28  3:29   ` Luben Tuikov
2020-02-28  7:38     ` Christian König
2020-03-02 20:25       ` Luben Tuikov
2020-03-02 21:09         ` Alex Deucher
2020-02-26 20:37 ` [RFC PATCH 2/3] drm/amdgpu: change hw sched list on ctx priority override Nirmoy Das
2020-02-27 10:08   ` Christian König
2020-02-27 10:26     ` Nirmoy
2020-02-27 11:35       ` Christian König
2020-02-27 14:35     ` Alex Deucher
2020-02-27 20:31       ` Nirmoy [this message]
2020-02-27 21:02         ` Alex Deucher
2020-02-27 21:17           ` Nirmoy
2020-02-27 10:10   ` Nirmoy
2020-02-28  4:00   ` Luben Tuikov
2020-02-26 20:37 ` [RFC PATCH 3/3] drm/amdgpu: remove unused functions Nirmoy Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=31b82a5a-4767-1a4b-b74c-61179a52b9e8@amd.com \
    --to=nirmodas@amd.com \
    --cc=Ray.Huang@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=alexdeucher@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=nirmoy.aiemd@gmail.com \
    --cc=nirmoy.das@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.