From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C54CC4338F for ; Wed, 28 Jul 2021 10:46:20 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9468F60F01 for ; Wed, 28 Jul 2021 10:46:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9468F60F01 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E71586E511; Wed, 28 Jul 2021 10:46:18 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 31E116E511 for ; Wed, 28 Jul 2021 10:46:18 +0000 (UTC) Received: from [192.168.0.20] (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id F37F33F; Wed, 28 Jul 2021 12:46:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1627469176; bh=sgOIP5yZ6bNntnXeqgApXy/KqgqqWSdFfSwWkBLFAGo=; h=From:To:Cc:References:Subject:Date:In-Reply-To:From; b=mGMisZ05sm1vybgEovo45kuyf1kmuvcdrl9cLTGoWgfjNWO/4yNSz/iXsg7cVxjA1 NqVNDNyPuOXBL7gPA/d41rJ1lXF2ZF6lVSafIFynlwwl/Fm//cHVGi0EbqyGW/bMdc ND3wleaa1vAdjNqCxuaw6FPoWIybvoRbIqe6COo8= From: Kieran Bingham To: Jackie Liu , laurent.pinchart@ideasonboard.com, dri-devel@lists.freedesktop.org References: <20210728084240.566677-1-liu.yun@linux.dev> <3f8127f2-69b4-0faa-bee8-5f6c6ed10606@linux.dev> Subject: Re: [PATCH] drm: rcar-du: crtc: force depends on cmm Message-ID: <31da5d37-6a81-c168-6284-9a4cb69d8dfb@ideasonboard.com> Date: Wed, 28 Jul 2021 11:46:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <3f8127f2-69b4-0faa-bee8-5f6c6ed10606@linux.dev> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, liuyun01@kylinos.cn, kieran.bingham+renesas@ideasonboard.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 28/07/2021 10:34, Jackie Liu wrote: > Hi Kieran. > > Thanks for replying to the email so quickly. > > 在 2021/7/28 下午4:58, Kieran Bingham 写道: >> Hi Jackie, >> >> On 28/07/2021 09:42, Jackie Liu wrote: >>> From: Jackie Liu >>> >>> After the patch 78b6bb1d24db ("drm: rcar-du: crtc: Control CMM >>> operations"), >>> the cmm module must be included in the crtc. We cannot remove this >>> configuration option separately. Therefore, simply linking them together >>> is the best solution, otherwise some errors will be reported. >>> >> >> Yikes, I'm sure we've had plenty of problems with the config options on >> this module. The churn alone makes me wonder if it should just be part >> of the overall module to simplify things... but... >> >>>   rcar_du_crtc.c:(.text+0x194): undefined reference to `rcar_cmm_setup' >>>   rcar_du_crtc.c:(.text+0x11bc): undefined reference to >>> `rcar_cmm_enable' >>>   rcar_du_crtc.c:(.text+0x1604): undefined reference to >>> `rcar_cmm_disable' >>>   rcar_du_kms.c:(.text+0x768): undefined reference to `rcar_cmm_init' >> >> Those are guarded by #if IS_ENABLED in the header. >> >> So from that - perhaps we can assume that the config attempted here was >> a built-in DU - but a module CMM which wouldn't be supported? > > I know you want to keep CMM as a module, I might think it’s too simple. > will rewrite the patch. There are DU's which do not have a CMM, so I think that is why it is an optional feature/module. >>> Fixes: 78b6bb1d24db ("rm: rcar-du: crtc: Control CMM operations") >> >> That fixes tag is missing a 'd', but that's trivial. > > 12 characters of sha is enough. I meant the 'd' of 'drm' (it's 'rm' in your text) > --- > BR, Thanks. > Jackie Liu > >> >> >>> Reported-by: kernel-bot >>> Signed-off-by: Jackie Liu >>> --- >>>   drivers/gpu/drm/rcar-du/Kconfig  | 8 -------- >>>   drivers/gpu/drm/rcar-du/Makefile | 2 +- >>>   2 files changed, 1 insertion(+), 9 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/rcar-du/Kconfig >>> b/drivers/gpu/drm/rcar-du/Kconfig >>> index b47e74421e34..bc71ad2a472f 100644 >>> --- a/drivers/gpu/drm/rcar-du/Kconfig >>> +++ b/drivers/gpu/drm/rcar-du/Kconfig >>> @@ -4,7 +4,6 @@ config DRM_RCAR_DU >>>       depends on DRM && OF >>>       depends on ARM || ARM64 >>>       depends on ARCH_RENESAS || COMPILE_TEST >>> -    imply DRM_RCAR_CMM >>>       imply DRM_RCAR_LVDS >>>       select DRM_KMS_HELPER >>>       select DRM_KMS_CMA_HELPER >>> @@ -14,13 +13,6 @@ config DRM_RCAR_DU >>>         Choose this option if you have an R-Car chipset. >>>         If M is selected the module will be called rcar-du-drm. >>>   -config DRM_RCAR_CMM >>> -    tristate "R-Car DU Color Management Module (CMM) Support" >>> -    depends on DRM && OF >>> -    depends on DRM_RCAR_DU >>> -    help >>> -      Enable support for R-Car Color Management Module (CMM). >>> - >> >> I suspect the issue lies somewhere in this config that the CMM is not >> being enforced to be a built in when the DU is built in ? Checked locally, and indeed KConfig lets us enable the DU as a built in - but the CMM as a module - that can't be allowed. :-( -- Kieran >> >> >>>   config DRM_RCAR_DW_HDMI >>>       tristate "R-Car Gen3 and RZ/G2 DU HDMI Encoder Support" >>>       depends on DRM && OF >>> diff --git a/drivers/gpu/drm/rcar-du/Makefile >>> b/drivers/gpu/drm/rcar-du/Makefile >>> index 4d1187ccc3e5..76ff2e15bc2d 100644 >>> --- a/drivers/gpu/drm/rcar-du/Makefile >>> +++ b/drivers/gpu/drm/rcar-du/Makefile >>> @@ -5,6 +5,7 @@ rcar-du-drm-y := rcar_du_crtc.o \ >>>            rcar_du_group.o \ >>>            rcar_du_kms.o \ >>>            rcar_du_plane.o \ >>> +         rcar_cmm.o >>>     rcar-du-drm-$(CONFIG_DRM_RCAR_LVDS)    += rcar_du_of.o \ >>>                          rcar_du_of_lvds_r8a7790.dtb.o \ >>> @@ -15,7 +16,6 @@ rcar-du-drm-$(CONFIG_DRM_RCAR_LVDS)    += >>> rcar_du_of.o \ >>>   rcar-du-drm-$(CONFIG_DRM_RCAR_VSP)    += rcar_du_vsp.o >>>   rcar-du-drm-$(CONFIG_DRM_RCAR_WRITEBACK) += rcar_du_writeback.o >>>   -obj-$(CONFIG_DRM_RCAR_CMM)        += rcar_cmm.o >>>   obj-$(CONFIG_DRM_RCAR_DU)        += rcar-du-drm.o >>>   obj-$(CONFIG_DRM_RCAR_DW_HDMI)        += rcar_dw_hdmi.o >>>   obj-$(CONFIG_DRM_RCAR_LVDS)        += rcar_lvds.o >>>