From: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
To: Vadim Fedorenko <vfedorenko@novek.ru>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Boris Pismenny <borisp@nvidia.com>,
John Fastabend <john.fastabend@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH] net/tls: Fix authentication failure in CCM mode
Date: Wed, 1 Dec 2021 17:55:22 +0800 [thread overview]
Message-ID: <31dd5d45-d6cc-1074-ff55-e989f67e1016@linux.alibaba.com> (raw)
In-Reply-To: <e623a691-2212-e1cc-7fed-1c3a2043b6bd@novek.ru>
Hi Vadim,
On 11/30/21 6:39 AM, Vadim Fedorenko wrote:
> On 29.11.2021 09:32, Tianjia Zhang wrote:
>> When the TLS cipher suite uses CCM mode, including AES CCM and
>> SM4 CCM, the first byte of the B0 block is flags, and the real
>> IV starts from the second byte. The XOR operation of the IV and
>> rec_seq should be skip this byte, that is, add the iv_offset.
>>
>> Fixes: f295b3ae9f59 ("net/tls: Add support of AES128-CCM based ciphers")
>> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
>
> Nice catch, thanks!
> This is what I was talking about last time.
>
> Tested-by: Vadim Fedorenko <vfedorenko@novek.ru>
David has applied this patch, the tested tag may not be added, still
thanks for your test.
Kind regards,
Tianjia
prev parent reply other threads:[~2021-12-01 9:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 9:32 [PATCH] net/tls: Fix authentication failure in CCM mode Tianjia Zhang
2021-11-29 12:50 ` patchwork-bot+netdevbpf
2021-11-29 22:39 ` Vadim Fedorenko
2021-12-01 9:55 ` Tianjia Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31dd5d45-d6cc-1074-ff55-e989f67e1016@linux.alibaba.com \
--to=tianjia.zhang@linux.alibaba.com \
--cc=borisp@nvidia.com \
--cc=davem@davemloft.net \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vfedorenko@novek.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.