From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52A39C2BBD0 for ; Tue, 8 Sep 2020 05:14:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2CD172166E for ; Tue, 8 Sep 2020 05:14:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728632AbgIHFOw (ORCPT ); Tue, 8 Sep 2020 01:14:52 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:1177 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725938AbgIHFOw (ORCPT ); Tue, 8 Sep 2020 01:14:52 -0400 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 4Bltcl5vwGz9tyfC; Tue, 8 Sep 2020 07:14:47 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id CHegWz2Zqd7i; Tue, 8 Sep 2020 07:14:47 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 4Bltcl4S93z9tyfB; Tue, 8 Sep 2020 07:14:47 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 4FA238B78F; Tue, 8 Sep 2020 07:14:48 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id p7u0ZX_PNhu5; Tue, 8 Sep 2020 07:14:48 +0200 (CEST) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id E7EF18B768; Tue, 8 Sep 2020 07:14:45 +0200 (CEST) Subject: Re: [RFC PATCH v2 2/3] mm: make pXd_addr_end() functions page-table entry aware To: Gerald Schaefer , Jason Gunthorpe , John Hubbard Cc: Peter Zijlstra , Dave Hansen , linux-mm , Paul Mackerras , linux-sparc , Alexander Gordeev , Claudio Imbrenda , Will Deacon , linux-arch , linux-s390 , Vasily Gorbik , Richard Weinberger , linux-x86 , Russell King , Christian Borntraeger , Ingo Molnar , Catalin Marinas , Andrey Ryabinin , Heiko Carstens , Arnd Bergmann , Jeff Dike , linux-um , Borislav Petkov , Andy Lutomirski , Thomas Gleixner , linux-arm , linux-power , LKML , Andrew Morton , Linus Torvalds , Mike Rapoport References: <20200907180058.64880-1-gerald.schaefer@linux.ibm.com> <20200907180058.64880-3-gerald.schaefer@linux.ibm.com> From: Christophe Leroy Message-ID: <31dfb3ed-a0cc-3024-d389-ab9bd19e881f@csgroup.eu> Date: Tue, 8 Sep 2020 07:14:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200907180058.64880-3-gerald.schaefer@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 07/09/2020 à 20:00, Gerald Schaefer a écrit : > From: Alexander Gordeev > > Unlike all other page-table abstractions pXd_addr_end() do not take > into account a particular table entry in which context the functions > are called. On architectures with dynamic page-tables folding that > might lead to lack of necessary information that is difficult to > obtain other than from the table entry itself. That already led to > a subtle memory corruption issue on s390. > > By letting pXd_addr_end() functions know about the page-table entry > we allow archs not only make extra checks, but also optimizations. > > As result of this change the pXd_addr_end_folded() functions used > in gup_fast traversal code become unnecessary and get replaced with > universal pXd_addr_end() variants. > > The arch-specific updates not only add dereferencing of page-table > entry pointers, but also small changes to the code flow to make those > dereferences possible, at least for x86 and powerpc. Also for arm64, > but in way that should not have any impact. > [...] > > Signed-off-by: Alexander Gordeev > Signed-off-by: Gerald Schaefer > --- > arch/arm/include/asm/pgtable-2level.h | 2 +- > arch/arm/mm/idmap.c | 6 ++-- > arch/arm/mm/mmu.c | 8 ++--- > arch/arm64/kernel/hibernate.c | 16 ++++++---- > arch/arm64/kvm/mmu.c | 16 +++++----- > arch/arm64/mm/kasan_init.c | 8 ++--- > arch/arm64/mm/mmu.c | 25 +++++++-------- > arch/powerpc/mm/book3s64/radix_pgtable.c | 7 ++--- > arch/powerpc/mm/hugetlbpage.c | 6 ++-- You forgot arch/powerpc/mm/book3s64/subpage_prot.c it seems. > arch/s390/include/asm/pgtable.h | 8 ++--- > arch/s390/mm/page-states.c | 8 ++--- > arch/s390/mm/pageattr.c | 8 ++--- > arch/s390/mm/vmem.c | 8 ++--- > arch/sparc/mm/hugetlbpage.c | 6 ++-- > arch/um/kernel/tlb.c | 8 ++--- > arch/x86/mm/init_64.c | 15 ++++----- > arch/x86/mm/kasan_init_64.c | 16 +++++----- > include/asm-generic/pgtable-nop4d.h | 2 +- > include/asm-generic/pgtable-nopmd.h | 2 +- > include/asm-generic/pgtable-nopud.h | 2 +- > include/linux/pgtable.h | 26 ++++----------- > mm/gup.c | 8 ++--- > mm/ioremap.c | 8 ++--- > mm/kasan/init.c | 17 +++++----- > mm/madvise.c | 4 +-- > mm/memory.c | 40 ++++++++++++------------ > mm/mlock.c | 18 ++++++++--- > mm/mprotect.c | 8 ++--- > mm/pagewalk.c | 8 ++--- > mm/swapfile.c | 8 ++--- > mm/vmalloc.c | 16 +++++----- > 31 files changed, 165 insertions(+), 173 deletions(-) Christophe From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christophe Leroy Date: Tue, 08 Sep 2020 05:14:38 +0000 Subject: Re: [RFC PATCH v2 2/3] mm: make pXd_addr_end() functions page-table entry aware Message-Id: <31dfb3ed-a0cc-3024-d389-ab9bd19e881f@csgroup.eu> List-Id: References: <20200907180058.64880-1-gerald.schaefer@linux.ibm.com> <20200907180058.64880-3-gerald.schaefer@linux.ibm.com> In-Reply-To: <20200907180058.64880-3-gerald.schaefer@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Gerald Schaefer , Jason Gunthorpe , John Hubbard Cc: Peter Zijlstra , Dave Hansen , linux-mm , Paul Mackerras , linux-sparc , Alexander Gordeev , Claudio Imbrenda , Will Deacon , linux-arch , linux-s390 , Vasily Gorbik , Richard Weinberger , linux-x86 , Russell King , Christian Borntraeger , Ingo Molnar , Catalin Marinas , Andrey Ryabinin , Heiko Carstens , Arnd Bergmann , Jeff Dike , linux-um , Borislav Petkov , Andy Lutomirski , Thomas Gleixner , linux-arm , linux-power , LKML , Andrew Morton , Linus Torvalds , Mike Rapoport Le 07/09/2020 à 20:00, Gerald Schaefer a écrit : > From: Alexander Gordeev > > Unlike all other page-table abstractions pXd_addr_end() do not take > into account a particular table entry in which context the functions > are called. On architectures with dynamic page-tables folding that > might lead to lack of necessary information that is difficult to > obtain other than from the table entry itself. That already led to > a subtle memory corruption issue on s390. > > By letting pXd_addr_end() functions know about the page-table entry > we allow archs not only make extra checks, but also optimizations. > > As result of this change the pXd_addr_end_folded() functions used > in gup_fast traversal code become unnecessary and get replaced with > universal pXd_addr_end() variants. > > The arch-specific updates not only add dereferencing of page-table > entry pointers, but also small changes to the code flow to make those > dereferences possible, at least for x86 and powerpc. Also for arm64, > but in way that should not have any impact. > [...] > > Signed-off-by: Alexander Gordeev > Signed-off-by: Gerald Schaefer > --- > arch/arm/include/asm/pgtable-2level.h | 2 +- > arch/arm/mm/idmap.c | 6 ++-- > arch/arm/mm/mmu.c | 8 ++--- > arch/arm64/kernel/hibernate.c | 16 ++++++---- > arch/arm64/kvm/mmu.c | 16 +++++----- > arch/arm64/mm/kasan_init.c | 8 ++--- > arch/arm64/mm/mmu.c | 25 +++++++-------- > arch/powerpc/mm/book3s64/radix_pgtable.c | 7 ++--- > arch/powerpc/mm/hugetlbpage.c | 6 ++-- You forgot arch/powerpc/mm/book3s64/subpage_prot.c it seems. > arch/s390/include/asm/pgtable.h | 8 ++--- > arch/s390/mm/page-states.c | 8 ++--- > arch/s390/mm/pageattr.c | 8 ++--- > arch/s390/mm/vmem.c | 8 ++--- > arch/sparc/mm/hugetlbpage.c | 6 ++-- > arch/um/kernel/tlb.c | 8 ++--- > arch/x86/mm/init_64.c | 15 ++++----- > arch/x86/mm/kasan_init_64.c | 16 +++++----- > include/asm-generic/pgtable-nop4d.h | 2 +- > include/asm-generic/pgtable-nopmd.h | 2 +- > include/asm-generic/pgtable-nopud.h | 2 +- > include/linux/pgtable.h | 26 ++++----------- > mm/gup.c | 8 ++--- > mm/ioremap.c | 8 ++--- > mm/kasan/init.c | 17 +++++----- > mm/madvise.c | 4 +-- > mm/memory.c | 40 ++++++++++++------------ > mm/mlock.c | 18 ++++++++--- > mm/mprotect.c | 8 ++--- > mm/pagewalk.c | 8 ++--- > mm/swapfile.c | 8 ++--- > mm/vmalloc.c | 16 +++++----- > 31 files changed, 165 insertions(+), 173 deletions(-) Christophe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EAC7C43461 for ; Tue, 8 Sep 2020 05:16:44 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5E82E2166E for ; Tue, 8 Sep 2020 05:16:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5E82E2166E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csgroup.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4Bltfw5RwrzDqBt for ; Tue, 8 Sep 2020 15:16:40 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=csgroup.eu (client-ip=93.17.236.30; helo=pegase1.c-s.fr; envelope-from=christophe.leroy@csgroup.eu; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=csgroup.eu Received: from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Bltcv49FFzDqB2 for ; Tue, 8 Sep 2020 15:14:52 +1000 (AEST) Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 4Bltcl5vwGz9tyfC; Tue, 8 Sep 2020 07:14:47 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id CHegWz2Zqd7i; Tue, 8 Sep 2020 07:14:47 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 4Bltcl4S93z9tyfB; Tue, 8 Sep 2020 07:14:47 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 4FA238B78F; Tue, 8 Sep 2020 07:14:48 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id p7u0ZX_PNhu5; Tue, 8 Sep 2020 07:14:48 +0200 (CEST) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id E7EF18B768; Tue, 8 Sep 2020 07:14:45 +0200 (CEST) Subject: Re: [RFC PATCH v2 2/3] mm: make pXd_addr_end() functions page-table entry aware To: Gerald Schaefer , Jason Gunthorpe , John Hubbard References: <20200907180058.64880-1-gerald.schaefer@linux.ibm.com> <20200907180058.64880-3-gerald.schaefer@linux.ibm.com> From: Christophe Leroy Message-ID: <31dfb3ed-a0cc-3024-d389-ab9bd19e881f@csgroup.eu> Date: Tue, 8 Sep 2020 07:14:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200907180058.64880-3-gerald.schaefer@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Zijlstra , Catalin Marinas , Dave Hansen , linux-mm , Paul Mackerras , linux-sparc , Alexander Gordeev , Claudio Imbrenda , Will Deacon , linux-arch , linux-s390 , Vasily Gorbik , Richard Weinberger , linux-x86 , Russell King , Christian Borntraeger , Ingo Molnar , Andrey Ryabinin , Jeff Dike , Arnd Bergmann , Heiko Carstens , linux-um , Borislav Petkov , Andy Lutomirski , Thomas Gleixner , linux-arm , Linus Torvalds , LKML , Andrew Morton , linux-power , Mike Rapoport Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Le 07/09/2020 à 20:00, Gerald Schaefer a écrit : > From: Alexander Gordeev > > Unlike all other page-table abstractions pXd_addr_end() do not take > into account a particular table entry in which context the functions > are called. On architectures with dynamic page-tables folding that > might lead to lack of necessary information that is difficult to > obtain other than from the table entry itself. That already led to > a subtle memory corruption issue on s390. > > By letting pXd_addr_end() functions know about the page-table entry > we allow archs not only make extra checks, but also optimizations. > > As result of this change the pXd_addr_end_folded() functions used > in gup_fast traversal code become unnecessary and get replaced with > universal pXd_addr_end() variants. > > The arch-specific updates not only add dereferencing of page-table > entry pointers, but also small changes to the code flow to make those > dereferences possible, at least for x86 and powerpc. Also for arm64, > but in way that should not have any impact. > [...] > > Signed-off-by: Alexander Gordeev > Signed-off-by: Gerald Schaefer > --- > arch/arm/include/asm/pgtable-2level.h | 2 +- > arch/arm/mm/idmap.c | 6 ++-- > arch/arm/mm/mmu.c | 8 ++--- > arch/arm64/kernel/hibernate.c | 16 ++++++---- > arch/arm64/kvm/mmu.c | 16 +++++----- > arch/arm64/mm/kasan_init.c | 8 ++--- > arch/arm64/mm/mmu.c | 25 +++++++-------- > arch/powerpc/mm/book3s64/radix_pgtable.c | 7 ++--- > arch/powerpc/mm/hugetlbpage.c | 6 ++-- You forgot arch/powerpc/mm/book3s64/subpage_prot.c it seems. > arch/s390/include/asm/pgtable.h | 8 ++--- > arch/s390/mm/page-states.c | 8 ++--- > arch/s390/mm/pageattr.c | 8 ++--- > arch/s390/mm/vmem.c | 8 ++--- > arch/sparc/mm/hugetlbpage.c | 6 ++-- > arch/um/kernel/tlb.c | 8 ++--- > arch/x86/mm/init_64.c | 15 ++++----- > arch/x86/mm/kasan_init_64.c | 16 +++++----- > include/asm-generic/pgtable-nop4d.h | 2 +- > include/asm-generic/pgtable-nopmd.h | 2 +- > include/asm-generic/pgtable-nopud.h | 2 +- > include/linux/pgtable.h | 26 ++++----------- > mm/gup.c | 8 ++--- > mm/ioremap.c | 8 ++--- > mm/kasan/init.c | 17 +++++----- > mm/madvise.c | 4 +-- > mm/memory.c | 40 ++++++++++++------------ > mm/mlock.c | 18 ++++++++--- > mm/mprotect.c | 8 ++--- > mm/pagewalk.c | 8 ++--- > mm/swapfile.c | 8 ++--- > mm/vmalloc.c | 16 +++++----- > 31 files changed, 165 insertions(+), 173 deletions(-) Christophe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17BCAC43461 for ; Tue, 8 Sep 2020 05:16:10 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C18092166E for ; Tue, 8 Sep 2020 05:16:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="0xkCDGOe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C18092166E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csgroup.eu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XcGWWxxA9IX7r2ZIaB+fcMFVVWGtnAFx7pCTn21ek6c=; b=0xkCDGOeHkbzKLi3/k2APWlKr g2bM33AtR0C/DBVc2Mn/DirpmX5IdpmuUnPO/cCam++URp0fwzxdTlCoSWRE+UqLLjncUEGbAJ7wN Vmg4GfrFMA2iFgJX97qM1KASsagFAAFOiHpAsGFBOfHLBmCQZ5UKU2PGBE1HSru8bLG/oaWL6vh3G ExieKOlKcpqluRxad/GPc2V1kN1zlpgDNOEfVBESMaEVtkpFfKiKSbuivTKx0oxEwszV2IJvnsnZv TDj3KThF+BHqB4ZWjf0RZcVmnbIGnJwVHZ8Iw7AqIxWAJM25uPF0qSYl9yJNPP2y3dbxzG96wdIN3 Du4z3ruaQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFVy2-0004St-CN; Tue, 08 Sep 2020 05:14:54 +0000 Received: from pegase1.c-s.fr ([93.17.236.30]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFVxy-0004Qx-20; Tue, 08 Sep 2020 05:14:51 +0000 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 4Bltcl5vwGz9tyfC; Tue, 8 Sep 2020 07:14:47 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id CHegWz2Zqd7i; Tue, 8 Sep 2020 07:14:47 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 4Bltcl4S93z9tyfB; Tue, 8 Sep 2020 07:14:47 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 4FA238B78F; Tue, 8 Sep 2020 07:14:48 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id p7u0ZX_PNhu5; Tue, 8 Sep 2020 07:14:48 +0200 (CEST) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id E7EF18B768; Tue, 8 Sep 2020 07:14:45 +0200 (CEST) Subject: Re: [RFC PATCH v2 2/3] mm: make pXd_addr_end() functions page-table entry aware To: Gerald Schaefer , Jason Gunthorpe , John Hubbard References: <20200907180058.64880-1-gerald.schaefer@linux.ibm.com> <20200907180058.64880-3-gerald.schaefer@linux.ibm.com> From: Christophe Leroy Message-ID: <31dfb3ed-a0cc-3024-d389-ab9bd19e881f@csgroup.eu> Date: Tue, 8 Sep 2020 07:14:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200907180058.64880-3-gerald.schaefer@linux.ibm.com> Content-Language: fr X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200908_011450_393275_298A1346 X-CRM114-Status: GOOD ( 21.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Zijlstra , Catalin Marinas , Dave Hansen , linux-mm , Paul Mackerras , linux-sparc , Alexander Gordeev , Claudio Imbrenda , Will Deacon , linux-arch , linux-s390 , Vasily Gorbik , Richard Weinberger , linux-x86 , Russell King , Christian Borntraeger , Ingo Molnar , Andrey Ryabinin , Jeff Dike , Arnd Bergmann , Heiko Carstens , linux-um , Borislav Petkov , Andy Lutomirski , Thomas Gleixner , linux-arm , Linus Torvalds , LKML , Andrew Morton , linux-power , Mike Rapoport Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpMZSAwNy8wOS8yMDIwIMOgIDIwOjAwLCBHZXJhbGQgU2NoYWVmZXIgYSDDqWNyaXTCoDoKPiBG cm9tOiBBbGV4YW5kZXIgR29yZGVldiA8YWdvcmRlZXZAbGludXguaWJtLmNvbT4KPiAKPiBVbmxp a2UgYWxsIG90aGVyIHBhZ2UtdGFibGUgYWJzdHJhY3Rpb25zIHBYZF9hZGRyX2VuZCgpIGRvIG5v dCB0YWtlCj4gaW50byBhY2NvdW50IGEgcGFydGljdWxhciB0YWJsZSBlbnRyeSBpbiB3aGljaCBj b250ZXh0IHRoZSBmdW5jdGlvbnMKPiBhcmUgY2FsbGVkLiBPbiBhcmNoaXRlY3R1cmVzIHdpdGgg ZHluYW1pYyBwYWdlLXRhYmxlcyBmb2xkaW5nIHRoYXQKPiBtaWdodCBsZWFkIHRvIGxhY2sgb2Yg bmVjZXNzYXJ5IGluZm9ybWF0aW9uIHRoYXQgaXMgZGlmZmljdWx0IHRvCj4gb2J0YWluIG90aGVy IHRoYW4gZnJvbSB0aGUgdGFibGUgZW50cnkgaXRzZWxmLiBUaGF0IGFscmVhZHkgbGVkIHRvCj4g YSBzdWJ0bGUgbWVtb3J5IGNvcnJ1cHRpb24gaXNzdWUgb24gczM5MC4KPiAKPiBCeSBsZXR0aW5n IHBYZF9hZGRyX2VuZCgpIGZ1bmN0aW9ucyBrbm93IGFib3V0IHRoZSBwYWdlLXRhYmxlIGVudHJ5 Cj4gd2UgYWxsb3cgYXJjaHMgbm90IG9ubHkgbWFrZSBleHRyYSBjaGVja3MsIGJ1dCBhbHNvIG9w dGltaXphdGlvbnMuCj4gCj4gQXMgcmVzdWx0IG9mIHRoaXMgY2hhbmdlIHRoZSBwWGRfYWRkcl9l bmRfZm9sZGVkKCkgZnVuY3Rpb25zIHVzZWQKPiBpbiBndXBfZmFzdCB0cmF2ZXJzYWwgY29kZSBi ZWNvbWUgdW5uZWNlc3NhcnkgYW5kIGdldCByZXBsYWNlZCB3aXRoCj4gdW5pdmVyc2FsIHBYZF9h ZGRyX2VuZCgpIHZhcmlhbnRzLgo+IAo+IFRoZSBhcmNoLXNwZWNpZmljIHVwZGF0ZXMgbm90IG9u bHkgYWRkIGRlcmVmZXJlbmNpbmcgb2YgcGFnZS10YWJsZQo+IGVudHJ5IHBvaW50ZXJzLCBidXQg YWxzbyBzbWFsbCBjaGFuZ2VzIHRvIHRoZSBjb2RlIGZsb3cgdG8gbWFrZSB0aG9zZQo+IGRlcmVm ZXJlbmNlcyBwb3NzaWJsZSwgYXQgbGVhc3QgZm9yIHg4NiBhbmQgcG93ZXJwYy4gQWxzbyBmb3Ig YXJtNjQsCj4gYnV0IGluIHdheSB0aGF0IHNob3VsZCBub3QgaGF2ZSBhbnkgaW1wYWN0Lgo+IAoK Wy4uLl0KCj4gCj4gU2lnbmVkLW9mZi1ieTogQWxleGFuZGVyIEdvcmRlZXYgPGFnb3JkZWV2QGxp bnV4LmlibS5jb20+Cj4gU2lnbmVkLW9mZi1ieTogR2VyYWxkIFNjaGFlZmVyIDxnZXJhbGQuc2No YWVmZXJAbGludXguaWJtLmNvbT4KPiAtLS0KPiAgIGFyY2gvYXJtL2luY2x1ZGUvYXNtL3BndGFi bGUtMmxldmVsLmggICAgfCAgMiArLQo+ICAgYXJjaC9hcm0vbW0vaWRtYXAuYyAgICAgICAgICAg ICAgICAgICAgICB8ICA2ICsrLS0KPiAgIGFyY2gvYXJtL21tL21tdS5jICAgICAgICAgICAgICAg ICAgICAgICAgfCAgOCArKy0tLQo+ICAgYXJjaC9hcm02NC9rZXJuZWwvaGliZXJuYXRlLmMgICAg ICAgICAgICB8IDE2ICsrKysrKy0tLS0KPiAgIGFyY2gvYXJtNjQva3ZtL21tdS5jICAgICAgICAg ICAgICAgICAgICAgfCAxNiArKysrKy0tLS0tCj4gICBhcmNoL2FybTY0L21tL2thc2FuX2luaXQu YyAgICAgICAgICAgICAgIHwgIDggKystLS0KPiAgIGFyY2gvYXJtNjQvbW0vbW11LmMgICAgICAg ICAgICAgICAgICAgICAgfCAyNSArKysrKysrLS0tLS0tLS0KPiAgIGFyY2gvcG93ZXJwYy9tbS9i b29rM3M2NC9yYWRpeF9wZ3RhYmxlLmMgfCAgNyArKy0tLQo+ICAgYXJjaC9wb3dlcnBjL21tL2h1 Z2V0bGJwYWdlLmMgICAgICAgICAgICB8ICA2ICsrLS0KCllvdSBmb3Jnb3QgYXJjaC9wb3dlcnBj L21tL2Jvb2szczY0L3N1YnBhZ2VfcHJvdC5jIGl0IHNlZW1zLgoKPiAgIGFyY2gvczM5MC9pbmNs dWRlL2FzbS9wZ3RhYmxlLmggICAgICAgICAgfCAgOCArKy0tLQo+ICAgYXJjaC9zMzkwL21tL3Bh Z2Utc3RhdGVzLmMgICAgICAgICAgICAgICB8ICA4ICsrLS0tCj4gICBhcmNoL3MzOTAvbW0vcGFn ZWF0dHIuYyAgICAgICAgICAgICAgICAgIHwgIDggKystLS0KPiAgIGFyY2gvczM5MC9tbS92bWVt LmMgICAgICAgICAgICAgICAgICAgICAgfCAgOCArKy0tLQo+ICAgYXJjaC9zcGFyYy9tbS9odWdl dGxicGFnZS5jICAgICAgICAgICAgICB8ICA2ICsrLS0KPiAgIGFyY2gvdW0va2VybmVsL3RsYi5j ICAgICAgICAgICAgICAgICAgICAgfCAgOCArKy0tLQo+ICAgYXJjaC94ODYvbW0vaW5pdF82NC5j ICAgICAgICAgICAgICAgICAgICB8IDE1ICsrKystLS0tLQo+ICAgYXJjaC94ODYvbW0va2FzYW5f aW5pdF82NC5jICAgICAgICAgICAgICB8IDE2ICsrKysrLS0tLS0KPiAgIGluY2x1ZGUvYXNtLWdl bmVyaWMvcGd0YWJsZS1ub3A0ZC5oICAgICAgfCAgMiArLQo+ICAgaW5jbHVkZS9hc20tZ2VuZXJp Yy9wZ3RhYmxlLW5vcG1kLmggICAgICB8ICAyICstCj4gICBpbmNsdWRlL2FzbS1nZW5lcmljL3Bn dGFibGUtbm9wdWQuaCAgICAgIHwgIDIgKy0KPiAgIGluY2x1ZGUvbGludXgvcGd0YWJsZS5oICAg ICAgICAgICAgICAgICAgfCAyNiArKysrLS0tLS0tLS0tLS0KPiAgIG1tL2d1cC5jICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgfCAgOCArKy0tLQo+ICAgbW0vaW9yZW1hcC5jICAgICAg ICAgICAgICAgICAgICAgICAgICAgICB8ICA4ICsrLS0tCj4gICBtbS9rYXNhbi9pbml0LmMgICAg ICAgICAgICAgICAgICAgICAgICAgIHwgMTcgKysrKystLS0tLQo+ICAgbW0vbWFkdmlzZS5jICAg ICAgICAgICAgICAgICAgICAgICAgICAgICB8ICA0ICstLQo+ICAgbW0vbWVtb3J5LmMgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICB8IDQwICsrKysrKysrKysrKy0tLS0tLS0tLS0tLQo+ICAg bW0vbWxvY2suYyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8IDE4ICsrKysrKysrLS0t Cj4gICBtbS9tcHJvdGVjdC5jICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgIDggKystLS0K PiAgIG1tL3BhZ2V3YWxrLmMgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgOCArKy0tLQo+ ICAgbW0vc3dhcGZpbGUuYyAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICA4ICsrLS0tCj4g ICBtbS92bWFsbG9jLmMgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgMTYgKysrKystLS0t LQo+ICAgMzEgZmlsZXMgY2hhbmdlZCwgMTY1IGluc2VydGlvbnMoKyksIDE3MyBkZWxldGlvbnMo LSkKCkNocmlzdG9waGUKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlz dHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [RFC PATCH v2 2/3] mm: make pXd_addr_end() functions page-table entry aware References: <20200907180058.64880-1-gerald.schaefer@linux.ibm.com> <20200907180058.64880-3-gerald.schaefer@linux.ibm.com> From: Christophe Leroy Message-ID: <31dfb3ed-a0cc-3024-d389-ab9bd19e881f@csgroup.eu> Date: Tue, 8 Sep 2020 07:14:38 +0200 MIME-Version: 1.0 In-Reply-To: <20200907180058.64880-3-gerald.schaefer@linux.ibm.com> Content-Language: fr List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Gerald Schaefer , Jason Gunthorpe , John Hubbard Cc: Peter Zijlstra , Catalin Marinas , Dave Hansen , linux-mm , Paul Mackerras , linux-sparc , Alexander Gordeev , Claudio Imbrenda , Will Deacon , linux-arch , linux-s390 , Vasily Gorbik , Richard Weinberger , linux-x86 , Russell King , Christian Borntraeger , Ingo Molnar , Andrey Ryabinin , Jeff Dike , Arnd Bergmann , Heiko Carstens , linux-um , Borislav Petkov , Andy Lutomirski , Thomas Gleixner , linux-arm , Linus Torvalds , LKML , Andrew Morton , linux-power , Mike Rapoport CgpMZSAwNy8wOS8yMDIwIMOgIDIwOjAwLCBHZXJhbGQgU2NoYWVmZXIgYSDDqWNyaXTCoDoKPiBG cm9tOiBBbGV4YW5kZXIgR29yZGVldiA8YWdvcmRlZXZAbGludXguaWJtLmNvbT4KPiAKPiBVbmxp a2UgYWxsIG90aGVyIHBhZ2UtdGFibGUgYWJzdHJhY3Rpb25zIHBYZF9hZGRyX2VuZCgpIGRvIG5v dCB0YWtlCj4gaW50byBhY2NvdW50IGEgcGFydGljdWxhciB0YWJsZSBlbnRyeSBpbiB3aGljaCBj b250ZXh0IHRoZSBmdW5jdGlvbnMKPiBhcmUgY2FsbGVkLiBPbiBhcmNoaXRlY3R1cmVzIHdpdGgg ZHluYW1pYyBwYWdlLXRhYmxlcyBmb2xkaW5nIHRoYXQKPiBtaWdodCBsZWFkIHRvIGxhY2sgb2Yg bmVjZXNzYXJ5IGluZm9ybWF0aW9uIHRoYXQgaXMgZGlmZmljdWx0IHRvCj4gb2J0YWluIG90aGVy IHRoYW4gZnJvbSB0aGUgdGFibGUgZW50cnkgaXRzZWxmLiBUaGF0IGFscmVhZHkgbGVkIHRvCj4g YSBzdWJ0bGUgbWVtb3J5IGNvcnJ1cHRpb24gaXNzdWUgb24gczM5MC4KPiAKPiBCeSBsZXR0aW5n IHBYZF9hZGRyX2VuZCgpIGZ1bmN0aW9ucyBrbm93IGFib3V0IHRoZSBwYWdlLXRhYmxlIGVudHJ5 Cj4gd2UgYWxsb3cgYXJjaHMgbm90IG9ubHkgbWFrZSBleHRyYSBjaGVja3MsIGJ1dCBhbHNvIG9w dGltaXphdGlvbnMuCj4gCj4gQXMgcmVzdWx0IG9mIHRoaXMgY2hhbmdlIHRoZSBwWGRfYWRkcl9l bmRfZm9sZGVkKCkgZnVuY3Rpb25zIHVzZWQKPiBpbiBndXBfZmFzdCB0cmF2ZXJzYWwgY29kZSBi ZWNvbWUgdW5uZWNlc3NhcnkgYW5kIGdldCByZXBsYWNlZCB3aXRoCj4gdW5pdmVyc2FsIHBYZF9h ZGRyX2VuZCgpIHZhcmlhbnRzLgo+IAo+IFRoZSBhcmNoLXNwZWNpZmljIHVwZGF0ZXMgbm90IG9u bHkgYWRkIGRlcmVmZXJlbmNpbmcgb2YgcGFnZS10YWJsZQo+IGVudHJ5IHBvaW50ZXJzLCBidXQg YWxzbyBzbWFsbCBjaGFuZ2VzIHRvIHRoZSBjb2RlIGZsb3cgdG8gbWFrZSB0aG9zZQo+IGRlcmVm ZXJlbmNlcyBwb3NzaWJsZSwgYXQgbGVhc3QgZm9yIHg4NiBhbmQgcG93ZXJwYy4gQWxzbyBmb3Ig YXJtNjQsCj4gYnV0IGluIHdheSB0aGF0IHNob3VsZCBub3QgaGF2ZSBhbnkgaW1wYWN0Lgo+IAoK Wy4uLl0KCj4gCj4gU2lnbmVkLW9mZi1ieTogQWxleGFuZGVyIEdvcmRlZXYgPGFnb3JkZWV2QGxp bnV4LmlibS5jb20+Cj4gU2lnbmVkLW9mZi1ieTogR2VyYWxkIFNjaGFlZmVyIDxnZXJhbGQuc2No YWVmZXJAbGludXguaWJtLmNvbT4KPiAtLS0KPiAgIGFyY2gvYXJtL2luY2x1ZGUvYXNtL3BndGFi bGUtMmxldmVsLmggICAgfCAgMiArLQo+ICAgYXJjaC9hcm0vbW0vaWRtYXAuYyAgICAgICAgICAg ICAgICAgICAgICB8ICA2ICsrLS0KPiAgIGFyY2gvYXJtL21tL21tdS5jICAgICAgICAgICAgICAg ICAgICAgICAgfCAgOCArKy0tLQo+ICAgYXJjaC9hcm02NC9rZXJuZWwvaGliZXJuYXRlLmMgICAg ICAgICAgICB8IDE2ICsrKysrKy0tLS0KPiAgIGFyY2gvYXJtNjQva3ZtL21tdS5jICAgICAgICAg ICAgICAgICAgICAgfCAxNiArKysrKy0tLS0tCj4gICBhcmNoL2FybTY0L21tL2thc2FuX2luaXQu YyAgICAgICAgICAgICAgIHwgIDggKystLS0KPiAgIGFyY2gvYXJtNjQvbW0vbW11LmMgICAgICAg ICAgICAgICAgICAgICAgfCAyNSArKysrKysrLS0tLS0tLS0KPiAgIGFyY2gvcG93ZXJwYy9tbS9i b29rM3M2NC9yYWRpeF9wZ3RhYmxlLmMgfCAgNyArKy0tLQo+ICAgYXJjaC9wb3dlcnBjL21tL2h1 Z2V0bGJwYWdlLmMgICAgICAgICAgICB8ICA2ICsrLS0KCllvdSBmb3Jnb3QgYXJjaC9wb3dlcnBj L21tL2Jvb2szczY0L3N1YnBhZ2VfcHJvdC5jIGl0IHNlZW1zLgoKPiAgIGFyY2gvczM5MC9pbmNs dWRlL2FzbS9wZ3RhYmxlLmggICAgICAgICAgfCAgOCArKy0tLQo+ICAgYXJjaC9zMzkwL21tL3Bh Z2Utc3RhdGVzLmMgICAgICAgICAgICAgICB8ICA4ICsrLS0tCj4gICBhcmNoL3MzOTAvbW0vcGFn ZWF0dHIuYyAgICAgICAgICAgICAgICAgIHwgIDggKystLS0KPiAgIGFyY2gvczM5MC9tbS92bWVt LmMgICAgICAgICAgICAgICAgICAgICAgfCAgOCArKy0tLQo+ICAgYXJjaC9zcGFyYy9tbS9odWdl dGxicGFnZS5jICAgICAgICAgICAgICB8ICA2ICsrLS0KPiAgIGFyY2gvdW0va2VybmVsL3RsYi5j ICAgICAgICAgICAgICAgICAgICAgfCAgOCArKy0tLQo+ICAgYXJjaC94ODYvbW0vaW5pdF82NC5j ICAgICAgICAgICAgICAgICAgICB8IDE1ICsrKystLS0tLQo+ICAgYXJjaC94ODYvbW0va2FzYW5f aW5pdF82NC5jICAgICAgICAgICAgICB8IDE2ICsrKysrLS0tLS0KPiAgIGluY2x1ZGUvYXNtLWdl bmVyaWMvcGd0YWJsZS1ub3A0ZC5oICAgICAgfCAgMiArLQo+ICAgaW5jbHVkZS9hc20tZ2VuZXJp Yy9wZ3RhYmxlLW5vcG1kLmggICAgICB8ICAyICstCj4gICBpbmNsdWRlL2FzbS1nZW5lcmljL3Bn dGFibGUtbm9wdWQuaCAgICAgIHwgIDIgKy0KPiAgIGluY2x1ZGUvbGludXgvcGd0YWJsZS5oICAg ICAgICAgICAgICAgICAgfCAyNiArKysrLS0tLS0tLS0tLS0KPiAgIG1tL2d1cC5jICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgfCAgOCArKy0tLQo+ICAgbW0vaW9yZW1hcC5jICAgICAg ICAgICAgICAgICAgICAgICAgICAgICB8ICA4ICsrLS0tCj4gICBtbS9rYXNhbi9pbml0LmMgICAg ICAgICAgICAgICAgICAgICAgICAgIHwgMTcgKysrKystLS0tLQo+ICAgbW0vbWFkdmlzZS5jICAg ICAgICAgICAgICAgICAgICAgICAgICAgICB8ICA0ICstLQo+ICAgbW0vbWVtb3J5LmMgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICB8IDQwICsrKysrKysrKysrKy0tLS0tLS0tLS0tLQo+ICAg bW0vbWxvY2suYyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8IDE4ICsrKysrKysrLS0t Cj4gICBtbS9tcHJvdGVjdC5jICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgIDggKystLS0K PiAgIG1tL3BhZ2V3YWxrLmMgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgOCArKy0tLQo+ ICAgbW0vc3dhcGZpbGUuYyAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICA4ICsrLS0tCj4g ICBtbS92bWFsbG9jLmMgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgMTYgKysrKystLS0t LQo+ICAgMzEgZmlsZXMgY2hhbmdlZCwgMTY1IGluc2VydGlvbnMoKyksIDE3MyBkZWxldGlvbnMo LSkKCkNocmlzdG9waGUKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmxpbnV4LXVtIG1haWxpbmcgbGlzdApsaW51eC11bUBsaXN0cy5pbmZyYWRlYWQub3Jn Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtdW0K