From: Andrew Donnellan <ajd@linux.ibm.com>
To: Pingfan Liu <kernelfans@gmail.com>, linuxppc-dev@lists.ozlabs.org
Cc: kexec@lists.infradead.org, Rob Herring <robh+dt@kernel.org>,
Oliver O'Halloran <oohall@gmail.com>,
"Aneesh Kumar K . V" <aneesh.kumar@linux.ibm.com>,
Paul Mackerras <paulus@samba.org>,
Dan Williams <dan.j.williams@intel.com>,
Frank Rowand <frowand.list@gmail.com>,
Hari Bathini <hbathini@linux.ibm.com>
Subject: Re: [PATCHv3 1/2] powerpc/of: split out new_property() for reusing
Date: Thu, 5 Mar 2020 14:58:55 +1100 [thread overview]
Message-ID: <31e6c7c2-498f-1325-8728-e859851ff56a@linux.ibm.com> (raw)
In-Reply-To: <1583311651-29310-2-git-send-email-kernelfans@gmail.com>
On 4/3/20 7:47 pm, Pingfan Liu wrote:
> Splitting out new_property() for coming reusing and moving it to
> of_helpers.c.
>
> Also do some coding style cleanup.
>
> Signed-off-by: Pingfan Liu <kernelfans@gmail.com>
> To: linuxppc-dev@lists.ozlabs.org
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Hari Bathini <hbathini@linux.ibm.com>
> Cc: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
> Cc: Oliver O'Halloran <oohall@gmail.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Andrew Donnellan <ajd@linux.ibm.com>
> Cc: Christophe Leroy <christophe.leroy@c-s.fr>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Frank Rowand <frowand.list@gmail.com>
> Cc: kexec@lists.infradead.org
Would this be useful to move into generic OF code?
Also if more functions are moving into of_helpers.c perhaps there should
be a common function name prefix.
Otherwise your style cleanup looks good.
Reviewed-by: Andrew Donnellan <ajd@linux.ibm.com>
--
Andrew Donnellan OzLabs, ADL Canberra
ajd@linux.ibm.com IBM Australia Limited
next prev parent reply other threads:[~2020-03-05 4:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 9:41 [PATCHv2 1/2] powerpc/of: split out new_property() for reusing Pingfan Liu
2020-02-28 9:41 ` [PATCHv2 2/2] pSeries/papr_scm: buffer pmem's bound addr in dt for kexec kernel Pingfan Liu
2020-03-04 8:47 ` [PATCHv3 0/2] pseries/scm: " Pingfan Liu
2020-03-04 8:47 ` [PATCHv3 1/2] powerpc/of: split out new_property() for reusing Pingfan Liu
2020-03-05 3:58 ` Andrew Donnellan [this message]
2020-03-06 19:59 ` Nathan Lynch
2020-03-09 1:50 ` Pingfan Liu
2020-03-04 8:47 ` [PATCHv3 2/2] pseries/scm: buffer pmem's bound addr in dt for kexec kernel Pingfan Liu
2020-03-13 3:17 ` Oliver O'Halloran
2020-03-16 2:49 ` Pingfan Liu
2020-03-16 2:53 ` Aneesh Kumar K.V
2020-03-16 8:37 ` Pingfan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31e6c7c2-498f-1325-8728-e859851ff56a@linux.ibm.com \
--to=ajd@linux.ibm.com \
--cc=aneesh.kumar@linux.ibm.com \
--cc=dan.j.williams@intel.com \
--cc=frowand.list@gmail.com \
--cc=hbathini@linux.ibm.com \
--cc=kernelfans@gmail.com \
--cc=kexec@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=oohall@gmail.com \
--cc=paulus@samba.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.