From mboxrd@z Thu Jan 1 00:00:00 1970 From: valdis.kletnieks@vt.edu (valdis.kletnieks at vt.edu) Date: Fri, 30 Mar 2018 03:12:08 -0400 Subject: V4l2 Sensor driver and V4l2 ctrls In-Reply-To: <16275853886.d54106f2524214.7152654289021633598@iqroottech.com> References: <16275853886.d54106f2524214.7152654289021633598@iqroottech.com> Message-ID: <32051.1522393928@turing-police.cc.vt.edu> To: kernelnewbies@lists.kernelnewbies.org List-Id: kernelnewbies.lists.kernelnewbies.org On Fri, 30 Mar 2018 11:38:07 +0530, MUHAMMED ASAD P T said: > In reference sensor drivers, they used the V4L2_CID_DV_RX_POWER_PRESENT v4l2 ctrl. > It is a standard ctrl and created using v4l2_ctrl_new_std(). > 1. Whether in our sensor driver, we need to create this Control Id or not. > How to take the decision on this. Since this is the standard ctrl. When we need > to use these standard ctrls?? When you're doing the same thing as the reference drivers, use the standard control. If you're doing something strange and different from the reference drivers, ask yourself why you're doing it, and whether doing the same thing as the reference drivers wouldn't be a better idea. In this specific case, RX_POWER_PRESENT sounds like a pretty common thing to be able to sense. So if that's what you're doing, use that control. If your sensor can't detect RX_POWER_PRESENT, complain to your hardware design team. :) -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 486 bytes Desc: not available URL: