All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, andrew.rybchenko@oktetlabs.ru,
	ferruh.yigit@intel.com,
	David Marchand <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v3] log: register with standardized names
Date: Tue, 11 May 2021 14:01:29 +0200	[thread overview]
Message-ID: <3205318.kz0D4tACF5@thomas> (raw)
In-Reply-To: <YJpvN2TagX7lXIL5@bricha3-MOBL.ger.corp.intel.com>

11/05/2021 13:49, Bruce Richardson:
> On Tue, May 11, 2021 at 12:09:27PM +0200, Thomas Monjalon wrote:
> > +log_prefix
> > +	**Default Value = pmd.<class>**
> > +	Some driver classes have a customized log prefix.
> > +	This prefix is combined with the driver name
> > +	when registering a default log name for the driver.
> > +
> 
> I don't think this should be added here. This section is for elements to be
> defined in the meson.build file of each individual driver. This value,
> though, is to be defined per class, rather than per-driver. We don't have a
> doc section for that, but perhaps one is needed.
> 
> For now, I'd just omit documenting this value as it should only be of
> relevance for the couple of existing driver classes that use it. Nobody
> else contributing new code to DPDK should need it.

OK, makes sense.

If I remove these doc lines, is it OK to push the patch to the repository?




  reply	other threads:[~2021-05-11 12:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-09 12:43 [dpdk-dev] [PATCH] log: deduce log type from filename David Marchand
2021-04-09 13:01 ` Bruce Richardson
2021-04-13 15:07   ` David Marchand
2021-04-26 12:51 ` [dpdk-dev] [PATCH v2] log: register with standardized names David Marchand
2021-05-11 10:09 ` [dpdk-dev] [PATCH v3] " Thomas Monjalon
2021-05-11 11:15   ` David Marchand
2021-05-11 11:49   ` Bruce Richardson
2021-05-11 12:01     ` Thomas Monjalon [this message]
2021-05-11 11:59   ` Bruce Richardson
2021-05-11 12:10     ` Thomas Monjalon
2021-05-11 12:24       ` Bruce Richardson
2021-05-11 12:38 ` [dpdk-dev] [PATCH v4] " Thomas Monjalon
2021-05-11 12:52   ` Bruce Richardson
2021-05-11 13:21     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3205318.kz0D4tACF5@thomas \
    --to=thomas@monjalon.net \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.