All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Ceresoli <luca@lucaceresoli.net>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Wolfram Sang <wsa@the-dreams.de>
Cc: linux-iio@vger.kernel.orgi, linux-i2c@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] i2c: smbus: switch from loops to memcpy
Date: Wed, 13 Nov 2019 10:47:55 +0100	[thread overview]
Message-ID: <320567eb-00f5-2228-c507-317131b4af74@lucaceresoli.net> (raw)
In-Reply-To: <20191112203132.163306-4-dmitry.torokhov@gmail.com>

Hi Dmitry,

On 12/11/19 21:31, Dmitry Torokhov wrote:
> When copying memory from one buffer to another, instead of open-coding
> loops with byte-by-byte copies let's use memcpy() which might be a bit
> faster and makes intent more clear.

Good idea!

Reviewed-by: Luca Ceresoli <luca@lucaceresoli.net>

-- 
Luca

  reply	other threads:[~2019-11-13  9:48 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-12 20:31 [PATCH v3 0/3] Use void pointers instead of char in I2C transfer APIs Dmitry Torokhov
2019-11-12 20:31 ` Dmitry Torokhov
2019-11-12 20:31 ` [PATCH v3 1/3] i2c: use void pointers for supplying data for reads and writes Dmitry Torokhov
2019-11-12 20:31   ` Dmitry Torokhov
2019-11-13  9:47   ` Luca Ceresoli
2019-11-13  9:47     ` Luca Ceresoli
2019-11-18  7:43   ` Uwe Kleine-König
2019-11-18  7:43     ` Uwe Kleine-König
2019-11-18  8:04     ` Dmitry Torokhov
2019-11-18  8:04       ` Dmitry Torokhov
2019-11-18  8:38       ` Uwe Kleine-König
2019-11-18  8:38         ` Uwe Kleine-König
2021-01-11 21:02         ` Wolfram Sang
2019-11-12 20:31 ` [PATCH v3 2/3] i2c: smbus: use get/put_unaligned_le16 when working with word data Dmitry Torokhov
2019-11-13  9:47   ` Luca Ceresoli
2019-11-13 19:39     ` Dmitry Torokhov
2019-11-14  9:23       ` Luca Ceresoli
2019-11-18  7:36   ` Uwe Kleine-König
2021-01-11 21:04     ` Wolfram Sang
2019-11-12 20:31 ` [PATCH v3 3/3] i2c: smbus: switch from loops to memcpy Dmitry Torokhov
2019-11-13  9:47   ` Luca Ceresoli [this message]
2019-11-18  7:47   ` Uwe Kleine-König
2019-11-18  8:09     ` Dmitry Torokhov
2019-11-18  8:47       ` Uwe Kleine-König
2021-01-11 21:04   ` Wolfram Sang
2021-01-11 21:01 ` [PATCH v3 0/3] Use void pointers instead of char in I2C transfer APIs Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=320567eb-00f5-2228-c507-317131b4af74@lucaceresoli.net \
    --to=luca@lucaceresoli.net \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-iio@vger.kernel.orgi \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.