From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FE64C64E7B for ; Thu, 3 Dec 2020 09:39:59 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C4B5320C56 for ; Thu, 3 Dec 2020 09:39:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C4B5320C56 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.43238.77780 (Exim 4.92) (envelope-from ) id 1kkl5Z-0003I1-Di; Thu, 03 Dec 2020 09:39:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 43238.77780; Thu, 03 Dec 2020 09:39:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kkl5Z-0003Hs-AX; Thu, 03 Dec 2020 09:39:49 +0000 Received: by outflank-mailman (input) for mailman id 43238; Thu, 03 Dec 2020 09:39:47 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kkl5X-0003H0-Pl for xen-devel@lists.xenproject.org; Thu, 03 Dec 2020 09:39:47 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1f63d5ff-a56a-4f68-b45b-d213fc2b3a01; Thu, 03 Dec 2020 09:39:47 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3A8ABAD41; Thu, 3 Dec 2020 09:39:46 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1f63d5ff-a56a-4f68-b45b-d213fc2b3a01 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1606988386; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DSw79RRPYCY78Gq5LmoS5kY4pFo0mkxApqpjn/O9AeY=; b=ArAC1Xpy4B3hjPBjVHdP7utb8F+kNdAR7dX64OgOGE7V9+NOPfbGcc6Lu5fOag8sfrApJ+ rGZ7h3nWYwpsT2rOlP/GjrYRNTOkRJz5PT6k6RFotMaBmmFy264Jmgq5UwJTJtmMoShwDG UWcbwsoZnuy0FngE8YdBR95ddqdWVv0= Subject: Re: [PATCH 2/2] mm: split out mfn_t / gfn_t / pfn_t definitions and helpers To: Julien Grall Cc: Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , Hongyan Xia , "xen-devel@lists.xenproject.org" References: <75484377-160c-a529-1cfc-96de86cfc550@suse.com> <9c240acd-f3ef-6775-eb4b-6e3b14251e51@xen.org> From: Jan Beulich Message-ID: <320d042c-2e37-f5ef-ce2f-2d4c97901bae@suse.com> Date: Thu, 3 Dec 2020 10:39:45 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <9c240acd-f3ef-6775-eb4b-6e3b14251e51@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 02.12.2020 18:35, Julien Grall wrote: > On 02/12/2020 14:50, Jan Beulich wrote: >> xen/mm.h has heavy dependencies, while in a number of cases only these >> type definitions are needed. This separation then also allows pulling in >> these definitions when including xen/mm.h would cause cyclic >> dependencies. >> >> Replace xen/mm.h inclusion where possible in include/xen/. (In >> xen/iommu.h also take the opportunity and correct the few remaining >> sorting issues.) >> >> Signed-off-by: Jan Beulich >> >> --- a/xen/arch/x86/acpi/power.c >> +++ b/xen/arch/x86/acpi/power.c >> @@ -10,7 +10,6 @@ >> * Slimmed with Xen specific support. >> */ >> >> -#include > > This seems to be unrelated of this work. Well spotted, but the answer really is "yes and no". My first attempt at fixing build issues from this and similar asm/io.h inclusions was to remove such unnecessary ones. But this didn't work out - I had to fix the header instead. If you think this extra cleanup really does any harm here, I can drop it. But I'd prefer to keep it. >> --- /dev/null >> +++ b/xen/include/xen/frame-num.h > > It would feel more natural to me if the file is named mm-types.h. Indeed I was first meaning to use this name (not the least because I don't particularly like the one chosen, but I also couldn't think of a better one). However, then things like struct page_info would imo also belong there (more precisely in asm/mm-types.h to be included from here), which is specifically something I want to avoid. Yes, eventually we may (I'm inclined to even say "will") want such a header, but I still want to keep these even more fundamental types in a separate one. Otherwise we'll again end up with files including mm-types.h just because of needing e.g. gfn_t for a function declaration. (Note that the same isn't the case for struct page_info, which can simply be forward declared.) Jan