From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v2] testpmd: fix build on FreeBSD
Date: Fri, 25 Mar 2016 19:19:30 +0100
Message-ID: <3214773.8khuyX2P8h@xps13>
References: <1458524684-13539-1-git-send-email-yong.liu@intel.com>
 <20160325121040.GB18028@bricha3-MOBL3> <20160325121513.GC18028@bricha3-MOBL3>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: "Wu, Jingjing" <jingjing.wu@intel.com>, dev@dpdk.org
To: Bruce Richardson <bruce.richardson@intel.com>, "Liu,
 Yong" <yong.liu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44])
 by dpdk.org (Postfix) with ESMTP id CB34F5687
 for <dev@dpdk.org>; Fri, 25 Mar 2016 19:21:17 +0100 (CET)
Received: by mail-wm0-f44.google.com with SMTP id p65so30969911wmp.0
 for <dev@dpdk.org>; Fri, 25 Mar 2016 11:21:17 -0700 (PDT)
In-Reply-To: <20160325121513.GC18028@bricha3-MOBL3>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-03-25 12:15, Bruce Richardson:
> On Fri, Mar 25, 2016 at 12:10:40PM +0000, Bruce Richardson wrote:
> > On Wed, Mar 23, 2016 at 04:17:12PM +0100, Thomas Monjalon wrote:
> > > 2016-03-23 02:17, Wu, Jingjing:
> > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Marvin Liu
> > > > > Build log:
> > > > > /root/dpdk/app/test-pmd/cmdline.c:6687:45: error: no member named
> > > > > 's6_addr32' in 'struct in6_addr'
> > > > >     rte_be_to_cpu_32(res->ip_value.addr.ipv6.s6_addr32[i]);
> > > > > 
> > > > > This is caused by macro "s6_addr32" not defined on FreeBSD and testpmd
> > > > > swap big endian parameter to host endian. Move the swap action to i40e
> > > > > ethdev will fix this issue.
> > > > > 
> > > > > Fixes: 7b1312891b69 ("ethdev: add IP in GRE tunnel")
> > > > > 
> > > > > Signed-off-by: Marvin Liu <yong.liu@intel.com>
> > > > Acked-by: Jingjing Wu <jingjing.wu@intel.com>
> > > 
> > > It looks good but something is missing to decide that it is the right fix:
> > > the API do not state wether these fields (and others) are big endian or
> > > something else.
> > > 
> > > Please Jingjing, fix the ethdev comments for these fields and others
> > > rte_eth_ipv*_flow in a separate patch.
> > 
> > +1 to the more info because the endianness is confusing here. However, this look
> > a better fix than the previous one (v1 patch).
> > 
> > Thomas, can this be merged for RC2 to fix the BSD build, which should be a 
> > priority? Even if it's not the full solution, I think we need to at least get
> > the code building on BSD.
> > 
> > Thanks,
> > /Bruce
> 
> And I confirm this patch fixes the FreeBSD compile for both gcc and clang.
> 
> Tested-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks