From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55259) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKQXc-0000Pe-0N for qemu-devel@nongnu.org; Tue, 05 Jul 2016 09:37:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bKQXW-00088F-0W for qemu-devel@nongnu.org; Tue, 05 Jul 2016 09:37:30 -0400 Received: from mail-wm0-x235.google.com ([2a00:1450:400c:c09::235]:36236) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKQXV-000888-Pd for qemu-devel@nongnu.org; Tue, 05 Jul 2016 09:37:25 -0400 Received: by mail-wm0-x235.google.com with SMTP id f126so137834146wma.1 for ; Tue, 05 Jul 2016 06:37:25 -0700 (PDT) Sender: Paolo Bonzini References: <577A6955.6020603@kamp.de> <577B130A.3040205@redhat.com> From: Paolo Bonzini Message-ID: <3221d3d3-37ee-9752-396e-379792445ee0@redhat.com> Date: Tue, 5 Jul 2016 15:37:23 +0200 MIME-Version: 1.0 In-Reply-To: <577B130A.3040205@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] Regression: block: Add .bdrv_co_pwrite_zeroes() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , Peter Lieven , "qemu-devel@nongnu.org" Cc: Kevin Wolf On 05/07/2016 03:53, Eric Blake wrote: >> > I think we cannot assert that that these alignments are a power of 2. > Perhaps that means we should just fix our code to round things down to > the nearest power of 2 (8MB) for the opt_transfer_len and > opt_discard_alignment values. Can you post a stack-trace of the actual > assertion you are hitting? It doesn't work for opt_discard_alignment. Neither 8MB nor 16MB is aligned to 15MB for example. Paolo