From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754694AbdDEISb (ORCPT ); Wed, 5 Apr 2017 04:18:31 -0400 Received: from mx2.suse.de ([195.135.220.15]:54346 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753735AbdDEIS0 (ORCPT ); Wed, 5 Apr 2017 04:18:26 -0400 Subject: Re: [PATCH] xen, fbfront: fix connecting to backend To: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-fbdev@vger.kernel.org, b.zolnierkie@samsung.com References: <20170323125252.11763-1-jgross@suse.com> Cc: boris.ostrovsky@oracle.com, stable@vger.kernel.org From: Juergen Gross Message-ID: <3226cec6-8f68-6d15-4427-eb8f2d1944a1@suse.com> Date: Wed, 5 Apr 2017 10:18:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170323125252.11763-1-jgross@suse.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/03/17 13:52, Juergen Gross wrote: > Connecting to the backend isn't working reliably in xen-fbfront: in > case XenbusStateInitWait of the backend has been missed the backend > transition to XenbusStateConnected will trigger the connected state > only without doing the actions required when the backend has > connected. > > Cc: stable@vger.kernel.org > Signed-off-by: Juergen Gross Bartlomiej, any comments? Can you please take this patch or should I carry it through the Xen tree? Juergen > --- > drivers/video/fbdev/xen-fbfront.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c > index d0115a7..3ee309c 100644 > --- a/drivers/video/fbdev/xen-fbfront.c > +++ b/drivers/video/fbdev/xen-fbfront.c > @@ -643,7 +643,6 @@ static void xenfb_backend_changed(struct xenbus_device *dev, > break; > > case XenbusStateInitWait: > -InitWait: > xenbus_switch_state(dev, XenbusStateConnected); > break; > > @@ -654,7 +653,8 @@ static void xenfb_backend_changed(struct xenbus_device *dev, > * get Connected twice here. > */ > if (dev->state != XenbusStateConnected) > - goto InitWait; /* no InitWait seen yet, fudge it */ > + /* no InitWait seen yet, fudge it */ > + xenbus_switch_state(dev, XenbusStateConnected); > > if (xenbus_read_unsigned(info->xbdev->otherend, > "request-update", 0)) > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juergen Gross Date: Wed, 05 Apr 2017 08:18:21 +0000 Subject: Re: [PATCH] xen, fbfront: fix connecting to backend Message-Id: <3226cec6-8f68-6d15-4427-eb8f2d1944a1@suse.com> List-Id: References: <20170323125252.11763-1-jgross@suse.com> In-Reply-To: <20170323125252.11763-1-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-fbdev@vger.kernel.org, b.zolnierkie@samsung.com Cc: boris.ostrovsky@oracle.com, stable@vger.kernel.org On 23/03/17 13:52, Juergen Gross wrote: > Connecting to the backend isn't working reliably in xen-fbfront: in > case XenbusStateInitWait of the backend has been missed the backend > transition to XenbusStateConnected will trigger the connected state > only without doing the actions required when the backend has > connected. > > Cc: stable@vger.kernel.org > Signed-off-by: Juergen Gross Bartlomiej, any comments? Can you please take this patch or should I carry it through the Xen tree? Juergen > --- > drivers/video/fbdev/xen-fbfront.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c > index d0115a7..3ee309c 100644 > --- a/drivers/video/fbdev/xen-fbfront.c > +++ b/drivers/video/fbdev/xen-fbfront.c > @@ -643,7 +643,6 @@ static void xenfb_backend_changed(struct xenbus_device *dev, > break; > > case XenbusStateInitWait: > -InitWait: > xenbus_switch_state(dev, XenbusStateConnected); > break; > > @@ -654,7 +653,8 @@ static void xenfb_backend_changed(struct xenbus_device *dev, > * get Connected twice here. > */ > if (dev->state != XenbusStateConnected) > - goto InitWait; /* no InitWait seen yet, fudge it */ > + /* no InitWait seen yet, fudge it */ > + xenbus_switch_state(dev, XenbusStateConnected); > > if (xenbus_read_unsigned(info->xbdev->otherend, > "request-update", 0)) > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juergen Gross Subject: Re: [PATCH] xen, fbfront: fix connecting to backend Date: Wed, 5 Apr 2017 10:18:21 +0200 Message-ID: <3226cec6-8f68-6d15-4427-eb8f2d1944a1@suse.com> References: <20170323125252.11763-1-jgross@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cvg94-0004o6-GP for xen-devel@lists.xenproject.org; Wed, 05 Apr 2017 08:18:26 +0000 In-Reply-To: <20170323125252.11763-1-jgross@suse.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-fbdev@vger.kernel.org, b.zolnierkie@samsung.com Cc: boris.ostrovsky@oracle.com, stable@vger.kernel.org List-Id: xen-devel@lists.xenproject.org T24gMjMvMDMvMTcgMTM6NTIsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6Cj4gQ29ubmVjdGluZyB0byB0 aGUgYmFja2VuZCBpc24ndCB3b3JraW5nIHJlbGlhYmx5IGluIHhlbi1mYmZyb250OiBpbgo+IGNh c2UgWGVuYnVzU3RhdGVJbml0V2FpdCBvZiB0aGUgYmFja2VuZCBoYXMgYmVlbiBtaXNzZWQgdGhl IGJhY2tlbmQKPiB0cmFuc2l0aW9uIHRvIFhlbmJ1c1N0YXRlQ29ubmVjdGVkIHdpbGwgdHJpZ2dl ciB0aGUgY29ubmVjdGVkIHN0YXRlCj4gb25seSB3aXRob3V0IGRvaW5nIHRoZSBhY3Rpb25zIHJl cXVpcmVkIHdoZW4gdGhlIGJhY2tlbmQgaGFzCj4gY29ubmVjdGVkLgo+IAo+IENjOiBzdGFibGVA dmdlci5rZXJuZWwub3JnCj4gU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuY29tPgoKQmFydGxvbWllaiwgYW55IGNvbW1lbnRzPyBDYW4geW91IHBsZWFzZSB0YWtlIHRo aXMgcGF0Y2ggb3Igc2hvdWxkIEkKY2FycnkgaXQgdGhyb3VnaCB0aGUgWGVuIHRyZWU/CgoKSnVl cmdlbgoKPiAtLS0KPiAgZHJpdmVycy92aWRlby9mYmRldi94ZW4tZmJmcm9udC5jIHwgNCArKy0t Cj4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4gCj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvdmlkZW8vZmJkZXYveGVuLWZiZnJvbnQuYyBiL2RyaXZlcnMv dmlkZW8vZmJkZXYveGVuLWZiZnJvbnQuYwo+IGluZGV4IGQwMTE1YTcuLjNlZTMwOWMgMTAwNjQ0 Cj4gLS0tIGEvZHJpdmVycy92aWRlby9mYmRldi94ZW4tZmJmcm9udC5jCj4gKysrIGIvZHJpdmVy cy92aWRlby9mYmRldi94ZW4tZmJmcm9udC5jCj4gQEAgLTY0Myw3ICs2NDMsNiBAQCBzdGF0aWMg dm9pZCB4ZW5mYl9iYWNrZW5kX2NoYW5nZWQoc3RydWN0IHhlbmJ1c19kZXZpY2UgKmRldiwKPiAg CQlicmVhazsKPiAgCj4gIAljYXNlIFhlbmJ1c1N0YXRlSW5pdFdhaXQ6Cj4gLUluaXRXYWl0Ogo+ ICAJCXhlbmJ1c19zd2l0Y2hfc3RhdGUoZGV2LCBYZW5idXNTdGF0ZUNvbm5lY3RlZCk7Cj4gIAkJ YnJlYWs7Cj4gIAo+IEBAIC02NTQsNyArNjUzLDggQEAgc3RhdGljIHZvaWQgeGVuZmJfYmFja2Vu ZF9jaGFuZ2VkKHN0cnVjdCB4ZW5idXNfZGV2aWNlICpkZXYsCj4gIAkJICogZ2V0IENvbm5lY3Rl ZCB0d2ljZSBoZXJlLgo+ICAJCSAqLwo+ICAJCWlmIChkZXYtPnN0YXRlICE9IFhlbmJ1c1N0YXRl Q29ubmVjdGVkKQo+IC0JCQlnb3RvIEluaXRXYWl0OyAvKiBubyBJbml0V2FpdCBzZWVuIHlldCwg ZnVkZ2UgaXQgKi8KPiArCQkJLyogbm8gSW5pdFdhaXQgc2VlbiB5ZXQsIGZ1ZGdlIGl0ICovCj4g KwkJCXhlbmJ1c19zd2l0Y2hfc3RhdGUoZGV2LCBYZW5idXNTdGF0ZUNvbm5lY3RlZCk7Cj4gIAo+ ICAJCWlmICh4ZW5idXNfcmVhZF91bnNpZ25lZChpbmZvLT54YmRldi0+b3RoZXJlbmQsCj4gIAkJ CQkJICJyZXF1ZXN0LXVwZGF0ZSIsIDApKQo+IAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxp c3RzLnhlbi5vcmcKaHR0cHM6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=