From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA0A2ECAAA1 for ; Fri, 28 Oct 2022 11:01:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229379AbiJ1LBS convert rfc822-to-8bit (ORCPT ); Fri, 28 Oct 2022 07:01:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229500AbiJ1LBQ (ORCPT ); Fri, 28 Oct 2022 07:01:16 -0400 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.86.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54C5E1B7F32 for ; Fri, 28 Oct 2022 04:01:13 -0700 (PDT) Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-237-22Dr50z3PuWQWbxBYKSvpw-1; Fri, 28 Oct 2022 12:01:10 +0100 X-MC-Unique: 22Dr50z3PuWQWbxBYKSvpw-1 Received: from AcuMS.Aculab.com (10.202.163.4) by AcuMS.aculab.com (10.202.163.4) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 28 Oct 2022 12:01:08 +0100 Received: from AcuMS.Aculab.com ([::1]) by AcuMS.aculab.com ([::1]) with mapi id 15.00.1497.042; Fri, 28 Oct 2022 12:01:08 +0100 From: David Laight To: 'Peter Zijlstra' , "x86@kernel.org" CC: "linux-kernel@vger.kernel.org" , Kees Cook , Sami Tolvanen , "Joao Moreira" , Josh Poimboeuf , "Mark Rutland" Subject: RE: [PATCH 0/4] x86/ibt: Implement FineIBT Thread-Topic: [PATCH 0/4] x86/ibt: Implement FineIBT Thread-Index: AQHY6eaqrH5B7d5A2kqD+PKSAMrXq64jpC0w Date: Fri, 28 Oct 2022 11:01:08 +0000 Message-ID: <322c0b333f0a4a60be2a89f0cdf7edde@AcuMS.aculab.com> References: <20221027092812.185993858@infradead.org> In-Reply-To: <20221027092812.185993858@infradead.org> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Peter Zijlstra > Sent: 27 October 2022 10:28 > > Hi all, > > Updated FineIBT series; I've (hopefully) incorporated all feedback from last > time with the notable exception of the Kconfig CFI default -- I'm not sure we > want to add to the Kconfig space for this, also what would a distro do with it. > > Anyway; please have a look, I'm hoping to merge this soonish so we can make the > next cycle. Is there a test to ensure that modules are actually compiled with the required endbra, function prologue gap (etc). Having the module load fail is somewhat better than a crash. It is almost certainly quite easy to generate an out of tree module that is missing all of those (even if compiled at the same time as the kernel). (Never mind issues with modules that contain binary blobs.) David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)